linux-next: Fixes tag needs some work in the qcom tree

linux-next: Fixes tag needs some work in the qcom tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 520 bytes --]

Hi all,

In commit

  5827e2830467 ("arm64: dts: qcom: msm8994: Fix sleep clock name")

Fixes tag

  Fixes: 9204da57cd65 ("arm64: dts: qcom: msm8994: Provide missing "xo_board" and "sleep_clk" to GCC")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 4dd1ad619274 ("arm64: dts: qcom: msm8994: Provide missing "xo_board" and "sleep_clk" to GCC")

Also, please keep all the commit message tags together at the end of
the commit message.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the qcom tree

[Konrad Dybcio]

On 13.04.2022 23:40, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   5827e2830467 ("arm64: dts: qcom: msm8994: Fix sleep clock name")
> 
> Fixes tag
> 
>   Fixes: 9204da57cd65 ("arm64: dts: qcom: msm8994: Provide missing "xo_board" and "sleep_clk" to GCC")
> 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> Maybe you meant
> 
> Fixes: 4dd1ad619274 ("arm64: dts: qcom: msm8994: Provide missing "xo_board" and "sleep_clk" to GCC")
Yes, precisely this. Sorry for that, I probably forgot to rebase my local tree before checking that commit hash..

Bjorn, could you please fix that up directly in your tree?

Konrad
> 
> Also, please keep all the commit message tags together at the end of
> the commit message.
> 

linux-next: Fixes tag needs some work in the qcom tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 398 bytes --]

Hi all,

In commit

  1bd8c3ad02b1 ("clk: qcom: reset: Ensure write completion on reset de/assertion")

Fixes tag

  Fixes: db1029814f1f ("clk: qcom: reset: Ensure write completion on reset de/assertion")

has these problem(s):

  - Target SHA1 does not exist

And I can't find the intended commit since both the above subject lines
are identical.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the qcom tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 443 bytes --]

Hi all,

In commit

  981be238e1d2 ("dt-bindings: arm: msm: kpss-acc: Make the optional reg truly optional")

Fixes tag

  Fixes: 12f40018b6a9 ("dt-bindings: arm: msm: Convert kpss-acc driver Documentation to yaml")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 4260ddfb6496 ("dt-bindings: arm: msm: Convert and split kpss-acc driver Documentation to yaml")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the qcom tree

[Linus Walleij]

On Tue, May 30, 2023 at 4:53 PM Bjorn Andersson <andersson@kernel.org> wrote:

> >   Fixes: 04715461abf7 ("ARM: dts: qcom-msm8660: align RPM regulators node name with bindings")
> >
> > has these problem(s):
> >
> >   - Target SHA1 does not exist
> >
> > Maybe you meant
> >
> > Fixes: 85055a1eecc1 ("ARM: dts: qcom-msm8660: align RPM regulators node name with bindings")
> >
>
> Thank you Stephen, the tag has now been corrected.

Sorry for messing this up, thanks for fixing!

Yours,
Linus Walleij

Re: linux-next: Fixes tag needs some work in the qcom tree

[Bjorn Andersson]

On Tue, May 30, 2023 at 07:49:43AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   8b9ca2f3ea45 ("ARM: dts: qcom-apq8060: Fix regulator node names")
> 
> Fixes tag
> 
>   Fixes: 04715461abf7 ("ARM: dts: qcom-msm8660: align RPM regulators node name with bindings")
> 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> Maybe you meant
> 
> Fixes: 85055a1eecc1 ("ARM: dts: qcom-msm8660: align RPM regulators node name with bindings")
> 

Thank you Stephen, the tag has now been corrected.

Regards,
Bjorn

> -- 
> Cheers,
> Stephen Rothwell

linux-next: Fixes tag needs some work in the qcom tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 412 bytes --]

Hi all,

In commit

  8b9ca2f3ea45 ("ARM: dts: qcom-apq8060: Fix regulator node names")

Fixes tag

  Fixes: 04715461abf7 ("ARM: dts: qcom-msm8660: align RPM regulators node name with bindings")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 85055a1eecc1 ("ARM: dts: qcom-msm8660: align RPM regulators node name with bindings")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the qcom tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 411 bytes --]

Hi all,

In commit

  bdbff740e57e ("arm64: dts: qcom: sm8550: Fix PCIe PHYs and controllers nodes")

Fixes tag

  Fixes: 98a4dc3a78fa ("arm64: dts: qcom: sm8550: Add PCIe PHYs and controllers nodes")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 7d1158c984d3 ("arm64: dts: qcom: sm8550: Add PCIe PHYs and controllers nodes")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the qcom tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 893 bytes --]

Hi all,

In commits

  2e498f35c385 ("arm64: dts: qcom: sc8280xp-x13s: fix va dmic dai links and routing")
  4def7aa377ba ("arm64: dts: qcom: sc8280xp-x13s: fix dmic sample rate")

Fixes tag

  Fixes: 8c1ea87e80b4 ("arm64: dts: qcom: sc8280xp-x13s: Add soundcard support")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: f29077d86652 ("arm64: dts: qcom: sc8280xp-x13s: Add soundcard support")

In commits

  e43bd22cb377 ("arm64: dts: qcom: sc8280xp: fix lpass tx macro clocks")
  670b7d6569bf ("arm64: dts: qcom: sc8280xp: fix rx frame shapping info")

Fixes tag

  Fixes: 1749a8ae49a3 ("arm64: dts: qcom: sc8280xp: add SoundWire and LPASS")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: c18773d162a6 ("arm64: dts: qcom: sc8280xp: add SoundWire and LPASS")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the qcom tree

[Bartosz Golaszewski]

On Thu, 9 Feb 2023 at 05:05, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> In commit
>
>   e710abbb1740 ("clk: qcom: gcc-sa8775p: remove unused variables")
>
> Fixes tag
>
>   Fixes: ed432b1ed00a ("clk: qcom: add the GCC driver for sa8775p")
>
> has these problem(s):
>
>   - Target SHA1 does not exist
>
> Maybe you meant
>
> Fixes: 08c51ceb12f7 ("clk: qcom: add the GCC driver for sa8775p")
>

Yes, that is correct. Bjorn: Can you fix it in your tree?

Bartosz

linux-next: Fixes tag needs some work in the qcom tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 357 bytes --]

Hi all,

In commit

  e710abbb1740 ("clk: qcom: gcc-sa8775p: remove unused variables")

Fixes tag

  Fixes: ed432b1ed00a ("clk: qcom: add the GCC driver for sa8775p")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 08c51ceb12f7 ("clk: qcom: add the GCC driver for sa8775p")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the qcom tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 387 bytes --]

Hi all,

In commit

  19eee67386fe ("arm64: dts: qcom: sc8280xp: add p1 register blocks to DP nodes")

Fixes tag

  Fixes: 6f299ae7f96d ("arm64: dts: qcom: sc8280xp: add p1 register blocks to DP nodes")

has these problem(s):

  - Target SHA1 does not exist and the Fixes commit description is the
  same as the fixing commit description.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the qcom tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 414 bytes --]

Hi all,

In commit

  0da2eff44e78 ("arm64: dts: qcom: sm8450: Allow both GIC-ITS and internal MSI controller")

Fixes tag

  Fixes: a11bbf6adef4 ("arm64: dts: qcom: sm8450: Use GIC-ITS for PCIe0 and PCIe1")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: ff384ab56f16 ("arm64: dts: qcom: sm8450: Use GIC-ITS for PCIe0 and PCIe1")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the qcom tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 465 bytes --]

Hi all,

In commit

  31e4fcf97130 ("clk: qcom: lpass: Fix lpass audiocc probe")

Fixes tag

  Fixes: 7c6a6641c2 ("clk: qcom: lpass: Add support for resets & external mclk for SC7280")

has these problem(s):

  - SHA1 should be at least 12 digits long
    This can be fixed for the future by setting core.abbrev to 12 (or
    more) or (for git v2.11 or later) just making sure it is not set
    (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the qcom tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 420 bytes --]

Hi all,

In commit

  50ee65dc512b ("clk: qcom: sm6115: Select QCOM_GDSC")

Fixes tag

  Fixes: cbe63bfdc54f ("clk: qcom: Add Global Clock controller (GCC)

has these problem(s):

  - Subject has leading but no trailing quotes

It should have been:

Fixes: cbe63bfdc54f ("clk: qcom: Add Global Clock controller (GCC) driver for SM6115")

(no truncation or wrapping).

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the qcom tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 457 bytes --]

Hi all,

In commit

  ea58caed9926 ("clk: qcom: smd: Add missing RPM clocks for msm8992/4")

Fixes tag

  Fixes: b4297844995 ("clk: qcom: smd: Add support for MSM8992/4 rpm clocks")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed for the future by setting core.abbrev to 12 (or more)
    or (for git v2.11 or later) just making sure it is not set (or set to
    "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the qcom tree

[Robert Marko]

On Mon, 14 Feb 2022 at 05:50, Bjorn Andersson
<bjorn.andersson@linaro.org> wrote:
>
> On Sun 13 Feb 03:52 PST 2022, Robert Marko wrote:
>
> > On Sun, 13 Feb 2022 at 11:39, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > >
> > > Hi all,
> > >
> > > In commit
> > >
> > >   bf8f5182b8f5 ("clk: qcom: ipq8074: fix PCI-E clock oops")
> > >
> > > Fixes tag
> > >
> > >   Fixes: f0cfcf1a ("clk: qcom: ipq8074: Add missing clocks for pcie")
> > >
> > > has these problem(s):
> > >
> > >   - SHA1 should be at least 12 digits long
> > >     Can be fixed for the future by setting core.abbrev to 12 (or more)
> > >     or (for git v2.11 or later) just making sure it is not set (or set to
> > >     "auto").
> >
> > Hi Stephen,
> >
> > Sorry for the short hash, don't know how this happened.
> > Do you want me to send a v3 with the fixed hash?
> >
>
> No need, I could update the commit as is. But given that I would have to
> rebase 20 other patches I'm hesitant to fix it.

Thanks,

I will make sure not for this not to happen again.

Regards
>
> Given that checkpatch catches this issue in commit references in the
> message and other issues in Fixes I was expecting it to catch this one
> as well... Will make sure to look for this going forward (or perhaps
> figure out how to improve checkpatch...)
>
> Thanks,
> Bjorn

Re: linux-next: Fixes tag needs some work in the qcom tree

[Bjorn Andersson]

On Sun 13 Feb 03:52 PST 2022, Robert Marko wrote:

> On Sun, 13 Feb 2022 at 11:39, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > Hi all,
> >
> > In commit
> >
> >   bf8f5182b8f5 ("clk: qcom: ipq8074: fix PCI-E clock oops")
> >
> > Fixes tag
> >
> >   Fixes: f0cfcf1a ("clk: qcom: ipq8074: Add missing clocks for pcie")
> >
> > has these problem(s):
> >
> >   - SHA1 should be at least 12 digits long
> >     Can be fixed for the future by setting core.abbrev to 12 (or more)
> >     or (for git v2.11 or later) just making sure it is not set (or set to
> >     "auto").
> 
> Hi Stephen,
> 
> Sorry for the short hash, don't know how this happened.
> Do you want me to send a v3 with the fixed hash?
> 

No need, I could update the commit as is. But given that I would have to
rebase 20 other patches I'm hesitant to fix it.

Given that checkpatch catches this issue in commit references in the
message and other issues in Fixes I was expecting it to catch this one
as well... Will make sure to look for this going forward (or perhaps
figure out how to improve checkpatch...)

Thanks,
Bjorn

Re: linux-next: Fixes tag needs some work in the qcom tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 263 bytes --]

Hi Robert,

On Sun, 13 Feb 2022 12:52:45 +0100 Robert Marko <robimarko@gmail.com> wrote:
>
> Sorry for the short hash, don't know how this happened.
> Do you want me to send a v3 with the fixed hash?

That is up to Andy.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the qcom tree

[Robert Marko]

On Sun, 13 Feb 2022 at 11:39, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> In commit
>
>   bf8f5182b8f5 ("clk: qcom: ipq8074: fix PCI-E clock oops")
>
> Fixes tag
>
>   Fixes: f0cfcf1a ("clk: qcom: ipq8074: Add missing clocks for pcie")
>
> has these problem(s):
>
>   - SHA1 should be at least 12 digits long
>     Can be fixed for the future by setting core.abbrev to 12 (or more)
>     or (for git v2.11 or later) just making sure it is not set (or set to
>     "auto").

Hi Stephen,

Sorry for the short hash, don't know how this happened.
Do you want me to send a v3 with the fixed hash?

Regards,
Robert
>
> --
> Cheers,
> Stephen Rothwell

linux-next: Fixes tag needs some work in the qcom tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 437 bytes --]

Hi all,

In commit

  bf8f5182b8f5 ("clk: qcom: ipq8074: fix PCI-E clock oops")

Fixes tag

  Fixes: f0cfcf1a ("clk: qcom: ipq8074: Add missing clocks for pcie")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed for the future by setting core.abbrev to 12 (or more)
    or (for git v2.11 or later) just making sure it is not set (or set to
    "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the qcom tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 453 bytes --]

Hi all,

In commit

  66b788133030 ("arm64: dts: qcom: sc7280: Fix 'interrupt-map' parent address cells")

Fixes tag

  Fixes: 92e0ee9f8 ("arm64: dts: qcom: sc7280: Add PCIe and PHY related nodes")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the qcom tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 272 bytes --]

Hi Bjorn,

On Tue, 21 Sep 2021 16:31:38 -0700 Bjorn Andersson <bjorn.andersson@linaro.org> wrote:
>
> I should have double checked this before pushing out the rebased branch,
> but it looks okay to me (and checkpatch) now.

Thanks.
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the qcom tree

[Bjorn Andersson]

On Tue 21 Sep 16:02 PDT 2021, Stephen Rothwell wrote:

> Hi all,
> 
> On Tue, 21 Sep 2021 08:24:38 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > In commit
> > 
> >   33c4296d99ef ("arm64: dts: qcom: sc7280: fix display port phy reg property")
> 
> This is now commit 1a5968e5b7de.
> 
> > Fixes tag
> > 
> >   Fixes: 9886e8fd8438 ("arm64: dts: qcom: sc7280: Add USB related nodes")
> > 
> > has these problem(s):
> > 
> >   - Target SHA1 does not exist
> > 
> > Maybe you meant
> > 
> > Fixes: bb9efa59c665 ("arm64: dts: qcom: sc7280: Add USB related nodes")
> 
> Surely if you are going to rebase the tree anyway, you can fix this up
> :-(
> 

Yes of course!

I had made a git merge snafu earlier in the branch, fixed the fixes and
then fixed the snafu, which broke the fixes...

I should have double checked this before pushing out the rebased branch,
but it looks okay to me (and checkpatch) now.

Thanks,
Bjorn

Re: linux-next: Fixes tag needs some work in the qcom tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 610 bytes --]

Hi all,

On Tue, 21 Sep 2021 08:24:38 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> In commit
> 
>   33c4296d99ef ("arm64: dts: qcom: sc7280: fix display port phy reg property")

This is now commit 1a5968e5b7de.

> Fixes tag
> 
>   Fixes: 9886e8fd8438 ("arm64: dts: qcom: sc7280: Add USB related nodes")
> 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> Maybe you meant
> 
> Fixes: bb9efa59c665 ("arm64: dts: qcom: sc7280: Add USB related nodes")

Surely if you are going to rebase the tree anyway, you can fix this up
:-(

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the qcom tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 381 bytes --]

Hi all,

In commit

  33c4296d99ef ("arm64: dts: qcom: sc7280: fix display port phy reg property")

Fixes tag

  Fixes: 9886e8fd8438 ("arm64: dts: qcom: sc7280: Add USB related nodes")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: bb9efa59c665 ("arm64: dts: qcom: sc7280: Add USB related nodes")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the qcom tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 383 bytes --]

Hi all,

In commit

  d550173b0071 ("arm64: dts: qcom: sm8250: fix usb2 qmp phy node")

Fixes tag

  Fixes: be0624b99042 ("arm64: dts: qcom: sm8250: Add USB and PHY device nodes")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 46a6f297d7dd ("arm64: dts: qcom: sm8250: Add USB and PHY device nodes")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the qcom tree

[Robert Foss]

Hey Stephen,

On Thu, 21 Jan 2021 at 08:41, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> In commit
>
>   d4863ef399a2 ("arm64: dts: qcom: sdm845-db845c: Fix reset-pin of ov8856 node")
>
> Fixes tag
>
>   Fixes: d4919a44564b ("arm64: dts: qcom: sdm845-db845c: Add ov8856 & ov7251
>
> has these problem(s):
>
>   - Subject has leading but no trailing parentheses
>   - Subject has leading but no trailing quotes
>
> Pleas do not split Fixes tags over more than one line.  Also, keep all
> the commit message tags together at the end of the message.
>

That's on me. Would you like a resubmission with the above fixes?

> --
> Cheers,
> Stephen Rothwell

linux-next: Fixes tag needs some work in the qcom tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 496 bytes --]

Hi all,

In commit

  d4863ef399a2 ("arm64: dts: qcom: sdm845-db845c: Fix reset-pin of ov8856 node")

Fixes tag

  Fixes: d4919a44564b ("arm64: dts: qcom: sdm845-db845c: Add ov8856 & ov7251

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Pleas do not split Fixes tags over more than one line.  Also, keep all
the commit message tags together at the end of the message.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the qcom tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 344 bytes --]

Hi all,

In commit

  a5fccb62cc89 ("soc: qcom: aoss: Read back before triggering the IRQ")

Fixes tag

  Fixes: e91366b0a8f9 ("soc: qcom: aoss: Use wake_up_all() instead of wake_up_interruptible_all()")

has these problem(s):

  - Target SHA1 does not exist

I can't find a matching commit :-(

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the qcom tree

[Doug Anderson]

Hi,

On Thu, Feb 7, 2019 at 5:47 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi Andy,
>
> In commit
>
>   761f63b2ff21 ("arm64: dts: sdm845: Add clocks and iommus to WCN3990 WLAN node")
>
> Fixes tag
>
>   Fixes: be7019103469 ("dts: arm64/sdm845: Add WCN3990 WLAN module device node")
>
> has these problem(s):
>
>   - Target SHA1 does not exist
>
> Did you mean:
>
>   022bccb840b7 ("arm64: dts: sdm845: Add WCN3990 WLAN module device node")

+Bjorn

Looks like someone reorganized and/or rebased the tree after I sent
out my fix.  When I check locally I have the old commit still and the
new:

commit be7019103469e6ccb997f932d3e0dce0141a0eda
Author:     Govind Singh <govinds@codeaurora.org>
AuthorDate: Mon Nov 5 18:38:37 2018 +0530
Commit:     Bjorn Andersson <bjorn.andersson@linaro.org>
CommitDate: Wed Jan 16 14:13:41 2019 -0800

    dts: arm64/sdm845: Add WCN3990 WLAN module device node

    Add device node for the ath10k SNOC platform driver probe
    and add resources required for WCN3990 on SDM845 soc.

    Reviewed-by: Brian Norris <briannorris@chromium.org>
    Tested-by: Brian Norris <briannorris@chromium.org>
    Signed-off-by: Govind Singh <govinds@codeaurora.org>
    Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>

---

commit 022bccb840b7ff9c64a70e81ac017d4d10bb8a9c
Author:     Govind Singh <govinds@codeaurora.org>
AuthorDate: Mon Nov 5 18:38:37 2018 +0530
Commit:     Andy Gross <andy.gross@linaro.org>
CommitDate: Thu Jan 24 22:19:20 2019 -0600

    arm64: dts: sdm845: Add WCN3990 WLAN module device node

    Add device node for the ath10k SNOC platform driver probe
    and add resources required for WCN3990 on SDM845 soc.

    Reviewed-by: Brian Norris <briannorris@chromium.org>
    Tested-by: Brian Norris <briannorris@chromium.org>
    Signed-off-by: Govind Singh <govinds@codeaurora.org>
    Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
    Signed-off-by: Andy Gross <andy.gross@linaro.org>

linux-next: Fixes tag needs some work in the qcom tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 393 bytes --]

Hi Andy,

In commit

  761f63b2ff21 ("arm64: dts: sdm845: Add clocks and iommus to WCN3990 WLAN node")

Fixes tag

  Fixes: be7019103469 ("dts: arm64/sdm845: Add WCN3990 WLAN module device node")

has these problem(s):

  - Target SHA1 does not exist

Did you mean:

  022bccb840b7 ("arm64: dts: sdm845: Add WCN3990 WLAN module device node")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]