From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB2E4C43387 for ; Thu, 10 Jan 2019 20:12:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9575B206B7 for ; Thu, 10 Jan 2019 20:12:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730097AbfAJUMN (ORCPT ); Thu, 10 Jan 2019 15:12:13 -0500 Received: from gateway36.websitewelcome.com ([192.185.187.5]:27830 "EHLO gateway36.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730062AbfAJUMN (ORCPT ); Thu, 10 Jan 2019 15:12:13 -0500 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway36.websitewelcome.com (Postfix) with ESMTP id DAADA400C95EC for ; Thu, 10 Jan 2019 13:24:21 -0600 (CST) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id hggVgC6sw90onhggVgfurc; Thu, 10 Jan 2019 14:12:11 -0600 X-Authority-Reason: nr=8 Received: from [189.250.130.205] (port=41278 helo=[192.168.43.131]) by gator4166.hostgator.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.91) (envelope-from ) id 1ghggS-002eU3-LU; Thu, 10 Jan 2019 14:12:11 -0600 Subject: Re: [PATCH 11/41] scsi: bfa: bfa_fcs_rport: Mark expected switch fall-throughs From: "Gustavo A. R. Silva" To: Anil Gurumurthy , Sudarsana Kalluru Cc: "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org References: Message-ID: Date: Thu, 10 Jan 2019 14:12:07 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.250.130.205 X-Source-L: No X-Exim-ID: 1ghggS-002eU3-LU X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.43.131]) [189.250.130.205]:41278 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 49 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Friendly ping (second one): Who can ack/review/take this patch, please? Thanks -- Gustavo On 12/19/18 9:39 AM, Gustavo A. R. Silva wrote: > Hi, > > Friendly ping: > > Who can ack or review this patch, please? > > Thanks > -- > Gustavo > > On 11/27/18 10:27 PM, Gustavo A. R. Silva wrote: >> In preparation to enabling -Wimplicit-fallthrough, mark switch cases >> where we are expecting to fall through. >> >> Notice that I replaced "!! fall through !!" and "!!! fall through !!!" >> comments with "fall through" annotations, which is what GCC is >> expecting to find. >> >> Addresses-Coverity-ID: 744899 ("Missing break in switch") >> Addresses-Coverity-ID: 744900 ("Missing break in switch") >> Addresses-Coverity-ID: 744901 ("Missing break in switch") >> Signed-off-by: Gustavo A. R. Silva >> --- >>   drivers/scsi/bfa/bfa_fcs_rport.c | 19 +++++++------------ >>   1 file changed, 7 insertions(+), 12 deletions(-) >> >> diff --git a/drivers/scsi/bfa/bfa_fcs_rport.c b/drivers/scsi/bfa/bfa_fcs_rport.c >> index de50349a39ce..1e400f2aaece 100644 >> --- a/drivers/scsi/bfa/bfa_fcs_rport.c >> +++ b/drivers/scsi/bfa/bfa_fcs_rport.c >> @@ -427,17 +427,13 @@ bfa_fcs_rport_sm_plogi(struct bfa_fcs_rport_s *rport, enum rport_event event) >>       case RPSM_EVENT_LOGO_RCVD: >>           bfa_fcs_rport_send_logo_acc(rport); >> -        /* >> -         * !! fall through !! >> -         */ >> +        /* fall through */ >>       case RPSM_EVENT_PRLO_RCVD: >>           if (rport->prlo == BFA_TRUE) >>               bfa_fcs_rport_send_prlo_acc(rport); >>           bfa_fcxp_discard(rport->fcxp); >> -        /* >> -         * !! fall through !! >> -         */ >> +        /* fall through */ >>       case RPSM_EVENT_FAILED: >>           if (rport->plogi_retries < BFA_FCS_RPORT_MAX_RETRIES) { >>               rport->plogi_retries++; >> @@ -868,9 +864,7 @@ bfa_fcs_rport_sm_adisc_online(struct bfa_fcs_rport_s *rport, >>            * At least go offline when a PLOGI is received. >>            */ >>           bfa_fcxp_discard(rport->fcxp); >> -        /* >> -         * !!! fall through !!! >> -         */ >> +        /* fall through */ >>       case RPSM_EVENT_FAILED: >>       case RPSM_EVENT_ADDRESS_CHANGE: >> @@ -1056,6 +1050,7 @@ bfa_fcs_rport_sm_fc4_logosend(struct bfa_fcs_rport_s *rport, >>       case RPSM_EVENT_LOGO_RCVD: >>           bfa_fcs_rport_send_logo_acc(rport); >> +        /* fall through */ >>       case RPSM_EVENT_PRLO_RCVD: >>           if (rport->prlo == BFA_TRUE) >>               bfa_fcs_rport_send_prlo_acc(rport); >> @@ -1144,9 +1139,7 @@ bfa_fcs_rport_sm_hcb_offline(struct bfa_fcs_rport_s *rport, >>               bfa_fcs_rport_send_plogiacc(rport, NULL); >>               break; >>           } >> -        /* >> -         * !! fall through !! >> -         */ >> +        /* fall through */ >>       case RPSM_EVENT_ADDRESS_CHANGE: >>           if (!bfa_fcs_lport_is_online(rport->port)) { >> @@ -1303,6 +1296,7 @@ bfa_fcs_rport_sm_hcb_logosend(struct bfa_fcs_rport_s *rport, >>       case RPSM_EVENT_LOGO_RCVD: >>           bfa_fcs_rport_send_logo_acc(rport); >> +        /* fall through */ >>       case RPSM_EVENT_PRLO_RCVD: >>           if (rport->prlo == BFA_TRUE) >>               bfa_fcs_rport_send_prlo_acc(rport); >> @@ -1346,6 +1340,7 @@ bfa_fcs_rport_sm_logo_sending(struct bfa_fcs_rport_s *rport, >>       case RPSM_EVENT_LOGO_RCVD: >>           bfa_fcs_rport_send_logo_acc(rport); >> +        /* fall through */ >>       case RPSM_EVENT_PRLO_RCVD: >>           if (rport->prlo == BFA_TRUE) >>               bfa_fcs_rport_send_prlo_acc(rport); >>