From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27AB7C64E90 for ; Mon, 30 Nov 2020 10:39:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D4F80207BC for ; Mon, 30 Nov 2020 10:39:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727895AbgK3KjX (ORCPT ); Mon, 30 Nov 2020 05:39:23 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:41605 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726928AbgK3KjX (ORCPT ); Mon, 30 Nov 2020 05:39:23 -0500 Received: from [106.104.74.151] (helo=[192.168.31.192]) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1kjgZs-0000Am-90; Mon, 30 Nov 2020 10:38:40 +0000 Subject: Re: [PATCH 1/1] efi/efi_test: read RuntimeServicesSupported To: Heinrich Schuchardt , Ard Biesheuvel Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, Colin King , fwts-devel@lists.ubuntu.com References: <20201127192051.1430-1-xypron.glpk@gmx.de> <1fbab8b3-3a37-f3f5-39b4-0c8123d27b29@canonical.com> From: ivanhu Message-ID: Date: Mon, 30 Nov 2020 18:38:36 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/30/20 5:17 PM, Heinrich Schuchardt wrote: > On 11/30/20 9:16 AM, ivanhu wrote: >> Hi Heinrich, >> >> Thanks for the patch. >> It looks good to me, but I noticed that the runtime_supported_mask was >> introduced after 5.7-rc1. >> Maybe we should add the kernel version checking for the old kernels. > > This is a kernel patch. Why should we check the kernel version in the > kernel code? > > As patches may be back-ported we should not make any assumptions in fwts > based on the kernel version. If the ioctl() call fails with errno = > ENOTTY, we know that the kernel does not implement the ioctl call and we > have to assume that all runtime services are available. Sounds good to me, Acked-by: Ivan Hu And I will replace the reading RuntimeServicesSupported efi variable by using efi_test in fwts RuntimeServicesSupported tests. FWTS will still test those Unsupported Runtime services to check if it returns EFI_UNSUPPORTED correctly. Is that could solve your problem? If I remember correctly, the problem from you is not to test those marked Unsupported Runtime services. But from the Spec. 8.1 Runtime Services Rules and Restrictions, " Note that this is merely a hint to the OS, which it is free to ignore, and so the platform is still required to provide callable implementations of unsupported runtime services that simply return EFI_UNSUPPORTED. " Cheers, Ivan > > Best regards > > Heinrich > >> >> Cheers, >> Ivan >> >> On 11/28/20 3:20 AM, Heinrich Schuchardt wrote: >>> Since the UEFI 2.8A specification the UEFI enabled firmware provides a >>> configuration table EFI_RT_PROPERTIES_TABLE which indicates which >>> runtime >>> services are enabled. The EFI stub reads this table and saves the >>> value of >>> the field RuntimeServicesSupported internally. >>> >>> The Firmware Test Suite requires the value to determine if UEFI runtime >>> services are correctly implemented. >>> >>> With this patch an IOCTL call is provided to read the value of the field >>> RuntimeServicesSupported, e.g. >>> >>>      #define EFI_RUNTIME_GET_SUPPORTED_MASK \ >>>              _IOR('p', 0x0C, unsigned int) >>>      unsigned int mask; >>>      fd = open("/dev/efi_test", O_RDWR); >>>      ret = ioctl(fd, EFI_RUNTIME_GET_SUPPORTED_MASK, &mask); >>> >>> Signed-off-by: Heinrich Schuchardt >>> --- >>>   drivers/firmware/efi/test/efi_test.c | 16 ++++++++++++++++ >>>   drivers/firmware/efi/test/efi_test.h |  3 +++ >>>   2 files changed, 19 insertions(+) >>> >>> diff --git a/drivers/firmware/efi/test/efi_test.c >>> b/drivers/firmware/efi/test/efi_test.c >>> index ddf9eae396fe..47d67bb0a516 100644 >>> --- a/drivers/firmware/efi/test/efi_test.c >>> +++ b/drivers/firmware/efi/test/efi_test.c >>> @@ -663,6 +663,19 @@ static long >>> efi_runtime_query_capsulecaps(unsigned long arg) >>>       return rv; >>>   } >>> >>> +static long efi_runtime_get_supported_mask(unsigned long arg) >>> +{ >>> +    unsigned int __user *supported_mask; >>> +    int rv = 0; >>> + >>> +    supported_mask = (unsigned int *)arg; >>> + >>> +    if (put_user(efi.runtime_supported_mask, supported_mask)) >>> +        rv = -EFAULT; >>> + >>> +    return rv; >>> +} >>> + >>>   static long efi_test_ioctl(struct file *file, unsigned int cmd, >>>                               unsigned long arg) >>>   { >>> @@ -699,6 +712,9 @@ static long efi_test_ioctl(struct file *file, >>> unsigned int cmd, >>> >>>       case EFI_RUNTIME_RESET_SYSTEM: >>>           return efi_runtime_reset_system(arg); >>> + >>> +    case EFI_RUNTIME_GET_SUPPORTED_MASK: >>> +        return efi_runtime_get_supported_mask(arg); >>>       } >>> >>>       return -ENOTTY; >>> diff --git a/drivers/firmware/efi/test/efi_test.h >>> b/drivers/firmware/efi/test/efi_test.h >>> index f2446aa1c2e3..117349e57993 100644 >>> --- a/drivers/firmware/efi/test/efi_test.h >>> +++ b/drivers/firmware/efi/test/efi_test.h >>> @@ -118,4 +118,7 @@ struct efi_resetsystem { >>>   #define EFI_RUNTIME_RESET_SYSTEM \ >>>       _IOW('p', 0x0B, struct efi_resetsystem) >>> >>> +#define EFI_RUNTIME_GET_SUPPORTED_MASK \ >>> +    _IOR('p', 0x0C, unsigned int) >>> + >>>   #endif /* _DRIVERS_FIRMWARE_EFI_TEST_H_ */ >>> -- >>> 2.29.2 >>> >