From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22842C6FD1D for ; Tue, 21 Mar 2023 14:35:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231136AbjCUOfj (ORCPT ); Tue, 21 Mar 2023 10:35:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33064 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229873AbjCUOfh (ORCPT ); Tue, 21 Mar 2023 10:35:37 -0400 Received: from mail-io1-xd2a.google.com (mail-io1-xd2a.google.com [IPv6:2607:f8b0:4864:20::d2a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 68D4947435; Tue, 21 Mar 2023 07:35:36 -0700 (PDT) Received: by mail-io1-xd2a.google.com with SMTP id q6so7005143iot.2; Tue, 21 Mar 2023 07:35:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679409335; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=NLIEUjpPIkk5ZzeFs91fzheQ2P/C6YZLsjoyxu0zBSY=; b=YmaItWKwyThfHmmzmWbFEwaB6lWSDyG9F3mZkDIntHl7tNMjJp5VZQLtBR11IIoi8U 3U/Nl2zoVHdXFK9Me1m4Co/z/LBl8yzcGVdbZ9ZIQw4LQVDnVVTc7vVJlkqUkcUouXMw Vy8uednSlQJjcLxBhylmkzq+jEiyvY57lOz0mqK7O3jwzJTInmLFaMhnzC/AgaQfiX9R RvXDM/PsFZ+KrVqmjpZggst5V6OzRyRfYr+D0mZXIxy6Y3aJRFzSuFNPWxANq1359InO TeB7PkaKFBknkgFtvJoN4RLTqlcwPu1TqgW+CWQ9S+exXicIwPSBkcFEO2iT5m7ggwnF K85Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679409335; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NLIEUjpPIkk5ZzeFs91fzheQ2P/C6YZLsjoyxu0zBSY=; b=LwdFNiaymJv4FlHcvxWJKWVbi1ecCMLjWNpEaLpUMC67cgMzL0X1mfKGDf3M+FeJ/g 7g2X2VsCANE5QWbCEY9eZU76t8CarsvMMWUvVqRCuqhs9VHCtOLz+vf88b8924wqu6Cu iqd1cQ3Wj+JE4BcU41ge2DA0pHy6MxIlUvOtr9Q4ooj/sJjhEVwnoQXlqXV2wUqR2zLR 3sgvaCqm2QUXPRy165RHWVbub9cccJkCDWKGxYgLw7mf8ZfzTxKUcYzXhxQn84wkKogI kwFXjxtSJBF2vgG4dMBaETcfEiX7aaVCimtfj2XYc290xO9SPxUjxYCaZmJaOhBGesvk 9PGA== X-Gm-Message-State: AO0yUKWbsPynlK+QUpjK/kEecSLDHsePx1ORe4fKZ81liqDejGWCyHrV vU/6HEUugGV1Hx8uqoApA7k= X-Google-Smtp-Source: AK7set80j+wwwROdSByOE4y0Ml39evb+VWSLcs/srYh+mgkN0R2RD0cTX9+qLbvZ7EwqN3uGWL9t4A== X-Received: by 2002:a5e:8e09:0:b0:758:6d1e:2978 with SMTP id a9-20020a5e8e09000000b007586d1e2978mr841923ion.10.1679409335658; Tue, 21 Mar 2023 07:35:35 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id g8-20020a6b7608000000b0074c7db1470dsm3604347iom.20.2023.03.21.07.35.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Mar 2023 07:35:35 -0700 (PDT) Sender: Guenter Roeck Date: Tue, 21 Mar 2023 07:35:34 -0700 From: Guenter Roeck To: "andriy.shevchenko@linux.intel.com" Cc: "Winiarska, Iwona" , "pmenzel@molgen.mpg.de" , "linux-hwmon@vger.kernel.org" , "openbmc@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , "jdelvare@suse.com" , "fercerpav@gmail.com" Subject: Re: [PATCH] hwmon: (peci/cputemp) Fix miscalculated DTS for SKX Message-ID: References: <20230321090410.866766-1-iwona.winiarska@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 21, 2023 at 03:08:45PM +0200, andriy.shevchenko@linux.intel.com wrote: > On Tue, Mar 21, 2023 at 10:29:22AM +0000, Winiarska, Iwona wrote: > > On Tue, 2023-03-21 at 10:41 +0100, Paul Menzel wrote: > > > Am 21.03.23 um 10:04 schrieb Iwona Winiarska: > > ... > > > > This is not aligned. Why not only use one space before the equal sign? > > > > Yeah - same alignment problem is present in cpu_hsx and cpu_icx though, so I > > just followed along for skx to not stand out visually. > > So while I agree that alignment is broken here, I think it might be better to > > separate out the potential cleanup from the fix. > > I agree with Iwona. If community wants a cleanup, it can be created in > a separate patch. For the fixes it's better to reduce the unrelated churn. > I don't want a cleanup. The original author chose the alignment, I accepted it because I give submitters some slack when it comes to formatting as long as checkpatch doesn't complain, and I do not want to get into lets-change-alignment wars. Thanks, Guenter