From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030646AbdEWOjI (ORCPT ); Tue, 23 May 2017 10:39:08 -0400 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:34124 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S965197AbdEWOjE (ORCPT ); Tue, 23 May 2017 10:39:04 -0400 Subject: Re: [PATCH net-next 1/2] perf, bpf: add support for HW_CACHE and RAW events To: Peter Zijlstra References: <20170522224840.810121-1-ast@fb.com> <20170522224840.810121-2-ast@fb.com> <20170523074247.esnr4fj2squn4w2d@hirez.programming.kicks-ass.net> CC: "David S . Miller" , Brendan Gregg , Daniel Borkmann , Teng Qin , , , From: Alexei Starovoitov Message-ID: Date: Tue, 23 May 2017 07:38:08 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170523074247.esnr4fj2squn4w2d@hirez.programming.kicks-ass.net> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [2620:10d:c090:200::8:7f3e] X-ClientProxiedBy: CY4PR20CA0021.namprd20.prod.outlook.com (2603:10b6:903:98::31) To CO1PR15MB0968.namprd15.prod.outlook.com (2a01:111:e400:7b64::26) X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PR15MB0968: X-MS-Office365-Filtering-Correlation-Id: 0cab54f7-9587-470c-a2f2-08d4a1e95599 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423075)(201703031133081);SRVR:CO1PR15MB0968; X-Microsoft-Exchange-Diagnostics: 1;CO1PR15MB0968;3:IoeKb8NN75qoX8nlL1BPF747zlRY7g2odIMvmbsnMo9zCMoDAnyb43F2cnqEwDCJoiQJ7Q76FKLeLF1SZU9RqfZBzUNsGUGIXbOL9Qs1tYFPHHfkjvwlu+eXE2OWWVvRU1brotf1bnA/qKFKAk0iPplNDo1TKQZTyuV0AYQipLE2l+z+fYU0GCh0B1k+5SCIZwZfuP38SAV+qc9ju0UZDI0nWstnjyfZLnkLmoDRvLr5BB8Zgww162eBMmAArfDxphAtxPA4jhl7Cfxl1ELWKh4QUAVlXmVBkBCHtSdLpH25sdx9+DNq7LNWltO98QKlpHIQ1SVuhwh4Z2Zv3WVf1Q==;25:F3XlClGoPNRMkYXkhFBxd8lI6+3vagDwVq1RT7RieS7hm98FohMpV/Za0kJpXRevUCIFJVDTzDx3WZ0ZT79F34RluO7b5aWUjReQTyughCgtMjBx7TtGZwmmJOaZ/iTvHvzyWPxy55/WDxHr2fUv/oMhVWkrQA7xFLYdtIzfK/5vSuIUVK+jsVeZFQGP+Le3ohxtY1RxwbAzigFLcrbxLUxIiO9DKJh9/i6VHE7uucBb9kdHZVmKI2zSZk9tW4MDyPxoUJk47YQ5f49YH5ABaIIlAcC81yMyFhOOhNoVZZXdfspey8uhQo9VKoNZOS27sbdAFCtGsWwfL/OqEXIe9iJc+3AtIaP9iEtjsWwxlXprYP72Jz29EANxfy4cvd+bnQA4EZuVnCTMJNp276glfOpvTy2BFe8hQKRJY3C7foegUUOizCJWBUnwL+AsyayPiLw6Gh2YNXquitxOYM+5oOQ9a4+kWN88J+S2g8xcQ/8= X-Microsoft-Exchange-Diagnostics: 1;CO1PR15MB0968;31:VM1lCNMapFnqrKgqrBW2Xhh6Sj07Bf4G0Ogjf7X/eYdEIDFrW2sQPJSSZaLjzhzkAfZ6o2B+5K/0RFeEfV7WkqZgx0LvQeFhZXQEJMfsSYO5UrGuP5MxWSQMm6u57+sgZktjMCjhn5IVhsv9Mx/jQzHaDdYe61M7Cni/VTVwHZKoA4b9ZvBX2UYb9jHGTr3Qwa8BcIVKCZa4OOLPoQwfBUk7xLXWg58jIkKPbIGiTr4=;20:xiSgxl2iHh0sft8s6pRkxx53mqaWjOh2OWQDVNj0pg8BV+tWvl8EinrYjXvq3LXZ3ihYWmrKDQSLlXz8bgXg0xMoVpPq5VR1tyF1cBaOuvr9op37Cg1wQnzEs9cZLxvDR4JjfhC2uMHrzlP0YIIsIdbLfnuUEXq7VGjEe1frxbWtEIoIXgvGyL7MYSdVhj+YxptIWtWuIy/+7N0Xl5OpoF8Az8OWibrxDGJXol0wM1dBKuxldObxw1Z6lm9stGsUb40r+RnSbZE1Q7T9OMNiyagNtwkaH/gYYGjmFbzRePAzs3VfSwd85jiefdkKu/qYrgOs0J3GT5hTlBRsJrTGDGxoVQ60ScwVgA8MlloedqOZHWf5auio9BB6y4+CsaCtEl9Fb6TzOiViinKBpW5SqFq7hR9gz02w+MbiVRE0h3cEzEIqKDjwhD6YLR1gMcQY32UJSPJiqQmgFqCzLZr4qthAbVrvcXi+YNaMrIMRT5a02wLMzKa70jak3RfeteeX X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(67672495146484); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(93001095)(6041248)(20161123564025)(20161123558100)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123560025)(6072148);SRVR:CO1PR15MB0968;BCL:0;PCL:0;RULEID:;SRVR:CO1PR15MB0968; X-Microsoft-Exchange-Diagnostics: 1;CO1PR15MB0968;4:mNrXz9ZpBrQFTgSbixwTRoFyn5oFjmEhX/jDjB1ZWZxkIPPGft3SuaOPttKBKMsbCDl129s3qWzbxzuY4k43BWX6XoI/Gvmn353G1q333csQXBAjymvEqSkzO+zZT96tmd6fztp64r4TE8DWaWlkSTNy5EGJRJclE0qaxrehVZu0OouOoy5msIdBwBieZeRATWy1lgO7kZZAvyqKZplC0vPGrjhBL9bWq+omXNWOTQSYayXVixMS/PnO2YBZK6oSiLJgYsPWP2yB88vDfdP0OwsyxPfDg30NIrvEDPGoWr2cBHiDPaNa8w2oWPtQM44nadAZCPjwJKMvln0CfJmaMB/NqrWRrGMclO8V98cS3S7eWxcKBtkcYglUoD5utavWZMR8lD3CquUy0/PEdBKfdbyEb1yNsTg1Wu5f9ycEThbKRPkbmUgTSepx7MSu8ktxpq9HCOpHaRftH6Qo/X9CjLbGQD6TMLMBm7/fmy6K4DPTnT3loMmZ3oUB+to415Hmi4nj7LNXSOk0chYiX6blHmUfopyucLvv+mmwjul7JbrA2UpJnbD/xzWOX/C+tO+uOlluiUU2Qmx6Yi22gp4U7ZT/C2zIlLNkpasIbKNgbLIgBSgrNMESyWuoUPDhisag3G8dO9Z6IJoLpH7Qj2mObDuMfxUPqXoI4blcIsvX7LA+xIRwqQsqQlDBhUoE0Begkt2MGTvMTNCPqvKZg70Gmnr1fQZuXd0sY2j3IbH7RktzSv6NLdvzjZiWb/vmav558SoT1WJoCT5cyqW3WEgFiaeGuPIaecEHTbarnyNfqzGJTZD2xhLf0uHrJ9qhMQfmeKSUvVH9uR2ZTJNO8II6Ow== X-Forefront-PRVS: 0316567485 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(39850400002)(39840400002)(39410400002)(39400400002)(39450400003)(24454002)(377454003)(4326008)(31686004)(42186005)(6116002)(2950100002)(6916009)(110136004)(38730400002)(54906002)(50466002)(47776003)(5660300001)(54356999)(76176999)(229853002)(65826007)(5890100001)(65956001)(50986999)(189998001)(478600001)(4001350100001)(53936002)(81166006)(8676002)(6486002)(7736002)(83506001)(86362001)(305945005)(33646002)(2906002)(230700001)(31696002)(23746002)(53546009)(25786009)(36756003)(64126003)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:CO1PR15MB0968;H:[IPv6:2620:10d:c082:1055:99ae:b7a5:7e6d:7ac1];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;CO1PR15MB0968;23:YY5lXJAYBLakYvRiKNOtN803ayZSVeFRRKYSh?= =?Windows-1252?Q?p96dCCJRRBJ/j3LpR4IyAWhn1hRYecZMuQJTRh1d1J9S/b9ntZBAU9I8?= =?Windows-1252?Q?LsTzYA5mqsctcLfxi7ihmYMfy8FistFaKk/oFhFPlhHgg5jnFYsnP2P/?= =?Windows-1252?Q?ds8uWULVSpVwoZrtda4DXW8d5o2P+rU8BDKykYkyQgueNrHu8MWZ35YF?= =?Windows-1252?Q?YnsVJeZ125cZ3tk9jBynlvB4XMZCkF2KBNde0BcZBJJaVf+JCINQiJXV?= =?Windows-1252?Q?VgYj6vflCc5JWZZBPekCvsk9mdFi3m5y2gtEtkM/3gitqmWJWpDGDBWk?= =?Windows-1252?Q?Ae+q36Eeai8VYM8GzEJj+yUhWgLEdN59qI76UGY9Q/Ulkf+CsBbUs68M?= =?Windows-1252?Q?Dup3pD+gT7nQK+S5rZyMuKFDSDZhpAn1NKMBXYhy7fkkNx1uosTLrWCj?= =?Windows-1252?Q?bb0J86s7BnUZF/tUm7rZS01M6UnWvlefSaxVNNX/phtw4xAROiphaXYU?= =?Windows-1252?Q?bpyyDOykSQXkcI6iMfztLZyyXeH3hpnJtF4YfUdatnSSQnWgrTZVVL5A?= =?Windows-1252?Q?weLDD5b1fAsctvjC5Z0VvHZYrk3Os9mITWRzGuodNjQFRFGCbUgLC+wB?= =?Windows-1252?Q?C8JKvc8XZttqHM2F+AqxAWSFprAhdLNOzH/J9knlM9hsNAo6uqASMWdc?= =?Windows-1252?Q?w0kQsBva6RJQUeETYNlHZAnya0i9mDOCDDCyu2+1m+V38tfdfs96LoM0?= =?Windows-1252?Q?1KXSqs7pIU44dgqJ6uPsEy13v9VBkAjgBFVLeZnELvIrZ8OoX4Z7OU1Q?= =?Windows-1252?Q?6c1uw7lD60tKMW16cHsR4xDwee13wUauvHfSADeu87x3XvKM44y6L0FZ?= =?Windows-1252?Q?wHHPqObYdWzceT8wpAovn0Cr+X8Ph7gBfqfs0/aZELMfGdW+O+dUjzdC?= =?Windows-1252?Q?3Y2JAsn3w5YdTTAslV0ouqPvgFj1QHfP6AXGg68DjEywHZLKYTpSeQ9c?= =?Windows-1252?Q?ItCeFugG1oW0hnPNkGEo270lOPredizh+hM5gPN7BS5GTp0tEU6iPeSo?= =?Windows-1252?Q?C9ycR40PV39URuyTvSkwHqe/3LRwzZuW1Axux6EbufpwlDITnt0Na8ib?= =?Windows-1252?Q?MNcA3l9R613stLJcrxoB/f4Ka4Gaz4Lj01S7eQmFa2rM4fpYDT6NjaJI?= =?Windows-1252?Q?KWTwRoSiq1f2If3HKoLzy39yg5B8IrEUXehN2fUVRWQPJKGulfciAjgw?= =?Windows-1252?Q?1t87jJ3uq9Qd0mFqzW/EAM5HU0/mOFzU75E7xUJ9bF+nYXyWv0sZREIf?= =?Windows-1252?Q?v/8/KvJ5rbMU8uY2rK1oHqm2F+K9vDoBnjvvkgElamnpGA=3D?= X-Microsoft-Exchange-Diagnostics: 1;CO1PR15MB0968;6:KuZIX1fIppLmDKy7XjzOoUbhAw06V1rpOtj6A7twZsGP2HSua80aq9i8f6hdgnWxlpoXpWiqRanC0ldHA1J0ph0lhABFJzfMkSuYEUHD0Xik4JxwMym7PGy8KIBy5gQvP9nel0ZqkqVQOkaQ56PmKdP7tkg6JaX0gZTbTvaN478aoKX4YQshqz1jJMvMdp1ITCTUeNOhKPH9XUkxK7ttBJjizFmGf16JhQF+xIpe7qlbX5w+3TYtSt76MEvieqoy977PhggHqGaL37C+qYj3k59QX6WQ89PiXvK+fD0LW9HWlDMP17eyJXBByitrEuvMqKSI/C0WPSDhNO+Cham6xgjFWPWusxAJgfYh5OgHIhh7Nu4co/XdmD85Hdty4nlMYMYIa8F/0ybqBjJpb0hAB4PXJzAt5qbxLz/wE0lv8K7xVXLS9MntUjUA9goBzB2h4eN/eKsPt8HDR0RDXFQjPUqCiE1H+/+1Js0iXXgvLAy7480c+PQ4a3QXcjf2LVf0xyM150q+My++ZqrRM/L13g==;5:g13fCX2M1oVU+tCcEfRW7b2g7RE9XwEhsQTFEVBEIDvrURFcaRtpY4KvDWg0ub7bvLUzrYO28bmeyWJbz2KwsBNSTyzhJmR7wiVQ9DRqeKvc041FWYN6aNt847K9qflClwyn5uS+WNqQPgIOk/jraw==;24:27Svi4SlujC68Bh5otKZO3aQEn5tvi2v3/jJzV/N4eMqfx4r/dK9PkjQXqEIWtLZfAxWKCSHYDkQlKAHPGE0/3WSb9ZR7cnoGmn3N2z4U+E= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CO1PR15MB0968;7:1qnr8eiYiB5NLWxaxNphx90mUPlS2y7g5Of6hsVZQW9pVYYPsNrcQhH2lHGMYeqhtDZgMUKeGADDdBjIBssNk7gg40Y9zSBJquTrI7kpKNxACimm8HqW++ooLB6Xc+Pfoqs49ZR/gPJnCjhabMNcg3a4ql9jFpheUF3zJQm3YsKsMVwOXj4wVxZoGmUBOle7PNw3NckDCqpbb6tU4oZEojmNOrHLE7CEF+AFIG7gK4N0wZmgBR+IWimO4VjCRK5dOXNaRhSOCpjn+emIwc5Py4DbqiKvfTuukpnEYcJ3wfkesnEcFgYFHWrQI6jMhtzPqWSPkiXSH657vOiQ4mLqlw==;20:Vee9u2QxqVYqeEBIqWqMJLizeZ4wAQHD2V1aTrtrpwDDqwIPJOKfDdzEvbqqGPbCiEGfFchNKNXeO/lMy2O88Pl7auztCZm3wx19SrdtgNx7qnWYxMR8nbSJEZHQenEjcJiR7QUwJiJG24FkTKfddCt1gPhdnyDITpPQLZ2/rGM= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2017 14:38:09.1287 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR15MB0968 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-05-23_04:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/23/17 12:42 AM, Peter Zijlstra wrote: > On Mon, May 22, 2017 at 03:48:39PM -0700, Alexei Starovoitov wrote: >> From: Teng Qin >> >> This commit adds support for attach BPF program to RAW and HW_CACHE type >> events, and support for read HW_CACHE type event counters in BPF >> program. Existing code logic already supports them, so this commit is >> just update Enum value checks. > > So what I'm missing is why they were not supported previously, and what > changed to allow it now. that code path simply wasn't tested previously. Nothing changed on bpf side and on perf side. Why it wasn't added on day one? There was no demand. Now people use bpf more and more and few folks got confused that these types of perf events were not supported, hence we're adding it.