From: Keerthy <j-keerthy@ti.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: <broonie@kernel.org>, <robh+dt@kernel.org>, <t-kristo@ti.com>,
<tony@atomide.com>, <mark.rutland@arm.com>,
<linux-omap@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>
Subject: Re: [PATCH 1/3] mfd: lp87565: Add lp87565 PMIC support
Date: Tue, 23 May 2017 17:51:12 +0530 [thread overview]
Message-ID: <b2604ba7-457e-ea71-924b-934d8bb293ef@ti.com> (raw)
In-Reply-To: <ce83f605-879b-dee0-d09e-63d01a7f66c7@ti.com>
On Tuesday 23 May 2017 03:41 PM, Keerthy wrote:
>
>
> On Tuesday 23 May 2017 02:15 PM, Lee Jones wrote:
>> On Tue, 23 May 2017, Keerthy wrote:
>>> On Tuesday 23 May 2017 12:27 PM, Lee Jones wrote:
>>>> On Tue, 23 May 2017, Keerthy wrote:
>>>>> On Monday 22 May 2017 11:18 PM, Lee Jones wrote:
>>>>>> On Fri, 19 May 2017, Keerthy wrote:
>>>>>>
>>>>>>> The LP87565 chip is a power management IC for Portable Navigation Systems
>>>>>>> and Tablet Computing devices. It contains the following components:
>>>>>>>
>>>>>>> - Configurable Bucks(Single and multi-phase).
>>>>>>> - Configurable General Purpose Output Signals (GPO).
>>>>>>>
>>>>>>> The LP87565-Q1 variant device uses two 2-phase outputs configuration,
>>>>>>> Buck0 is master for Buck0/1 output and Buck2 is master for Buck2/3
>>>>>>> output.
>>>>>>>
>>>>>>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>>>>>>> ---
>>>>>>> Documentation/devicetree/bindings/mfd/lp87565.txt | 44 ++++
>>>>>>> drivers/mfd/Kconfig | 14 ++
>>>>>>> drivers/mfd/Makefile | 1 +
>>>>>>> drivers/mfd/lp87565.c | 103 ++++++++
>>>>>>> include/linux/mfd/lp87565.h | 275 ++++++++++++++++++++++
>>>>>>> 5 files changed, 437 insertions(+)
>>>>>>> create mode 100644 Documentation/devicetree/bindings/mfd/lp87565.txt
>>>>>>> create mode 100644 drivers/mfd/lp87565.c
>>>>>>> create mode 100644 include/linux/mfd/lp87565.h
>>>>>>>
>>>>
>>>> [...]
>>>>
>>>>>>> +/*
>>>>>>> + * Copyright (C) 2017 Texas Instruments Incorporated - http://www.ti.com/
>>>>>>> + *
>>>>>>> + * Author: Keerthy <j-keerthy@ti.com>
>>>>>>
>>>>>> We usually ask for full "first last" names.
>>>>>
>>>>> Keerthy is my full name and i do not have a surname.
>>>>
>>>> What is the 'J' for in your email address?
>>>
>>> Father's initials.
>>
>> Okay.
>>
>>>> [...]
>>>>
>>>>>>> +static const struct i2c_device_id lp87565_id_table[] = {
>>>>>>> + { "lp87565-q1", 0 },
>>>>>>> + { },
>>>>>>> +};
>>>>>>> +MODULE_DEVICE_TABLE(i2c, lp87565_id_table);
>>>>>>
>>>>>> Is this an OF only driver, or not?
>>>>
>>>> You didn't answer my question?
>>>
>>> Sorry i replied on top again. It will be an OF only driver.
>>
>> Okay, then you don't need this table and you should depend on OF in
>> the Kconfig file.
>
> Okay. Cool thanks for this info.
>
> I am seeing this commit: 4895e493f91bff7f96f328b883c7f6448aa6abc6
>
> mfd: Export OF module alias information in missing drivers
>
> So no need of i2c_device_id for any of the OF-only mfd drivers?
Referred drivers/mfd/max77686.c driver. Used probe_new. Posted v2.
>
>>
next prev parent reply other threads:[~2017-05-23 12:21 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-19 12:42 [PATCH 0/3] mfd: lp87565: Add lp87565 PMIC support Keerthy
2017-05-19 12:42 ` [PATCH 1/3] " Keerthy
2017-05-19 15:42 ` Andrew F. Davis
2017-05-22 4:23 ` Keerthy
2017-05-23 3:08 ` Keerthy
2017-05-23 6:56 ` Lee Jones
2017-05-22 17:48 ` Lee Jones
2017-05-23 2:35 ` Keerthy
2017-05-23 3:00 ` Keerthy
2017-05-23 6:57 ` Lee Jones
2017-05-23 7:41 ` Keerthy
2017-05-23 7:58 ` Keerthy
2017-05-23 8:47 ` Lee Jones
2017-05-23 9:53 ` Keerthy
2017-05-23 8:45 ` Lee Jones
2017-05-23 10:11 ` Keerthy
2017-05-23 12:21 ` Keerthy [this message]
2017-05-23 15:39 ` Lee Jones
2017-05-19 12:42 ` [PATCH 2/3] regulator: lp87565: Add support for lp87565 PMIC regulators Keerthy
2017-05-19 15:53 ` Andrew F. Davis
2017-05-22 4:28 ` Keerthy
2017-05-19 12:42 ` [PATCH 3/3] regulator: tps65917: Add support for SMPS12 Keerthy
2017-05-22 17:41 ` Lee Jones
2017-05-26 11:42 ` Applied "regulator: tps65917: Add support for SMPS12" to the regulator tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2604ba7-457e-ea71-924b-934d8bb293ef@ti.com \
--to=j-keerthy@ti.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).