From: David Hildenbrand <david@redhat.com>
To: Mel Gorman <mgorman@techsingularity.net>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Oscar Salvador <osalvador@suse.de>,
"Michael S. Tsirkin" <mst@redhat.com>,
Vlastimil Babka <vbabka@suse.cz>,
Alexander Duyck <alexanderduyck@fb.com>,
Minchan Kim <minchan@kernel.org>, Michal Hocko <mhocko@suse.com>,
Linux-MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 resend] mm/memory_hotplug: Make unpopulated zones PCP structures unreachable during hot remove
Date: Mon, 12 Apr 2021 14:12:00 +0200 [thread overview]
Message-ID: <b2696b77-9fe0-714f-6bdd-efc267974cfa@redhat.com> (raw)
In-Reply-To: <20210412120842.GY3697@techsingularity.net>
On 12.04.21 14:08, Mel Gorman wrote:
> zone_pcp_reset allegedly protects against a race with drain_pages
> using local_irq_save but this is bogus. local_irq_save only operates
> on the local CPU. If memory hotplug is running on CPU A and drain_pages
> is running on CPU B, disabling IRQs on CPU A does not affect CPU B and
> offers no protection.
>
> This patch deletes IRQ disable/enable on the grounds that IRQs protect
> nothing and assumes the existing hotplug paths guarantees the PCP cannot be
> used after zone_pcp_enable(). That should be the case already because all
> the pages have been freed and there is no page to put on the PCP lists.
>
> Signed-off-by: Mel Gorman <mgorman@techsingularity.net>
> ---
> Resending for email address correction and adding lists
>
> Changelog since v1
> o Minimal fix
>
> mm/page_alloc.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 5e8aedb64b57..9bf0db982f14 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -8952,12 +8952,9 @@ void zone_pcp_enable(struct zone *zone)
>
> void zone_pcp_reset(struct zone *zone)
> {
> - unsigned long flags;
> int cpu;
> struct per_cpu_pageset *pset;
>
> - /* avoid races with drain_pages() */
> - local_irq_save(flags);
> if (zone->pageset != &boot_pageset) {
> for_each_online_cpu(cpu) {
> pset = per_cpu_ptr(zone->pageset, cpu);
> @@ -8966,7 +8963,6 @@ void zone_pcp_reset(struct zone *zone)
> free_percpu(zone->pageset);
> zone->pageset = &boot_pageset;
> }
> - local_irq_restore(flags);
> }
>
> #ifdef CONFIG_MEMORY_HOTREMOVE
>
This was originally introduced by 340175b7d14d ("mm/hotplug: free
zone->pageset when a zone becomes empty").
I wonder why it was ever added. Could it be that drain_pages() could
have been called from an interrupt handler (e.g., on concurrent CPU
hotunplug of the current CPU?) back then while we are just about to
remove it ourselves?
Anyhow, if we need some protection after setting the zone unpopulated
(setting present_pages = 0), it doesn't seem like disabling local IRQs
is the right thing to do.
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2021-04-12 12:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-12 12:08 [PATCH v2 resend] mm/memory_hotplug: Make unpopulated zones PCP structures unreachable during hot remove Mel Gorman
2021-04-12 12:12 ` David Hildenbrand [this message]
2021-04-12 12:40 ` Vlastimil Babka
2021-04-12 14:08 ` Mel Gorman
2021-04-12 14:12 ` David Hildenbrand
2021-04-12 15:27 ` Mel Gorman
2021-04-12 16:02 ` David Hildenbrand
2021-04-13 9:36 ` Vlastimil Babka
2021-04-13 9:49 ` Mel Gorman
2021-04-13 10:16 ` Michal Hocko
2021-04-13 6:44 ` Michal Hocko
2021-04-13 6:40 ` Michal Hocko
2021-04-14 7:18 ` Oscar Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2696b77-9fe0-714f-6bdd-efc267974cfa@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alexanderduyck@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
--cc=mst@redhat.com \
--cc=osalvador@suse.de \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).