From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Dan Murphy <dmurphy@ti.com>, pavel@ucw.cz
Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v19 04/18] leds: multicolor: Introduce a multicolor class definition
Date: Tue, 7 Apr 2020 23:08:27 +0200 [thread overview]
Message-ID: <b27b21bf-9a7a-8233-d033-17bae43b297d@gmail.com> (raw)
In-Reply-To: <20200402204311.14998-5-dmurphy@ti.com>
Dan,
One more nit below.
On 4/2/20 10:42 PM, Dan Murphy wrote:
> Introduce a multicolor class that groups colored LEDs
> within a LED node.
>
> The multi color class groups monochrome LEDs and allows controlling two
> aspects of the final combined color: hue and lightness. The former is
> controlled via <color>_intensity files and the latter is controlled
> via brightness file.
[...]
> # LED Platform Drivers
> diff --git a/drivers/leds/led-class-multicolor.c b/drivers/leds/led-class-multicolor.c
> new file mode 100644
> index 000000000000..838b1d679647
> --- /dev/null
> +++ b/drivers/leds/led-class-multicolor.c
> @@ -0,0 +1,206 @@
> +// SPDX-License-Identifier: GPL-2.0
> +// LED Multi Color class interface
> +// Copyright (C) 2019-20 Texas Instruments Incorporated - http://www.ti.com/
> +// Author: Dan Murphy <dmurphy@ti.com>
> +
> +#include <linux/device.h>
> +#include <linux/init.h>
> +#include <linux/led-class-multicolor.h>
> +#include <linux/module.h>
> +#include <linux/slab.h>
> +#include <linux/uaccess.h>
> +
> +#include "leds.h"
> +
> +int led_mc_calc_color_components(struct led_classdev_mc *mcled_cdev,
> + enum led_brightness brightness)
> +{
> + struct led_classdev *led_cdev = &mcled_cdev->led_cdev;
> + int i;
> +
> + for (i = 0; i < mcled_cdev->num_colors; i++)
> + mcled_cdev->multicolor_info[i].color_brightness = (brightness *
If you passed temporary array for collecting calculated brightness
items to this function then you could remove this color_brightness
field from struct multicolor_info.
> + mcled_cdev->multicolor_info[i].color_led_intensity /
> + led_cdev->max_brightness);
> +
> + return 0;
[...]
> +MODULE_AUTHOR("Dan Murphy <dmurphy@ti.com>");
> +MODULE_DESCRIPTION("Multi Color LED class interface");
> +MODULE_LICENSE("GPL v2");
> diff --git a/include/linux/led-class-multicolor.h b/include/linux/led-class-multicolor.h
> new file mode 100644
> index 000000000000..a6a3715c0d48
> --- /dev/null
> +++ b/include/linux/led-class-multicolor.h
> @@ -0,0 +1,121 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/* LED Multicolor class interface
> + * Copyright (C) 2019-20 Texas Instruments Incorporated - http://www.ti.com/
> + */
> +
> +#ifndef __LINUX_MULTICOLOR_LEDS_H_INCLUDED
> +#define __LINUX_MULTICOLOR_LEDS_H_INCLUDED
> +
> +#include <linux/leds.h>
> +#include <dt-bindings/leds/common.h>
> +
> +struct led_multicolor_info {
s/led_multicolor_info/led_mc_subled/ ?
> + int color_index;
> + int color_brightness;
This should not be needed.
> + int color_led_intensity;
> + int color_channel;
> +};
> +
> +struct led_classdev_mc {
> + /* led class device */
> + struct led_classdev led_cdev;
> + int num_colors;
> +
> + struct led_multicolor_info multicolor_info[LED_COLOR_ID_MAX];
> +};
--
Best regards,
Jacek Anaszewski
next prev parent reply other threads:[~2020-04-07 21:08 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-02 20:42 [PATCH v19 00/18] Multicolor Framework (array edition) Dan Murphy
2020-04-02 20:42 ` [PATCH v19 01/18] dt: bindings: Add multicolor class dt bindings documention Dan Murphy
2020-04-06 20:12 ` Pavel Machek
2020-04-02 20:42 ` [PATCH v19 02/18] dt-bindings: leds: Add multicolor ID to the color ID list Dan Murphy
2020-04-02 20:42 ` [PATCH v19 03/18] " Dan Murphy
2020-04-06 20:13 ` Pavel Machek
2020-04-14 13:21 ` Dan Murphy
2020-04-02 20:42 ` [PATCH v19 04/18] leds: multicolor: Introduce a multicolor class definition Dan Murphy
2020-04-03 3:47 ` Randy Dunlap
2020-04-03 14:39 ` Dan Murphy
2020-04-05 15:08 ` Jacek Anaszewski
[not found] ` <f09dadc9-f1ed-091b-f241-2f40b48f1117@ti.com>
2020-04-05 16:28 ` Randy Dunlap
2020-04-05 16:31 ` Dan Murphy
2020-04-06 14:33 ` Dan Murphy
2020-04-06 19:25 ` Jacek Anaszewski
2020-04-07 14:52 ` Dan Murphy
2020-04-07 21:08 ` Jacek Anaszewski [this message]
2020-04-08 16:33 ` Dan Murphy
2020-04-08 16:35 ` Dan Murphy
2020-04-14 13:23 ` Dan Murphy
2020-04-09 5:25 ` Vesa Jääskeläinen
2020-04-14 13:21 ` Dan Murphy
2020-04-02 20:42 ` [PATCH v19 05/18] dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers Dan Murphy
2020-04-02 20:42 ` [PATCH v19 06/18] leds: lp50xx: Add the LP50XX family of the RGB LED driver Dan Murphy
2020-04-02 20:43 ` [PATCH v19 07/18] dt: bindings: lp55xx: Be consistent in the document with LED acronym Dan Murphy
2020-04-02 20:43 ` [PATCH v19 08/18] dt: bindings: lp55xx: Update binding for Multicolor Framework Dan Murphy
2020-04-02 20:43 ` [PATCH v19 09/18] ARM: dts: n900: Add reg property to the LP5523 channel node Dan Murphy
2020-04-02 20:43 ` [PATCH v19 10/18] ARM: dts: imx6dl-yapp4: Add reg property to the lp5562 " Dan Murphy
2020-04-02 20:43 ` [PATCH v19 11/18] ARM: dts: ste-href: Add reg property to the LP5521 channel nodes Dan Murphy
2020-04-02 20:43 ` [PATCH v19 12/18] leds: lp55xx: Convert LED class registration to devm_* Dan Murphy
2020-04-02 20:43 ` [PATCH v19 13/18] leds: lp55xx: Add multicolor framework support to lp55xx Dan Murphy
2020-04-02 20:43 ` [PATCH v19 14/18] leds: lp5523: Update the lp5523 code to add multicolor brightness function Dan Murphy
2020-04-02 20:43 ` [PATCH v19 15/18] leds: lp5521: Add multicolor framework multicolor brightness support Dan Murphy
2020-04-02 20:43 ` [PATCH v19 16/18] leds: lp55xx: Fix checkpatch file permissions issues Dan Murphy
2020-04-02 20:43 ` [PATCH v19 17/18] leds: lp5523: Fix checkpatch issues in the code Dan Murphy
2020-04-02 20:43 ` [PATCH v19 18/18] dt: bindings: Update lp55xx binding to recommended LED naming Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b27b21bf-9a7a-8233-d033-17bae43b297d@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=dmurphy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).