linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: linux-mips@linux-mips.org, "Arnd Bergmann" <arnd@arndb.de>,
	"Felix Fietkau" <nbd@nbd.name>,
	"Hauke Mehrtens" <hauke@hauke-m.de>,
	"James Hogan" <james.hogan@imgtec.com>,
	"John Crispin" <john@phrozen.org>,
	"Ralf Bächle" <ralf@linux-mips.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	kernel-janitors@vger.kernel.org, Pan Bian <bianpan2016@163.com>
Subject: MIPS: Lantiq: Completion of error handling around clkdev_add_clkout()
Date: Sun, 30 Apr 2017 16:20:33 +0200	[thread overview]
Message-ID: <b27c5b95-747b-e83a-84e8-01fd7a1ae04e@users.sourceforge.net> (raw)

Hello,

I have noticed by execution of another script for the semantic patch language
(Coccinelle software) that the function “clkdev_add_clkout” does not contain
null pointer checks after calls of the function “kzalloc”.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/mips/lantiq/xway/sysctrl.c?h=v4.10#n403

How do you think about to add corresponding checks and adjust the function
return type there?

Regards,
Markus

                 reply	other threads:[~2017-04-30 14:21 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b27c5b95-747b-e83a-84e8-01fd7a1ae04e@users.sourceforge.net \
    --to=elfring@users.sourceforge.net \
    --cc=arnd@arndb.de \
    --cc=bianpan2016@163.com \
    --cc=hauke@hauke-m.de \
    --cc=james.hogan@imgtec.com \
    --cc=john@phrozen.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=nbd@nbd.name \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).