From: Tengfei Fan <quic_tengfan@quicinc.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
<andersson@kernel.org>, <konrad.dybcio@linaro.org>,
<robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
<conor+dt@kernel.org>, <dmitry.baryshkov@linaro.org>
Cc: <linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <kernel@quicinc.com>,
Qiang Yu <quic_qianyu@quicinc.com>,
Ziyue Zhang <quic_ziyuzhan@quicinc.com>
Subject: Re: [PATCH v4 6/6] arm64: dts: qcom: aim300: add AIM300 AIoT
Date: Thu, 1 Feb 2024 19:49:46 +0800 [thread overview]
Message-ID: <b28904a6-c1ef-44b5-96ca-313a9a2a3f8b@quicinc.com> (raw)
In-Reply-To: <c17dafd2-db89-4fe2-8e98-2a031f7237c2@quicinc.com>
On 1/30/2024 3:25 PM, Tengfei Fan wrote:
>
>
> On 1/29/2024 4:18 PM, Tengfei Fan wrote:
>>
>>
>> On 1/29/2024 4:09 PM, Krzysztof Kozlowski wrote:
>>> On 19/01/2024 11:06, Tengfei Fan wrote:
>>>> Add AIM300 AIoT board DTS support, including usb, serial, PCIe, mpss,
>>>> adsp, cdsp and sound card functions support.
>>>>
>>>
>>> ...
>>>
>>>> +
>>>> + sound {
>>>> + compatible = "qcom,sm8550-sndcard", "qcom,sm8450-sndcard";
>>>> + model = "AIM300-AIOT";
>>>> + audio-routing = "SpkrLeft IN", "WSA_SPK1 OUT",
>>>> + "SpkrRight IN", "WSA_SPK2 OUT",
>>>> + "IN1_HPHL", "HPHL_OUT",
>>>> + "IN2_HPHR", "HPHR_OUT",
>>>> + "AMIC2", "MIC BIAS2",
>>>> + "VA DMIC0", "MIC BIAS1",
>>>> + "VA DMIC1", "MIC BIAS1",
>>>> + "VA DMIC2", "MIC BIAS3",
>>>> + "TX DMIC0", "MIC BIAS1",
>>>> + "TX DMIC1", "MIC BIAS2",
>>>> + "TX DMIC2", "MIC BIAS3",
>>>> + "TX SWR_ADC1", "ADC2_OUTPUT";
>>>
>>> This should be probably TX SWR_INPUT1.
>>>
>>> Best regards,
>>> Krzysztof
>>>
>>
>> I will double check this with related team and I will update this.
>>
>
> I will apply "TX SWR_INPUT1" on audio-routing node in the next patch
> series.
>
This patch series has been sent for nearly two weeks. do you think it is
better to modify the patch series acording to the current comments and
submit a new patch series, or continue to wait for your review comments
on the current path series?
--
Thx and BRs,
Tengfei Fan
next prev parent reply other threads:[~2024-02-01 11:50 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-19 10:06 [PATCH v4 0/6] arm64: qcom: add AIM300 AIoT board support Tengfei Fan
2024-01-19 10:06 ` [PATCH v4 1/6] dt-bindings: arm: qcom: Document QCM8550, QCS8550 SoC and board Tengfei Fan
2024-02-02 14:34 ` Krzysztof Kozlowski
2024-02-04 6:02 ` Tengfei Fan
2024-02-04 16:25 ` Dmitry Baryshkov
2024-02-05 8:02 ` Krzysztof Kozlowski
2024-02-04 16:29 ` Dmitry Baryshkov
2024-02-05 10:20 ` Tengfei Fan
2024-02-05 10:44 ` Krzysztof Kozlowski
2024-02-05 13:48 ` Dmitry Baryshkov
2024-02-20 9:09 ` Aiqun Yu (Maria)
2024-02-20 9:15 ` Dmitry Baryshkov
2024-02-28 2:03 ` Aiqun Yu (Maria)
2024-02-05 8:03 ` Krzysztof Kozlowski
2024-02-05 9:15 ` Tengfei Fan
2024-01-19 10:06 ` [PATCH v4 2/6] dt-bindings: arm: qcom,ids: add SoC ID for QCM8550 and QCS8550 Tengfei Fan
2024-01-19 10:06 ` [PATCH v4 3/6] soc: qcom: socinfo: add SoC Info support for QCM8550 and QCS8550 platform Tengfei Fan
2024-02-05 8:04 ` Krzysztof Kozlowski
2024-02-05 10:10 ` Tengfei Fan
2024-02-05 10:45 ` Krzysztof Kozlowski
2024-01-19 10:06 ` [PATCH v4 4/6] arm64: dts: qcom: qcm8550: introduce qcm8550 dtsi Tengfei Fan
2024-01-19 10:06 ` [PATCH v4 5/6] arm64: dts: qcom: add base AIM300 dtsi Tengfei Fan
2024-01-19 10:06 ` [PATCH v4 6/6] arm64: dts: qcom: aim300: add AIM300 AIoT Tengfei Fan
2024-01-29 8:09 ` Krzysztof Kozlowski
2024-01-29 8:18 ` Tengfei Fan
2024-01-30 7:25 ` Tengfei Fan
2024-02-01 11:49 ` Tengfei Fan [this message]
2024-02-01 12:03 ` Krzysztof Kozlowski
2024-02-01 12:16 ` Tengfei Fan
2024-02-01 12:20 ` Krzysztof Kozlowski
2024-02-01 12:27 ` Tengfei Fan
2024-01-28 17:45 ` (subset) [PATCH v4 0/6] arm64: qcom: add AIM300 AIoT board support Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b28904a6-c1ef-44b5-96ca-313a9a2a3f8b@quicinc.com \
--to=quic_tengfan@quicinc.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=kernel@quicinc.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_qianyu@quicinc.com \
--cc=quic_ziyuzhan@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).