From: Guillaume Tucker <guillaume.tucker@collabora.com>
To: Russell King <linux@armlinux.org.uk>,
Kukjin Kim <kgene@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@collabora.com
Subject: [PATCH] ARM: exynos: update l2c_aux_mask to fix alert message
Date: Wed, 1 Apr 2020 17:08:03 +0100 [thread overview]
Message-ID: <b29f34870380093e6268c11d3033033d6def61b7.1585756648.git.guillaume.tucker@collabora.com> (raw)
Allow setting the number of cycles for RAM reads in the pl310 cache
controller L2 auxiliary control register mask (bits 0-2) since it
needs to be changed in software. This only affects exynos4210 and
exynos4412 as they use the pl310 cache controller.
With the mask used until now, the following warnings were generated,
the 2nd one being a pr_alert():
L2C: platform modifies aux control register: 0x02070000 -> 0x3e470001
L2C: platform provided aux values permit register corruption.
This latency cycles value has always been set in software in spite of
the warnings. Keep it this way but clear the alert message about
register corruption to acknowledge it is a valid thing to do.
Tested on exynos4412-odroid-x2.
Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
Reported-by: "kernelci.org bot" <bot@kernelci.org>
---
arch/arm/mach-exynos/exynos.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c
index 7a8d1555db40..ed1bba49210d 100644
--- a/arch/arm/mach-exynos/exynos.c
+++ b/arch/arm/mach-exynos/exynos.c
@@ -194,7 +194,7 @@ static void __init exynos_dt_fixup(void)
DT_MACHINE_START(EXYNOS_DT, "Samsung Exynos (Flattened Device Tree)")
.l2c_aux_val = 0x3c400001,
- .l2c_aux_mask = 0xc20fffff,
+ .l2c_aux_mask = 0xc20ffff8,
.smp = smp_ops(exynos_smp_ops),
.map_io = exynos_init_io,
.init_early = exynos_firmware_init,
--
2.20.1
next reply other threads:[~2020-04-01 16:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-01 16:08 Guillaume Tucker [this message]
2020-04-01 16:31 ` [PATCH] ARM: exynos: update l2c_aux_mask to fix alert message Russell King - ARM Linux admin
2020-04-02 12:13 ` Guillaume Tucker
2020-04-02 13:03 ` Russell King - ARM Linux admin
2020-04-02 13:11 ` Russell King - ARM Linux admin
2020-06-12 14:23 ` Guillaume Tucker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b29f34870380093e6268c11d3033033d6def61b7.1585756648.git.guillaume.tucker@collabora.com \
--to=guillaume.tucker@collabora.com \
--cc=kernel@collabora.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).