From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 749EEC4346E for ; Tue, 29 Sep 2020 07:55:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3239E2076A for ; Tue, 29 Sep 2020 07:55:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726944AbgI2HzF (ORCPT ); Tue, 29 Sep 2020 03:55:05 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:57664 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725765AbgI2HzF (ORCPT ); Tue, 29 Sep 2020 03:55:05 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: eballetbo) with ESMTPSA id B4E5129A913 Subject: Re: [PATCH] platform_data: ti: fix a typo To: Wang Qing , Benson Leung , Guenter Roeck , Mark Brown , Tzung-Bi Shih , Pi-Hsun Shih , Prashant Malani , linux-kernel@vger.kernel.org References: <1601088620-16070-1-git-send-email-wangqing@vivo.com> From: Enric Balletbo i Serra Message-ID: Date: Tue, 29 Sep 2020 09:54:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <1601088620-16070-1-git-send-email-wangqing@vivo.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Wang Qing, Thank you for your patch. On 26/9/20 4:49, Wang Qing wrote: > Modify the typo: "compliment" -> "complement". > > Signed-off-by: Wang Qing > --- > include/linux/platform_data/cros_ec_commands.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/include/linux/platform_data/cros_ec_commands.h b/include/linux/platform_data/cros_ec_commands.h > index 1fcfe9e..42203ce > --- a/include/linux/platform_data/cros_ec_commands.h > +++ b/include/linux/platform_data/cros_ec_commands.h > @@ -261,12 +261,12 @@ > /* Memory space version; set to EC_ACPI_MEM_VERSION_CURRENT */ > #define EC_ACPI_MEM_VERSION 0x00 > /* > - * Test location; writing value here updates test compliment byte to (0xff - > + * Test location; writing value here updates test complement byte to (0xff - > * value). > */ > #define EC_ACPI_MEM_TEST 0x01 > -/* Test compliment; writes here are ignored. */ > -#define EC_ACPI_MEM_TEST_COMPLIMENT 0x02 > +/* Test complement; writes here are ignored. */ > +#define EC_ACPI_MEM_TEST_COMPLEMENT 0x02 > Although there is a typo, we did an effort to have cros_ec_command synced with ec commands in the firmware code, so I'd like to see this change also applied on the EC code. Do you mind to populate this change in the EC firmware code [1], please [1] https://chromium.googlesource.com/chromiumos/platform/ec/+/refs/heads/master Thanks, Enric > /* Keyboard backlight brightness percent (0 - 100) */ > #define EC_ACPI_MEM_KEYBOARD_BACKLIGHT 0x03 >