From: Alex Elder <elder@linaro.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, evgreen@chromium.org,
bjorn.andersson@linaro.org, cpratapa@codeaurora.org,
subashab@codeaurora.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 7/7] net: ipa: allow arbitrary number of interconnects
Date: Mon, 18 Jan 2021 14:27:20 -0600 [thread overview]
Message-ID: <b2c4b28b-bd13-b058-ddf7-737b12641806@linaro.org> (raw)
In-Reply-To: <20210118115816.149d71f6@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On 1/18/21 1:58 PM, Jakub Kicinski wrote:
> But it does sound a little too much like aligning with the vendor
> driver for the sake of aligning with the vendor driver. This makes
> the review for someone not familiar with the vendor driver hard,
> and raises questions like "is this really needed upstream or just
> downstream / out-of-tree". Please try to reorient the work towards
> implementing particular pieces of functionality upstream start to end.
I have lots of this kind of preparatory work "ready to go" and I'm
eager to get it upstream. But I'll try to be more patient and wait
to send things out until something justifies the need, rather than
just doing it in support of a longer-term goal.
I would not consider what I'm doing "aligning with the vendor
driver," but maybe I misunderstand your meaning. The upstream
driver is very different from Qualcomm's driver. I'm basically
writing all new code now, using the Qualcomm code for reference.
Thank you very much for applying the patches.
-Alex
prev parent reply other threads:[~2021-01-18 20:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-15 12:50 [PATCH net-next 0/7] net: ipa: interconnect improvements Alex Elder
2021-01-15 12:50 ` [PATCH net-next 1/7] net: ipa: rename interconnect settings Alex Elder
2021-01-15 12:50 ` [PATCH net-next 2/7] net: ipa: don't return an error from ipa_interconnect_disable() Alex Elder
2021-01-15 12:50 ` [PATCH net-next 3/7] net: ipa: introduce an IPA interconnect structure Alex Elder
2021-01-15 12:50 ` [PATCH net-next 4/7] net: ipa: store average and peak interconnect bandwidth Alex Elder
2021-01-15 12:50 ` [PATCH net-next 5/7] net: ipa: add interconnect name to configuration data Alex Elder
2021-01-15 12:50 ` [PATCH net-next 6/7] net: ipa: clean up interconnect initialization Alex Elder
2021-01-15 12:50 ` [PATCH net-next 7/7] net: ipa: allow arbitrary number of interconnects Alex Elder
2021-01-17 3:12 ` Jakub Kicinski
2021-01-17 16:03 ` Alex Elder
2021-01-18 19:58 ` Jakub Kicinski
2021-01-18 20:27 ` Alex Elder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2c4b28b-bd13-b058-ddf7-737b12641806@linaro.org \
--to=elder@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=cpratapa@codeaurora.org \
--cc=davem@davemloft.net \
--cc=evgreen@chromium.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=subashab@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).