From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753159AbcHLSk0 (ORCPT ); Fri, 12 Aug 2016 14:40:26 -0400 Received: from relay1.mentorg.com ([192.94.38.131]:33265 "EHLO relay1.mentorg.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753134AbcHLSkX (ORCPT ); Fri, 12 Aug 2016 14:40:23 -0400 Subject: Re: [PATCH v3] ARM: VDSO: put RO and RO after init objects into proper sections To: Kees Cook References: <1470989538-2953-1-git-send-email-jszhang@marvell.com> CC: Jisheng Zhang , Russell King , Arnd Bergmann , "linux-arm-kernel@lists.infradead.org" , LKML From: Nathan Lynch Message-ID: Date: Fri, 12 Aug 2016 13:40:18 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/12/2016 01:06 PM, Kees Cook wrote: > On Fri, Aug 12, 2016 at 1:12 AM, Jisheng Zhang wrote: >> vdso_data_mapping is never modified, so mark it as const. >> >> vdso_total_pages, vdso_data_page, vdso_text_mapping and cntvct_ok are >> initialized by vdso_init(), thereafter are read only. >> >> The fact that they are read only after init makes them candidates for >> __ro_after_init declarations. >> >> Signed-off-by: Jisheng Zhang > > Looks great; thanks for keeping __ro_after_init in mind. :) > > Reviewed-by: Kees Cook Looks fine and nothing goes wrong with my vdso tests. Please send it through Russell. Acked-by: Nathan Lynch