From: Joe Perches <joe@perches.com>
To: Robert Richter <rric@kernel.org>
Cc: Len Baker <len.baker@gmx.com>, Borislav Petkov <bp@alien8.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Tony Luck <tony.luck@intel.com>,
James Morse <james.morse@arm.com>,
Kees Cook <keescook@chromium.org>,
linux-hardening@vger.kernel.org, linux-edac@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] drivers/edac/edac_mc: Remove all strcpy() uses
Date: Tue, 10 Aug 2021 08:02:17 -0700 [thread overview]
Message-ID: <b3070c0352e2a5661a1a59d5c5354cc82a1cce1e.camel@perches.com> (raw)
In-Reply-To: <YRKO4An9UkObVGmB@rric.localdomain>
On Tue, 2021-08-10 at 16:36 +0200, Robert Richter wrote:
> On 09.08.21 10:18:58, Joe Perches wrote:
>
> > strscpy and scnprintf have different return values and it's simpler
> > and much more common to use scnprintf for appended strings that are
> > limited to a specific buffer length.
>
> Calculating the bytes written from the return value is a oneliner.
Not really.
You still have to test for strscpy's possible return of -E2BIG.
next prev parent reply other threads:[~2021-08-10 15:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-07 15:59 [PATCH v3] drivers/edac/edac_mc: Remove all strcpy() uses Len Baker
2021-08-07 17:09 ` Joe Perches
2021-08-08 11:26 ` Len Baker
2021-08-09 10:05 ` Robert Richter
2021-08-09 17:18 ` Joe Perches
2021-08-10 8:56 ` David Laight
2021-08-10 14:36 ` Robert Richter
2021-08-10 15:02 ` Joe Perches [this message]
2021-08-11 7:40 ` Robert Richter
2021-08-09 9:51 ` Robert Richter
2021-08-09 16:25 ` Len Baker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3070c0352e2a5661a1a59d5c5354cc82a1cce1e.camel@perches.com \
--to=joe@perches.com \
--cc=bp@alien8.de \
--cc=james.morse@arm.com \
--cc=keescook@chromium.org \
--cc=len.baker@gmx.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rric@kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).