From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Jan Beulich <jbeulich@suse.com>, Juergen Gross <jgross@suse.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
the arch/x86 maintainers <x86@kernel.org>,
Andy Lutomirski <luto@kernel.org>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: Ping: [PATCH 0/2] x86/Xen/32: xen_iret_crit_fixup adjustments
Date: Tue, 19 Nov 2019 21:39:21 -0500 [thread overview]
Message-ID: <b308b5ab-7b25-414a-6153-8c4f70b1c6a1@oracle.com> (raw)
In-Reply-To: <6d70b8e0-7acd-d8ea-fa41-6866ae1ffef9@oracle.com>
On 11/19/19 9:17 PM, Boris Ostrovsky wrote:
> On 11/19/19 12:50 PM, Boris Ostrovsky wrote:
>> On 11/19/19 7:58 AM, Jan Beulich wrote:
>>> On 11.11.2019 15:30, Jan Beulich wrote:
>>>> The first patch here fixes another regression from 3c88c692c287
>>>> ("x86/stackframe/32: Provide consistent pt_regs"), besides the
>>>> one already addressed by
>>>> https://lists.xenproject.org/archives/html/xen-devel/2019-10/msg01988.html.
>>>> The second patch is a minimal bit of cleanup on top.
>>>>
>>>> 1: make xen_iret_crit_fixup independent of frame layout
>>>> 2: simplify xen_iret_crit_fixup's ring check
>>> Seeing that the other regression fix has been taken into -tip,
>>> what is the situation here? Should 5.4 really ship with this
>>> still unfixed?
>> I am still unable to boot a 32-bit guest with those patches, crashing in
>> int3_exception_notify with regs->sp zero.
>>
>> When I revert to 3c88c692c287 the guest actually boots so my (?) problem
>> was introduced somewhere in-between.
> Nevermind this. I didn't read your patches correctly.
BTW, I'd rather this not go into 5.4 this late. 3c88c692c287 has been
there since 5.2 and noone complained.
-boris
next prev parent reply other threads:[~2019-11-20 2:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 14:30 [PATCH 0/2] x86/Xen/32: xen_iret_crit_fixup adjustments Jan Beulich
2019-11-11 14:32 ` [PATCH 1/2] x86/Xen/32: make xen_iret_crit_fixup independent of frame layout Jan Beulich
2019-11-19 13:17 ` Jürgen Groß
2019-11-19 21:01 ` [tip: x86/urgent] x86/xen/32: Make xen_iret_crit_fixup() " tip-bot2 for Jan Beulich
2019-11-11 14:32 ` [PATCH 2/2] x86/Xen/32: simplify xen_iret_crit_fixup's ring check Jan Beulich
2019-11-19 13:18 ` Jürgen Groß
2019-11-19 21:01 ` [tip: x86/urgent] x86/xen/32: Simplify ring check in xen_iret_crit_fixup() tip-bot2 for Jan Beulich
2019-11-19 12:58 ` Ping: [PATCH 0/2] x86/Xen/32: xen_iret_crit_fixup adjustments Jan Beulich
2019-11-19 17:50 ` Boris Ostrovsky
2019-11-20 2:17 ` Boris Ostrovsky
2019-11-20 2:39 ` Boris Ostrovsky [this message]
2019-11-20 7:18 ` [Xen-devel] " Jan Beulich
2019-11-20 7:13 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b308b5ab-7b25-414a-6153-8c4f70b1c6a1@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=jbeulich@suse.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).