From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754223AbdKFSDA (ORCPT ); Mon, 6 Nov 2017 13:03:00 -0500 Received: from smtprelay0252.hostedemail.com ([216.40.44.252]:47404 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753552AbdKFSC7 (ORCPT ); Mon, 6 Nov 2017 13:02:59 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::,RULES_HIT:41:355:379:541:800:960:973:988:989:1260:1345:1437:1534:1541:1711:1730:1747:1777:1792:2393:2559:2562:3138:3139:3140:3141:3142:3352:3876:3877:5007:6114:6119:6261:6642:9592:10004:10848:11026:11658:11914:12043:12296:12438:12555:12895:13069:13311:13357:14181:14384:14394:14721:21080:21627:30054:30056,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:3,LUA_SUMMARY:none X-HE-Tag: thumb03_37069f2316b59 X-Filterd-Recvd-Size: 1703 From: Joe Perches To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org Subject: [PATCH] mm/page_alloc: Avoid KERN_CONT uses in warn_alloc Date: Mon, 6 Nov 2017 10:02:56 -0800 Message-Id: X-Mailer: git-send-email 2.15.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org KERN_CONT/pr_cont uses should be avoided where possible. Use single pr_warn calls instead. Signed-off-by: Joe Perches --- mm/page_alloc.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 536431bf0f0c..82e6d2c914ab 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -3275,19 +3275,17 @@ void warn_alloc(gfp_t gfp_mask, nodemask_t *nodemask, const char *fmt, ...) if ((gfp_mask & __GFP_NOWARN) || !__ratelimit(&nopage_rs)) return; - pr_warn("%s: ", current->comm); - va_start(args, fmt); vaf.fmt = fmt; vaf.va = &args; - pr_cont("%pV", &vaf); - va_end(args); - - pr_cont(", mode:%#x(%pGg), nodemask=", gfp_mask, &gfp_mask); if (nodemask) - pr_cont("%*pbl\n", nodemask_pr_args(nodemask)); + pr_warn("%s: %pV, mode:%#x(%pGg), nodemask=%*pbl\n", + current->comm, &vaf, gfp_mask, &gfp_mask, + nodemask_pr_args(nodemask)); else - pr_cont("(null)\n"); + pr_warn("%s: %pV, mode:%#x(%pGg), nodemask=(null)\n", + current->comm, &vaf, gfp_mask, &gfp_mask); + va_end(args); cpuset_print_current_mems_allowed(); -- 2.15.0