From: Auger Eric <eric.auger@redhat.com>
To: Kirti Wankhede <kwankhede@nvidia.com>,
alex.williamson@redhat.com, pbonzini@redhat.com,
kraxel@redhat.com, cjia@nvidia.com
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, kevin.tian@intel.com,
jike.song@intel.com, bjsdjshi@linux.vnet.ibm.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v14 08/22] vfio iommu type1: Add find_iommu_group() function
Date: Mon, 21 Nov 2016 12:29:41 +0100 [thread overview]
Message-ID: <b31392c8-b5e2-c0ff-3fbe-4fcf26838874@redhat.com> (raw)
In-Reply-To: <1479329194-10247-9-git-send-email-kwankhede@nvidia.com>
Hi,
On 16/11/2016 21:46, Kirti Wankhede wrote:
> Add find_iommu_group()
>
> Signed-off-by: Kirti Wankhede <kwankhede@nvidia.com>
> Signed-off-by: Neo Jia <cjia@nvidia.com>
> Reviewed-by: Jike Song <jike.song@intel.com>
> Reviewed-by: Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com>
>
> Change-Id: I9d372f1ebe9eb01a5a21374b8a2b03f7df73601f
> ---
> drivers/vfio/vfio_iommu_type1.c | 57 ++++++++++++++++++++++++-----------------
> 1 file changed, 33 insertions(+), 24 deletions(-)
>
> diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type1.c
> index 52af5fc01d91..ffe2026f1341 100644
> --- a/drivers/vfio/vfio_iommu_type1.c
> +++ b/drivers/vfio/vfio_iommu_type1.c
> @@ -752,11 +752,24 @@ static void vfio_test_domain_fgsp(struct vfio_domain *domain)
> __free_pages(pages, order);
> }
>
> +static struct vfio_group *find_iommu_group(struct vfio_domain *domain,
> + struct iommu_group *iommu_group)
> +{
> + struct vfio_group *g;
> +
> + list_for_each_entry(g, &domain->group_list, next) {
> + if (g->iommu_group == iommu_group)
> + return g;
> + }
> +
> + return NULL;
> +}
> +
> static int vfio_iommu_type1_attach_group(void *iommu_data,
> struct iommu_group *iommu_group)
> {
> struct vfio_iommu *iommu = iommu_data;
> - struct vfio_group *group, *g;
> + struct vfio_group *group;
> struct vfio_domain *domain, *d;
> struct bus_type *bus = NULL;
> int ret;
> @@ -764,10 +777,7 @@ static int vfio_iommu_type1_attach_group(void *iommu_data,
> mutex_lock(&iommu->lock);
>
> list_for_each_entry(d, &iommu->domain_list, next) {
> - list_for_each_entry(g, &d->group_list, next) {
> - if (g->iommu_group != iommu_group)
> - continue;
> -
> + if (find_iommu_group(d, iommu_group)) {
> mutex_unlock(&iommu->lock);
> return -EINVAL;
> }
> @@ -887,27 +897,26 @@ static void vfio_iommu_type1_detach_group(void *iommu_data,
> mutex_lock(&iommu->lock);
>
> list_for_each_entry(domain, &iommu->domain_list, next) {
> - list_for_each_entry(group, &domain->group_list, next) {
> - if (group->iommu_group != iommu_group)
> - continue;
> + group = find_iommu_group(domain, iommu_group);
> + if (!group)
> + continue;
>
> - iommu_detach_group(domain->domain, iommu_group);
> - list_del(&group->next);
> - kfree(group);
> - /*
> - * Group ownership provides privilege, if the group
> - * list is empty, the domain goes away. If it's the
> - * last domain, then all the mappings go away too.
> - */
> - if (list_empty(&domain->group_list)) {
> - if (list_is_singular(&iommu->domain_list))
> - vfio_iommu_unmap_unpin_all(iommu);
> - iommu_domain_free(domain->domain);
> - list_del(&domain->next);
> - kfree(domain);
> - }
> - goto done;
> + iommu_detach_group(domain->domain, iommu_group);
> + list_del(&group->next);
> + kfree(group);
> + /*
> + * Group ownership provides privilege, if the group
> + * list is empty, the domain goes away. If it's the
> + * last domain, then all the mappings go away too.
> + */
> + if (list_empty(&domain->group_list)) {
> + if (list_is_singular(&iommu->domain_list))
> + vfio_iommu_unmap_unpin_all(iommu);
> + iommu_domain_free(domain->domain);
> + list_del(&domain->next);
> + kfree(domain);
> }
> + goto done;
> }
>
> done:
>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Eric
next prev parent reply other threads:[~2016-11-21 11:29 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-16 20:46 [PATCH v14 00/22] Add Mediated device support Kirti Wankhede
2016-11-16 20:46 ` [PATCH v14 01/22] vfio: Mediated device Core driver Kirti Wankhede
2016-11-16 20:46 ` [PATCH v14 02/22] vfio: VFIO based driver for Mediated devices Kirti Wankhede
2016-11-16 20:46 ` [PATCH v14 03/22] vfio: Rearrange functions to get vfio_group from dev Kirti Wankhede
2016-11-16 20:46 ` [PATCH v14 04/22] vfio: Common function to increment container_users Kirti Wankhede
2016-11-16 20:46 ` [PATCH v14 05/22] vfio iommu: Added pin and unpin callback functions to vfio_iommu_driver_ops Kirti Wankhede
2016-11-16 20:46 ` [PATCH v14 06/22] vfio iommu type1: Update arguments of vfio_lock_acct Kirti Wankhede
2016-11-16 20:46 ` [PATCH v14 07/22] vfio iommu type1: Update argument of vaddr_get_pfn() Kirti Wankhede
2016-11-16 20:46 ` [PATCH v14 08/22] vfio iommu type1: Add find_iommu_group() function Kirti Wankhede
2016-11-21 11:29 ` Auger Eric [this message]
2016-11-21 11:55 ` Kirti Wankhede
2016-11-21 12:42 ` Auger Eric
2016-11-16 20:46 ` [PATCH v14 09/22] vfio iommu type1: Add task structure to vfio_dma Kirti Wankhede
2016-11-17 5:41 ` Alexey Kardashevskiy
2016-11-17 6:12 ` Alex Williamson
2016-11-17 6:42 ` Alexey Kardashevskiy
2016-11-17 6:23 ` Kirti Wankhede
2016-11-16 20:46 ` [PATCH v14 10/22] vfio iommu type1: Add support for mediated devices Kirti Wankhede
2016-11-16 23:57 ` Alex Williamson
2016-11-17 4:49 ` Kirti Wankhede
2016-11-17 4:52 ` Kirti Wankhede
2016-11-16 20:46 ` [PATCH v14 11/22] vfio iommu: Add blocking notifier to notify DMA_UNMAP Kirti Wankhede
2016-11-17 0:02 ` Alex Williamson
2016-11-17 2:53 ` Jike Song
2016-11-17 4:58 ` Kirti Wankhede
2016-11-16 20:46 ` [PATCH v14 12/22] vfio: Add notifier callback to parent's ops structure of mdev Kirti Wankhede
2016-11-17 5:04 ` Kirti Wankhede
[not found] ` <20161117021533.GD6620@bjsdjshi@linux.vnet.ibm.com>
2016-11-17 5:05 ` Kirti Wankhede
2016-11-17 12:35 ` Jike Song
2016-11-17 15:27 ` Alex Williamson
2016-11-17 16:00 ` Kirti Wankhede
2016-11-17 16:14 ` Alex Williamson
2016-11-16 20:46 ` [PATCH v14 13/22] vfio: Introduce common function to add capabilities Kirti Wankhede
2016-11-21 11:04 ` [Qemu-devel] " Auger Eric
2016-11-16 20:46 ` [PATCH v14 14/22] vfio_pci: Update vfio_pci to use vfio_info_add_capability() Kirti Wankhede
2016-11-21 11:04 ` Auger Eric
2016-11-16 20:46 ` [PATCH v14 15/22] vfio: Introduce vfio_set_irqs_validate_and_prepare() Kirti Wankhede
2016-11-21 10:51 ` Auger Eric
2016-11-16 20:46 ` [PATCH v14 16/22] vfio_pci: Updated to use vfio_set_irqs_validate_and_prepare() Kirti Wankhede
2016-11-21 10:51 ` Auger Eric
2016-11-16 20:46 ` [PATCH v14 17/22] vfio_platform: " Kirti Wankhede
2016-11-21 10:51 ` Auger Eric
2016-11-16 20:46 ` [PATCH v14 18/22] vfio: Define device_api strings Kirti Wankhede
2016-11-16 20:46 ` [PATCH v14 19/22] docs: Add Documentation for Mediated devices Kirti Wankhede
2016-11-16 20:46 ` [PATCH v14 20/22] docs: Sysfs ABI for mediated device framework Kirti Wankhede
2016-11-16 20:46 ` [PATCH v14 21/22] docs: Sample driver to demonstrate how to use Mediated " Kirti Wankhede
2016-11-16 20:46 ` [PATCH v14 22/22] MAINTAINERS: Add entry VFIO based Mediated device drivers Kirti Wankhede
2016-11-17 21:25 ` [PATCH v14 00/22] Add Mediated device support Alex Williamson
2016-11-17 22:05 ` Neo Jia
2016-11-18 2:00 ` Kirti Wankhede
2016-11-18 2:26 ` [Qemu-devel] " Jike Song
2016-11-17 23:29 ` Tian, Kevin
2016-11-17 23:51 ` Alex Williamson
2016-11-18 9:16 ` Zhenyu Wang
2016-11-18 15:40 ` Alex Williamson
2016-11-18 16:09 ` Daniel Vetter
2016-11-18 16:50 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b31392c8-b5e2-c0ff-3fbe-4fcf26838874@redhat.com \
--to=eric.auger@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=bjsdjshi@linux.vnet.ibm.com \
--cc=cjia@nvidia.com \
--cc=jike.song@intel.com \
--cc=kevin.tian@intel.com \
--cc=kraxel@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).