From: Stefan Agner <stefan@agner.ch>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: tglx@linutronix.de, jason@lakedaemon.net,
linux-kernel@vger.kernel.org,
linux-arm-kernel-bounces@lists.infradead.org
Subject: Re: [PATCH] irqchip/gic-v3: use __init where appropriate
Date: Thu, 03 Jan 2019 14:22:37 +0100 [thread overview]
Message-ID: <b31642dbb148d999acf8744e7da1f65b@agner.ch> (raw)
In-Reply-To: <5c4d154b-037d-25a0-7dad-7d2c80a252f9@arm.com>
On 03.01.2019 12:08, Marc Zyngier wrote:
> Hi Stephan,
>
> On 29/12/2018 14:14, Stefan Agner wrote:
>> Compiling with section mismatch debugging enabled prints the
>> following warning:
>> WARNING: vmlinux.o(.text+0xffa1b8): Section mismatch in reference from
>> the function gic_smp_init() to the function .init.text:set_smp_cross_call()
>>
>> Avoid this warning by adding __init to gic_smp_init(). While add it,
>> also add it where appropriate.
>>
>> Signed-off-by: Stefan Agner <stefan@agner.ch>
>> ---
>> drivers/irqchip/irq-gic-v3.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c
>> index 0868a9d81c3c..3b33c94041e5 100644
>> --- a/drivers/irqchip/irq-gic-v3.c
>> +++ b/drivers/irqchip/irq-gic-v3.c
>> @@ -768,7 +768,7 @@ static void gic_raise_softirq(const struct cpumask *mask, unsigned int irq)
>> isb();
>> }
>>
>> -static void gic_smp_init(void)
>> +static void __init gic_smp_init(void)
>> {
>> set_smp_cross_call(gic_raise_softirq);
>> cpuhp_setup_state_nocalls(CPUHP_AP_IRQ_GIC_STARTING,
>> @@ -848,7 +848,7 @@ static struct notifier_block gic_cpu_pm_notifier_block = {
>> .notifier_call = gic_cpu_pm_notifier,
>> };
>>
>> -static void gic_cpu_pm_init(void)
>> +static void __init gic_cpu_pm_init(void)
>> {
>> cpu_pm_register_notifier(&gic_cpu_pm_notifier_block);
>> }
>>
>
> Interesting. I don't see this warning at all. How do you trigger this?
I noticed that it suddenly disappeared again too. I used some crazy
configurations while doing tests with LLVM/Clang, I think it was with
allyesconfig.
--
Stefan
>
> Thanks,
>
> M.
prev parent reply other threads:[~2019-01-03 13:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-29 14:14 [PATCH] irqchip/gic-v3: use __init where appropriate Stefan Agner
2019-01-03 11:08 ` Marc Zyngier
2019-01-03 13:22 ` Stefan Agner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b31642dbb148d999acf8744e7da1f65b@agner.ch \
--to=stefan@agner.ch \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel-bounces@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).