From: John Garry <john.garry@huawei.com>
To: Lu Baolu <baolu.lu@linux.intel.com>, <joro@8bytes.org>,
<will@kernel.org>
Cc: <iommu@lists.linux-foundation.org>, <robin.murphy@arm.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 6/6] iommu: Delete iommu_dev_has_feature()
Date: Thu, 7 Jan 2021 09:13:50 +0000 [thread overview]
Message-ID: <b31e8a41-3918-6b69-05af-45084e08bb7f@huawei.com> (raw)
In-Reply-To: <f05ee600-705a-0c94-2a12-78eb8538234b@linux.intel.com>
On 07/01/2021 01:18, Lu Baolu wrote:
> On 1/6/21 9:35 PM, John Garry wrote:
>> Function iommu_dev_has_feature() has never been referenced in the tree,
>> and there does not appear to be anything coming soon to use it, so delete
>> it.
>
Hi baolu,
> It will be used by the device driver which want to support the aux-
> domain capability, for example, below series is under discussion.
>
> https://lore.kernel.org/linux-pci/160408357912.912050.17005584526266191420.stgit@djiang5-desk3.ch.intel.com/
>
So I did check linux-iommu lore for recent references, above, but did
not see this one - that really should have cc'ed linux-iommu list (which
it didn't).
>
> The typical use case is
>
> if (iommu_dev_has_feature(dev, IOMMU_DEV_FEAT_AUX)) {
> rc = iommu_dev_enable_feature(dev, IOMMU_DEV_FEAT_AUX);
> if (rc < 0) {
> dev_warn(dev, "Failed to enable aux-domain:
> %d\n", rc);
> return rc;
> }
> }
>
> So please don't remove it.
>
ok, fine. It also seems that this API has not had a user since it was
introduced in v5.2.
Thanks,
John
Ps. I suppose a v3 series is not needed ATM - this patch can just be
dropped.
next prev parent reply other threads:[~2021-01-07 9:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-06 13:35 [PATCH v2 0/6] IOMMU: Some more IOVA and core code tidy-up John Garry
2021-01-06 13:35 ` [PATCH v2 1/6] iova: Make has_iova_flush_queue() private John Garry
2021-01-06 13:35 ` [PATCH v2 2/6] iova: Delete copy_reserved_iova() John Garry
2021-01-06 13:35 ` [PATCH v2 3/6] iova: Stop exporting some more functions John Garry
2021-01-06 13:35 ` [PATCH v2 4/6] iommu: Stop exporting iommu_map_sg_atomic() John Garry
2021-01-06 13:35 ` [PATCH v2 5/6] iommu: Delete iommu_domain_window_disable() John Garry
2021-01-06 13:35 ` [PATCH v2 6/6] iommu: Delete iommu_dev_has_feature() John Garry
2021-01-07 1:18 ` Lu Baolu
2021-01-07 9:13 ` John Garry [this message]
2021-01-09 9:09 ` Christoph Hellwig
2021-01-18 11:21 ` [PATCH v2 0/6] IOMMU: Some more IOVA and core code tidy-up Will Deacon
2021-01-27 11:29 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b31e8a41-3918-6b69-05af-45084e08bb7f@huawei.com \
--to=john.garry@huawei.com \
--cc=baolu.lu@linux.intel.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).