linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Saeed Mahameed <saeed@kernel.org>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: leon@kernel.org, davem@davemloft.net, kuba@kernel.org,
	netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] net/mlx5: Fix missing return value in mlx5_devlink_eswitch_inline_mode_set()
Date: Mon, 26 Jul 2021 15:47:13 -0700	[thread overview]
Message-ID: <b323f3f6aac2139d5160b1bffae0c2b839a16b5b.camel@kernel.org> (raw)
In-Reply-To: <1626947897-73558-1-git-send-email-jiapeng.chong@linux.alibaba.com>

On Thu, 2021-07-22 at 17:58 +0800, Jiapeng Chong wrote:
> The return value is missing in this code scenario, add the return
> value
> '0' to the return value 'err'.
> 
> Eliminate the follow smatch warning:
> 
> drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c:3083
> mlx5_devlink_eswitch_inline_mode_set() warn: missing error code
> 'err'.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Fixes: 8e0aa4bc959c ("net/mlx5: E-switch, Protect eswitch mode
> changes")
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> Changes in v2:
>   -For the follow advice:
> https://lore.kernel.org/patchwork/patch/1461601/
> 
>  drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git
> a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c
> b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c
> index 7579f34..6b0b629 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c
> @@ -3079,8 +3079,11 @@ int
> mlx5_devlink_eswitch_inline_mode_set(struct devlink *devlink, u8
> mode,
>  
>         switch (MLX5_CAP_ETH(dev, wqe_inline_mode)) {
>         case MLX5_CAP_INLINE_MODE_NOT_REQUIRED:
> -               if (mode == DEVLINK_ESWITCH_INLINE_MODE_NONE)
> +               if (mode == DEVLINK_ESWITCH_INLINE_MODE_NONE) {
> +                       err = 0;

Although err is already 0 at this point even before this patch,
otherwise the function would've aborted earlier, I will apply this to
net-next-mlx5, since I like the explicit return value here as it shows
the real intention of the code.
but smatch needs to be investigated.

Applied to net-next-mlx5, 
Thanks.

>                         goto out;
> +               }
> +
>                 fallthrough;
>         case MLX5_CAP_INLINE_MODE_L2:
>                 NL_SET_ERR_MSG_MOD(extack, "Inline mode can't be
> set");




      parent reply	other threads:[~2021-07-26 22:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-22  9:58 Jiapeng Chong
2021-07-25 10:10 ` Leon Romanovsky
2021-07-26 22:47 ` Saeed Mahameed [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b323f3f6aac2139d5160b1bffae0c2b839a16b5b.camel@kernel.org \
    --to=saeed@kernel.org \
    --cc=davem@davemloft.net \
    --cc=jiapeng.chong@linux.alibaba.com \
    --cc=kuba@kernel.org \
    --cc=leon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --subject='Re: [PATCH v2] net/mlx5: Fix missing return value in mlx5_devlink_eswitch_inline_mode_set()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).