From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5D3EC1975A for ; Wed, 25 Mar 2020 07:54:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9062C20409 for ; Wed, 25 Mar 2020 07:54:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727290AbgCYHyP (ORCPT ); Wed, 25 Mar 2020 03:54:15 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:56512 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726103AbgCYHyP (ORCPT ); Wed, 25 Mar 2020 03:54:15 -0400 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id DD25C3C7575C8B8A45B8; Wed, 25 Mar 2020 15:54:02 +0800 (CST) Received: from [127.0.0.1] (10.67.102.197) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.487.0; Wed, 25 Mar 2020 15:53:52 +0800 Subject: Re: [PATCH] mtd:Fix issue where write_cached_data() fails but write() still returns success To: Miquel Raynal CC: , , , , , References: <1584674111-101462-1-git-send-email-nixiaoming@huawei.com> <20200324230620.174db1a7@xps13> From: Xiaoming Ni Message-ID: Date: Wed, 25 Mar 2020 15:53:41 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.1.2 MIME-Version: 1.0 In-Reply-To: <20200324230620.174db1a7@xps13> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.102.197] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/3/25 6:06, Miquel Raynal wrote: > Hi Xiaoming, > > Xiaoming Ni wrote on Fri, 20 Mar 2020 11:15:11 > +0800: > >> mtdblock_flush() >> -->write_cached_data() >> --->erase_write() >> mtdblock: erase of region [0x40000, 0x20000] on "xxx" failed >> >> Because mtdblock_flush() always returns 0, >> even if write_cached_data() fails and data is not written to the device, >> syscall_write() still returns success > > I reworded a bit the commit log and also added a ' ' after 'mtd:' in > the title when applying. > > Thanks, > Miquèl Your revised commit log is more accurate and clearer, thanks for your correction Thanks. Xiaoming Ni