From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27F3CC742D2 for ; Sun, 14 Jul 2019 12:19:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0A8A82064A for ; Sun, 14 Jul 2019 12:19:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728401AbfGNMTh (ORCPT ); Sun, 14 Jul 2019 08:19:37 -0400 Received: from smtprelay0118.hostedemail.com ([216.40.44.118]:41370 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728302AbfGNMTh (ORCPT ); Sun, 14 Jul 2019 08:19:37 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay01.hostedemail.com (Postfix) with ESMTP id 07B6A100E86C5; Sun, 14 Jul 2019 12:19:36 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: chair55_70b4cd25bb85f X-Filterd-Recvd-Size: 2713 Received: from XPS-9350 (cpe-23-242-196-136.socal.res.rr.com [23.242.196.136]) (Authenticated sender: joe@perches.com) by omf06.hostedemail.com (Postfix) with ESMTPA; Sun, 14 Jul 2019 12:19:34 +0000 (UTC) Message-ID: Subject: Re: [PATCH 04/12] iio: adc: max9611: Fix misuse of GENMASK macro From: Joe Perches To: Jonathan Cameron , Jacopo Mondi Cc: Andrew Morton , linux-kernel@vger.kernel.org, Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , linux-iio@vger.kernel.org Date: Sun, 14 Jul 2019 05:19:32 -0700 In-Reply-To: <20190714125403.0789dc9e@archlinux> References: <2929234bd4ecec41c0d012edc52416ef80f3e368.1562734889.git.joe@perches.com> <20190714125403.0789dc9e@archlinux> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.30.5-0ubuntu0.18.10.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2019-07-14 at 12:54 +0100, Jonathan Cameron wrote: > On Tue, 9 Jul 2019 22:04:17 -0700 > Joe Perches wrote: > > > Arguments are supposed to be ordered high then low. > > > > Signed-off-by: Joe Perches > > Applied to the fixes-togreg branch of iio.git and marked for > stable etc. This mask is used in an init function called from a probe. I don't have this hardware but it looks as if it could never have worked so I doubt the driver and the hardware have ever been tested. Does anyone have this device in actual use? regval = ret & MAX9611_TEMP_MASK; if ((regval > MAX9611_TEMP_MAX_POS && regval < MAX9611_TEMP_MIN_NEG) || regval > MAX9611_TEMP_MAX_NEG) { dev_err(max9611->dev, "Invalid value received from ADC 0x%4x: aborting\n", regval); return -EIO; } > Thanks, > > Jonathan > > > --- > > drivers/iio/adc/max9611.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/iio/adc/max9611.c b/drivers/iio/adc/max9611.c > > index 917223d5ff5b..0e3c6529fc4c 100644 > > --- a/drivers/iio/adc/max9611.c > > +++ b/drivers/iio/adc/max9611.c > > @@ -83,7 +83,7 @@ > > #define MAX9611_TEMP_MAX_POS 0x7f80 > > #define MAX9611_TEMP_MAX_NEG 0xff80 > > #define MAX9611_TEMP_MIN_NEG 0xd980 > > -#define MAX9611_TEMP_MASK GENMASK(7, 15) > > +#define MAX9611_TEMP_MASK GENMASK(15, 7) > > #define MAX9611_TEMP_SHIFT 0x07 > > #define MAX9611_TEMP_RAW(_r) ((_r) >> MAX9611_TEMP_SHIFT) > > #define MAX9611_TEMP_SCALE_NUM 1000000