From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751773AbdEATbC (ORCPT ); Mon, 1 May 2017 15:31:02 -0400 Received: from mout.web.de ([212.227.15.3]:55009 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750820AbdEATax (ORCPT ); Mon, 1 May 2017 15:30:53 -0400 Subject: [PATCH 3/3] soc-knav_dma: Delete error messages for a failed memory allocation in two functions From: SF Markus Elfring To: linux-arm-kernel@lists.infradead.org, Santosh Shilimkar Cc: LKML , kernel-janitors@vger.kernel.org, Wolfram Sang References: Message-ID: Date: Mon, 1 May 2017 21:30:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:BZn6Pk6LsxlZACtSRSttRl97rIqnIWh9Rr60GwEY9ncASNRtW/w mReE7GD8x6F82V/XihjGBKMI7aZUHoz7tgBbhtM7UXFGfMxvJFYM7bIadwHRT6Mfov4IpIt gDCJT+1QTQXknsKbxYYdcG3BHnu1JteG4yOf11ntCyyTgzf9qjHvO6Ne0lBXP5Jz+4DX4IO VghOe6uY/CUhwOPMU6/AA== X-UI-Out-Filterresults: notjunk:1;V01:K0:lGcVJhf3MiM=:zyWQet5OW0R3z61p1C1Zld CoLUqbhzKxs0u5JyH13IzQx3Oh3omlQ8jOAXzjrYGWiK+/k5kr/Jfw4+zYgCsJAWcg1B9RvqU UiKS58uscyWTMCMjzjnuFShO/vWEIHITWyf+zs6Cb0gTsCAcNJavlwMR3svhnrvcnrFdMDFpH Wwf87sIfXd0BbpVcJnMs8EfRGyIeZp4zr4e5aomi4RUkO4XqGECiE7DSnxCIFtnCem7G8LTwx rKaczoy4z/S2PG2mrtkOUljXO66qQuSeIkGxpG9c9C1jOyrUpu3lPgUmdKRlUWzDtvzocC/ei 79REIB3Ct3aD/tzxY8gqgg6XbZIV/0Z4QRexWEvx1Lw3W+JXwT61LO+IrkuIRJl7I4f1bMHrN l8dsuIgjKlChDRnWzrd6pTouJGW7HGdrIPKYoUUGZaX+68pMmtahJ/stDGU4dhouloyLcewQX PnfZ5ysATWuqJm8jDFASEY4BUjV7xVJaMSYEWt5FAW+pHo/5isgw18SPoZZsiQymkBmqwOfXf LtWaTcvCJAvW49909D7xIF9knJtoSYl4IprwDkNWuXOdyBShgRlWT+apJjUg/kzDvRDMb0K1W aoWvjpZGecX+pvPDJ/D2VGKFO0XuFNX0LeF56/TefTt+b9IQFsz+sFNGLBnL7uQop4/oJNHDg 9PtW5o3hbvk9xiY+5v5sJe4IPMtfumPstKabbsf++yIJGSiY2cxHnzCBSjEMqiIZZFRq+IsQB OZ+2LsPggUqW24pR40BtFULG4/v5SpJViPV4rXa2K2N/WdpOUtkUsMvckDnXiphjaJTBW/+cu VD4DvjO Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Mon, 1 May 2017 21:14:48 +0200 The script "checkpatch.pl" pointed information out like the following. WARNING: Possible unnecessary 'out of memory' message Thus remove such statements here. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- drivers/soc/ti/knav_dma.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/soc/ti/knav_dma.c b/drivers/soc/ti/knav_dma.c index 410018d9054e..dd5adfbf9910 100644 --- a/drivers/soc/ti/knav_dma.c +++ b/drivers/soc/ti/knav_dma.c @@ -621,10 +621,9 @@ static int dma_init(struct device_node *cloud, struct device_node *dma_node) u32 i; dma = devm_kzalloc(kdev->dev, sizeof(*dma), GFP_KERNEL); - if (!dma) { - dev_err(kdev->dev, "could not allocate driver mem\n"); + if (!dma) return -ENOMEM; - } + INIT_LIST_HEAD(&dma->list); INIT_LIST_HEAD(&dma->chan_list); @@ -740,10 +739,8 @@ static int knav_dma_probe(struct platform_device *pdev) } kdev = devm_kzalloc(dev, sizeof(*kdev), GFP_KERNEL); - if (!kdev) { - dev_err(dev, "could not allocate driver mem\n"); + if (!kdev) return -ENOMEM; - } kdev->dev = dev; INIT_LIST_HEAD(&kdev->list); -- 2.12.2