From: Jammy Huang <jammy_huang@aspeedtech.com>
To: Paul Menzel <pmenzel@molgen.mpg.de>
Cc: "linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
"andrew@aj.id.au" <andrew@aj.id.au>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
"eajames@linux.ibm.com" <eajames@linux.ibm.com>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"hverkuil-cisco@xs4all.nl" <hverkuil-cisco@xs4all.nl>,
"mchehab@kernel.org" <mchehab@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"laurent.pinchart@ideasonboard.com"
<laurent.pinchart@ideasonboard.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>
Subject: Re: [PATCH v5 05/10] media: v4l: Add definition for the Aspeed JPEG format
Date: Fri, 19 Nov 2021 17:37:47 +0800 [thread overview]
Message-ID: <b38e52d3-2800-ea59-1008-d5327c1c3e40@aspeedtech.com> (raw)
In-Reply-To: <1cc9afa7-397e-64a0-9f1b-b4d3bd85a8f0@molgen.mpg.de>
Dear Paul,
OK, thanks for your suggestion.
On 2021/11/19 下午 04:39, Paul Menzel wrote:
> Dear Jammy,
>
>
> Am 19.11.21 um 03:02 schrieb Jammy Huang:
>
>> On 2021/11/18 下午 08:33, Sakari Ailus wrote:
>>> On Thu, Nov 18, 2021 at 03:40:26PM +0800, Jammy Huang wrote:
>>>> This introduces support for the Aspeed JPEG format, where the new frame
>>>> can refer to previous frame to reduce the amount of compressed data. The
>>>> concept is similar to I/P frame of video compression. I will compare the
>>>> new frame with previous one to decide which macroblock's data is
>>>> changed, and only the changed macroblocks will be compressed.
>>>>
>>>> This Aspeed JPEG format is used by the video engine on Aspeed platforms,
>>>> which is generally adapted for remote KVM.
>>>>
>>>> Signed-off-by: Jammy Huang <jammy_huang@aspeedtech.com>
>>>> ---
>>>> v5:
>>>> - no update
>>>> v4:
>>>> - new
>>>> ---
>>>> Documentation/media/uapi/v4l/pixfmt-reserved.rst | 12 ++++++++++++
>>>> drivers/media/v4l2-core/v4l2-ioctl.c | 1 +
>>>> include/uapi/linux/videodev2.h | 1 +
>>>> 3 files changed, 14 insertions(+)
>>>>
>>>> diff --git a/Documentation/media/uapi/v4l/pixfmt-reserved.rst
>>>> b/Documentation/media/uapi/v4l/pixfmt-reserved.rst
>>>> index b2cd155e691b..23c05063133d 100644
>>>> --- a/Documentation/media/uapi/v4l/pixfmt-reserved.rst
>>>> +++ b/Documentation/media/uapi/v4l/pixfmt-reserved.rst
>>>> @@ -264,6 +264,18 @@ please make a proposal on the linux-media
>>>> mailing list.
>>>> of tiles, resulting in 32-aligned resolutions for the luminance
>>>> plane
>>>> and 16-aligned resolutions for the chrominance plane (with 2x2
>>>> subsampling).
>>>> + * .. _V4L2-PIX-FMT-AJPG:
>>>> +
>>>> + - ``V4L2_PIX_FMT_AJPG``
>>>> + - 'AJPG'
>>>> + - ASPEED JPEG format used by the aspeed-video driver on Aspeed platforms,
>>>> + which is generally adapted for remote KVM.
>>>> + On each frame compression, I will compare the new frame with previous
>>>> + one to decide which macroblock's data is changed, and only the changed
>>>> + macroblocks will be compressed.
>>>> +
>>>> + You could reference to chapter 36, Video Engine, of AST2600's datasheet
>>>> + for more information.
>>> Is this datasheet publicly available? Do you have a URL?
>> Sorry, this datasheet is not publicly available.
>> Hans mentioned this as well in the discussion below:
>>
>> https://lkml.org/lkml/2021/11/10/101
> If questions come up during review, please also add the answers to the
> commit message of the next iteration. ;-) Maybe:
>
>> The implementation is based on datasheet *Name goes here*, revision
>> X, which is not publicly available.
> Kind regards,
>
> Paul
--
Best Regards
Jammy
next prev parent reply other threads:[~2021-11-19 9:39 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-18 7:40 [PATCH v5 00/10] add aspeed-jpeg support for aspeed-video Jammy Huang
2021-11-18 7:40 ` [PATCH v5 01/10] media: aspeed: move err-handling together to the bottom Jammy Huang
2021-11-18 7:40 ` [PATCH v5 02/10] media: aspeed: use v4l2_info/v4l2_warn/v4l2_dbg for log Jammy Huang
2021-11-18 11:56 ` Sakari Ailus
2021-11-18 7:40 ` [PATCH v5 03/10] media: aspeed: add more debug log messages Jammy Huang
2021-11-18 11:57 ` Sakari Ailus
2021-11-19 1:55 ` Jammy Huang
2021-11-18 7:40 ` [PATCH v5 04/10] media: aspeed: refactor to gather format/compress settings Jammy Huang
2021-11-18 7:40 ` [PATCH v5 05/10] media: v4l: Add definition for the Aspeed JPEG format Jammy Huang
2021-11-18 12:33 ` Sakari Ailus
2021-11-19 2:02 ` Jammy Huang
2021-11-19 8:39 ` Paul Menzel
2021-11-19 9:37 ` Jammy Huang [this message]
2021-11-23 10:23 ` Sakari Ailus
2021-11-26 8:08 ` Jammy Huang
2021-11-18 7:40 ` [PATCH v5 06/10] media: v4l2-ctrls: Reserve controls for ASPEED Jammy Huang
2021-11-18 7:40 ` [PATCH v5 07/10] media: aspeed: Use runtime configuration Jammy Huang
2021-11-18 7:40 ` [PATCH v5 08/10] media: aspeed: Support aspeed mode to reduce compressed data Jammy Huang
2021-11-25 14:39 ` Hans Verkuil
2021-11-18 7:40 ` [PATCH v5 09/10] media: aspeed: add comments and macro Jammy Huang
2021-11-25 14:31 ` [PATCH v5 00/10] add aspeed-jpeg support for aspeed-video Hans Verkuil
2021-11-26 8:17 ` Jammy Huang
2021-11-26 9:51 ` Hans Verkuil
2021-12-02 1:29 ` Jammy Huang
2021-12-07 3:03 ` Jammy Huang
2021-12-20 19:55 ` sakari.ailus
2021-12-21 2:13 ` Jammy Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b38e52d3-2800-ea59-1008-d5327c1c3e40@aspeedtech.com \
--to=jammy_huang@aspeedtech.com \
--cc=andrew@aj.id.au \
--cc=eajames@linux.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=pmenzel@molgen.mpg.de \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).