From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37E72C433EF for ; Thu, 9 Jun 2022 02:58:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237367AbiFIC6w (ORCPT ); Wed, 8 Jun 2022 22:58:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37086 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232220AbiFIC6t (ORCPT ); Wed, 8 Jun 2022 22:58:49 -0400 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5ED526E8EB; Wed, 8 Jun 2022 19:58:48 -0700 (PDT) X-UUID: bf200434209c47ecbb24c360cc0a5148-20220609 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.5,REQID:8fb325ca-de2d-40f8-9c4c-80a2f91854e9,OB:0,LO B:0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,RULE:Release_Ham,ACTI ON:release,TS:0 X-CID-META: VersionHash:2a19b09,CLOUDID:a8552ee5-2ba2-4dc1-b6c5-11feb6c769e0,C OID:IGNORED,Recheck:0,SF:nil,TC:nil,Content:0,EDM:-3,IP:nil,URL:0,File:nil ,QS:0,BEC:nil X-UUID: bf200434209c47ecbb24c360cc0a5148-20220609 Received: from mtkmbs11n2.mediatek.inc [(172.21.101.187)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 615797572; Thu, 09 Jun 2022 10:58:44 +0800 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.15; Thu, 9 Jun 2022 10:58:43 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 9 Jun 2022 10:58:42 +0800 Message-ID: Subject: Re: [PATCH v6 2/8] ASoC: mediatek: mt8186: add platform driver From: Jiaxin Yu To: Mark Brown CC: , , , , , , , , , , , , Date: Thu, 9 Jun 2022 10:58:42 +0800 In-Reply-To: References: <20220607142046.28060-1-jiaxin.yu@mediatek.com> <20220607142046.28060-3-jiaxin.yu@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2022-06-08 at 12:24 +0100, Mark Brown wrote: > On Tue, Jun 07, 2022 at 10:20:40PM +0800, Jiaxin Yu wrote: > > > +obj-$(CONFIG_SND_SOC_MT8186) += snd-soc-mt8186-afe.o > > +obj-$(CONFIG_SND_SOC_MT8186_MT6366_DA7219_MAX98357) += mt8186- > > mt6366-da7219-max98357.o > > +obj-$(CONFIG_SND_SOC_MT8186_MT6366_RT1019_RT5682S) += mt8186- > > mt6366-rt1019-rt5682s.o > > This breaks bisection - these drivers are being added to the build > here > but the relevant source files aren't added until later on in the > series > so the commits in between won't build when the relevant Kconfig > options > are selected. The Makefile and Kconfig updates should be moved into > the > driver patches. I see, this is to ensure the independence of each patch. I will move the Kconfig and Makefile changes related to the machine driver to the corresponding patch. Thanks, Jiaxin.Yu