From: Richard Gong <richard.gong@linux.intel.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
gregkh@linuxfoundation.org, atull@kernel.org
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 4/4 v2] firmware: stratix10-svc: Slightly simplify code
Date: Tue, 5 May 2020 09:18:43 -0500 [thread overview]
Message-ID: <b3b70de2-73af-f136-749c-51e40be9ffdc@linux.intel.com> (raw)
In-Reply-To: <dab419d3-5942-fa89-a352-e8917ced0744@wanadoo.fr>
Hi,
On 5/2/20 3:49 AM, Christophe JAILLET wrote:
> Le 01/05/2020 à 18:55, Richard Gong a écrit :
>> Hi,
>>
>> On 5/1/20 10:48 AM, Christophe JAILLET wrote:
>>> Le 01/05/2020 à 17:40, Richard Gong a écrit :
>>>> Hi,
>>>>
>>>> On 4/29/20 1:52 AM, Christophe JAILLET wrote:
>>>>> Replace 'devm_kmalloc_array(... | __GFP_ZERO)' with the equivalent and
>>>>> shorter 'devm_kcalloc(...)'.
>>>>>
>>>> It doesn't make much sense.
>>>> Actually devm_kcalloc returns devm_kmalloc_array(.., flag |
>>>> __GFP_ZERO).
>>>>
>>> The only goal is to have a sightly less verbose code.
>>> This saves one line of code and there is no need to wonder why we
>>> explicitly pass __GFP_ZERO to kmalloc_array.
>>>
>>> Mostly a matter of taste.
>> I prefer this part remain unchanged.
>>
>
> The easiest would be just to ignore this patch entirely
Yes, please.
but if you need
> a v3 for the series, could you tell me if you have any comments on the 3
> other patches?
>
I added some comments in your patch #3, also recommend putting all
changes in one patch.
Regards,
Richard
> CJ
>
>
>> Regards,
>> Richard
>>
>>>
>>> 'devm_kcalloc' is inlined, so the binary should be exactly the same. >
>>> CJ
>>>
>>>>> 'ctrl->genpool' can not be NULL, so axe a useless test in the remove
>>>>> function.
>>>>>
>>>>> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
>>>>> ---
>>>>> drivers/firmware/stratix10-svc.c | 6 ++----
>>>>> 1 file changed, 2 insertions(+), 4 deletions(-)
>>>>>
>>>>> diff --git a/drivers/firmware/stratix10-svc.c
>>>>> b/drivers/firmware/stratix10-svc.c
>>>>> index 739004398877..c228337cb0a1 100644
>>>>> --- a/drivers/firmware/stratix10-svc.c
>>>>> +++ b/drivers/firmware/stratix10-svc.c
>>>>> @@ -1002,8 +1002,7 @@ static int stratix10_svc_drv_probe(struct
>>>>> platform_device *pdev)
>>>>> if (!controller)
>>>>> return -ENOMEM;
>>>>> - chans = devm_kmalloc_array(dev, SVC_NUM_CHANNEL,
>>>>> - sizeof(*chans), GFP_KERNEL | __GFP_ZERO);
>>>>> + chans = devm_kcalloc(dev, SVC_NUM_CHANNEL, sizeof(*chans),
>>>>> GFP_KERNEL);
>>>>> if (!chans)
>>>>> return -ENOMEM;
>>>>> @@ -1086,8 +1085,7 @@ static int stratix10_svc_drv_remove(struct
>>>>> platform_device *pdev)
>>>>> kthread_stop(ctrl->task);
>>>>> ctrl->task = NULL;
>>>>> }
>>>>> - if (ctrl->genpool)
>>>>> - gen_pool_destroy(ctrl->genpool);
>>>>> + gen_pool_destroy(ctrl->genpool);
>>>>> list_del(&ctrl->node);
>>>>> return 0;
>>>>>
>>>>
>>>> Regards,
>>>> Richard
>>>>
>>>
>>
>
next prev parent reply other threads:[~2020-05-05 14:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 6:52 [PATCH 0/4 v2] firmware: stratix10-svc: Fix some error handling code Christophe JAILLET
2020-04-29 6:52 ` [PATCH 1/4 v2] firmware: stratix10-svc: Fix genpool creation error handling Christophe JAILLET
2020-04-29 6:52 ` [PATCH 2/4 v2] firmware: stratix10-svc: Unmap some previously memremap'ed memory Christophe JAILLET
2020-05-05 14:43 ` Greg KH
2020-05-05 15:09 ` Christophe JAILLET
2020-04-29 6:52 ` [PATCH 3/4 v2] firmware: stratix10-svc: Fix some error handling paths in 'stratix10_svc_drv_probe()' Christophe JAILLET
2020-05-05 14:02 ` Richard Gong
2020-05-05 15:15 ` Christophe JAILLET
2020-06-26 19:37 ` [PATCH V3] firmware: stratix10-svc: Fix some error handling code Christophe JAILLET
2020-06-27 5:15 ` Greg KH
2020-06-27 5:15 ` Greg KH
2020-06-27 7:31 ` Marion & Christophe JAILLET
2020-06-27 8:03 ` Greg KH
2020-04-29 6:52 ` [PATCH 4/4 v2] firmware: stratix10-svc: Slightly simplify code Christophe JAILLET
2020-05-01 15:40 ` Richard Gong
2020-05-01 15:48 ` Christophe JAILLET
2020-05-01 16:55 ` Richard Gong
2020-05-02 8:49 ` Christophe JAILLET
2020-05-05 14:18 ` Richard Gong [this message]
2020-05-06 10:04 ` Dan Carpenter
2020-04-29 12:41 Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3b70de2-73af-f136-749c-51e40be9ffdc@linux.intel.com \
--to=richard.gong@linux.intel.com \
--cc=atull@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).