From: "lizhijian@fujitsu.com" <lizhijian@fujitsu.com>
To: "zyjzyj2000@gmail.com" <zyjzyj2000@gmail.com>,
"jgg@ziepe.ca" <jgg@ziepe.ca>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] RDMA/rxe: Remove useless parameters for update_state()
Date: Fri, 22 Apr 2022 01:07:46 +0000 [thread overview]
Message-ID: <b3c747ed-1a87-896b-d95e-35fd2a80ccf7@fujitsu.com> (raw)
In-Reply-To: <20220412022903.574238-1-lizhijian@fujitsu.com>
ping
On 12/04/2022 10:29, Li Zhijian wrote:
> wqe was not used by update_state() so far.
>
> aaaf62e06623 ("RDMA/rxe: Remove useless argument for update_state()")
> just did a partial fixes.
>
> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
> ---
> drivers/infiniband/sw/rxe/rxe_req.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/infiniband/sw/rxe/rxe_req.c b/drivers/infiniband/sw/rxe/rxe_req.c
> index 5f7348b11268..bf7493bab9b9 100644
> --- a/drivers/infiniband/sw/rxe/rxe_req.c
> +++ b/drivers/infiniband/sw/rxe/rxe_req.c
> @@ -525,8 +525,7 @@ static void rollback_state(struct rxe_send_wqe *wqe,
> qp->req.psn = rollback_psn;
> }
>
> -static void update_state(struct rxe_qp *qp, struct rxe_send_wqe *wqe,
> - struct rxe_pkt_info *pkt)
> +static void update_state(struct rxe_qp *qp, struct rxe_pkt_info *pkt)
> {
> qp->req.opcode = pkt->opcode;
>
> @@ -753,7 +752,7 @@ int rxe_requester(void *arg)
> goto err;
> }
>
> - update_state(qp, wqe, &pkt);
> + update_state(qp, &pkt);
>
> goto next_wqe;
>
next prev parent reply other threads:[~2022-04-22 1:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-12 2:29 [PATCH 1/3] RDMA/rxe: Remove useless parameters for update_state() Li Zhijian
2022-04-12 2:29 ` [PATCH 2/3] RDMA/rxe: Update wqe_index for each wqe error completion Li Zhijian
2022-04-12 2:29 ` [PATCH 3/3] RDMA/rxe: Generate error completion for error requester state Li Zhijian
2022-04-22 1:07 ` lizhijian [this message]
2022-04-23 0:56 ` [PATCH 1/3] RDMA/rxe: Remove useless parameters for update_state() Jason Gunthorpe
2022-04-25 19:52 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3c747ed-1a87-896b-d95e-35fd2a80ccf7@fujitsu.com \
--to=lizhijian@fujitsu.com \
--cc=jgg@ziepe.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).