From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: robin.murphy@arm.com, mathieu.poirier@linaro.org
Cc: coresight@lists.linaro.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/4] coresight: tmc-etr: Do not call smp_processor_id() from preemptible
Date: Thu, 30 May 2019 16:52:40 +0100 [thread overview]
Message-ID: <b3e5dd32-5231-36fa-fe97-136aa98f1bef@arm.com> (raw)
In-Reply-To: <319d4d63-326b-9bb5-6a24-f7aa8ec549f9@arm.com>
Hi Robin,
On 10/05/2019 11:38, Robin Murphy wrote:
> Hi Suzuki,
>
> On 10/05/2019 10:31, Suzuki K Poulose wrote:
>> Instead of using smp_processor_id() to figure out the node,
>> use the numa_node_id() for the current CPU node to avoid
>> splats like :
>
>> diff --git a/drivers/hwtracing/coresight/coresight-tmc-etr.c b/drivers/hwtracing/coresight/coresight-tmc-etr.c
>> index 793639f..cae9d8a 100644
>> --- a/drivers/hwtracing/coresight/coresight-tmc-etr.c
>> +++ b/drivers/hwtracing/coresight/coresight-tmc-etr.c
>> @@ -1323,13 +1323,11 @@ static struct etr_perf_buffer *
>> tmc_etr_setup_perf_buf(struct tmc_drvdata *drvdata, struct perf_event *event,
>> int nr_pages, void **pages, bool snapshot)
>> {
>> - int node, cpu = event->cpu;
>> + int node;
>> struct etr_buf *etr_buf;
>> struct etr_perf_buffer *etr_perf;
>>
>> - if (cpu == -1)
>> - cpu = smp_processor_id();
>> - node = cpu_to_node(cpu);
>> + node = (event->cpu == -1) ? numa_node_id() : cpu_to_node(event->cpu);
>
> If cpu == -1 represents a "don't care" scenario, it might be clearer to
> just use NUMA_NO_NODE instead, and let the allocator handle it.
Thanks for the suggestion, will use that instead
Cheers
Suzuki
next prev parent reply other threads:[~2019-05-30 15:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-10 9:30 [PATCH 0/4] coresight: Do not call smp_processor_id from preemptible contexts Suzuki K Poulose
2019-05-10 9:31 ` [PATCH 1/4] coresight: tmc-etr: Do not call smp_processor_id() from preemptible Suzuki K Poulose
2019-05-10 10:38 ` Robin Murphy
2019-05-30 15:52 ` Suzuki K Poulose [this message]
2019-05-10 9:31 ` [PATCH 2/4] coresight: tmc-etr: alloc_perf_buf: Do not call smp_processor_id " Suzuki K Poulose
2019-05-10 9:31 ` [PATCH 3/4] coresight: tmc-etf: " Suzuki K Poulose
2019-05-10 9:31 ` [PATCH 4/4] coresight: etb10: " Suzuki K Poulose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3e5dd32-5231-36fa-fe97-136aa98f1bef@arm.com \
--to=suzuki.poulose@arm.com \
--cc=coresight@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).