Re: [PATCH V3 1/7] backlight: qcom-wled: Rename pm8941-wled.c to qcom-wled.c

From: kgunda@codeaurora.org
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: jingoohan1@gmail.com, lee.jones@linaro.org,
	b.zolnierkie@samsung.com, dri-devel@lists.freedesktop.org,
	Daniel Thompson <daniel.thompson@linaro.org>,
	Jacek Anaszewski <jacek.anaszewski@gmail.com>,
	Pavel Machek <pavel@ucw.cz>, Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
	linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH V3 1/7] backlight: qcom-wled: Rename pm8941-wled.c to qcom-wled.c
Date: Wed, 20 Jun 2018 10:53:19 +0530	[thread overview]
Message-ID: <b3e66f817d919b3b8a8330e7c6827ce2@codeaurora.org> (raw)
In-Reply-To: <20180619225421.GE15126@tuxbook-pro>

On 2018-06-20 04:24, Bjorn Andersson wrote:
> On Tue 19 Jun 04:13 PDT 2018, Kiran Gunda wrote:
> 
>> pm8941-wled.c driver is supporting the WLED peripheral
>> on pm8941. Rename it to qcom-wled.c so that it can support
>> WLED on multiple PMICs.
>> 
>> Signed-off-by: Kiran Gunda <kgunda@codeaurora.org>
> 
> Please carry any tags acquired when reposting patches without changes
> and please add a "Changes since v???:" list below the --- to expedite
> the review process.
> 
> 
> This is still
> 
> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> 
> Regards,
> Bjorn
> 
Thanks Bjorn for reviewing. Sure I will keep the tags when re-posting.
I have mentioned the consolidated changes in the 0th patch. Anyways,
I will keep it for individual patches from next time.
>> ---
>>  .../bindings/leds/backlight/{pm8941-wled.txt => qcom-wled.txt}    | 2 
>> +-
>>  drivers/video/backlight/Kconfig                                   | 8 
>> ++++----
>>  drivers/video/backlight/Makefile                                  | 2 
>> +-
>>  drivers/video/backlight/{pm8941-wled.c => qcom-wled.c}            | 0
>>  4 files changed, 6 insertions(+), 6 deletions(-)
>>  rename 
>> Documentation/devicetree/bindings/leds/backlight/{pm8941-wled.txt => 
>> qcom-wled.txt} (95%)
>>  rename drivers/video/backlight/{pm8941-wled.c => qcom-wled.c} (100%)
>> 
>> diff --git 
>> a/Documentation/devicetree/bindings/leds/backlight/pm8941-wled.txt 
>> b/Documentation/devicetree/bindings/leds/backlight/qcom-wled.txt
>> similarity index 95%
>> rename from 
>> Documentation/devicetree/bindings/leds/backlight/pm8941-wled.txt
>> rename to 
>> Documentation/devicetree/bindings/leds/backlight/qcom-wled.txt
>> index e5b294d..fb39e32 100644
>> --- a/Documentation/devicetree/bindings/leds/backlight/pm8941-wled.txt
>> +++ b/Documentation/devicetree/bindings/leds/backlight/qcom-wled.txt
>> @@ -1,4 +1,4 @@
>> -Binding for Qualcomm PM8941 WLED driver
>> +Binding for Qualcomm Technologies, Inc. WLED driver
>> 
>>  Required properties:
>>  - compatible: should be "qcom,pm8941-wled"
>> diff --git a/drivers/video/backlight/Kconfig 
>> b/drivers/video/backlight/Kconfig
>> index 4e1d2ad..8c095e3 100644
>> --- a/drivers/video/backlight/Kconfig
>> +++ b/drivers/video/backlight/Kconfig
>> @@ -299,12 +299,12 @@ config BACKLIGHT_TOSA
>>  	  If you have an Sharp SL-6000 Zaurus say Y to enable a driver
>>  	  for its backlight
>> 
>> -config BACKLIGHT_PM8941_WLED
>> -	tristate "Qualcomm PM8941 WLED Driver"
>> +config BACKLIGHT_QCOM_WLED
>> +	tristate "Qualcomm PMIC WLED Driver"
>>  	select REGMAP
>>  	help
>> -	  If you have the Qualcomm PM8941, say Y to enable a driver for the
>> -	  WLED block.
>> +	  If you have the Qualcomm PMIC, say Y to enable a driver for the
>> +	  WLED block. Currently it supports PM8941 and PMI8998.
>> 
>>  config BACKLIGHT_SAHARA
>>  	tristate "Tabletkiosk Sahara Touch-iT Backlight Driver"
>> diff --git a/drivers/video/backlight/Makefile 
>> b/drivers/video/backlight/Makefile
>> index 5e28f01..6fd76ef 100644
>> --- a/drivers/video/backlight/Makefile
>> +++ b/drivers/video/backlight/Makefile
>> @@ -49,8 +49,8 @@ obj-$(CONFIG_BACKLIGHT_OMAP1)		+= omap1_bl.o
>>  obj-$(CONFIG_BACKLIGHT_OT200)		+= ot200_bl.o
>>  obj-$(CONFIG_BACKLIGHT_PANDORA)		+= pandora_bl.o
>>  obj-$(CONFIG_BACKLIGHT_PCF50633)	+= pcf50633-backlight.o
>> -obj-$(CONFIG_BACKLIGHT_PM8941_WLED)	+= pm8941-wled.o
>>  obj-$(CONFIG_BACKLIGHT_PWM)		+= pwm_bl.o
>> +obj-$(CONFIG_BACKLIGHT_QCOM_WLED)	+= qcom-wled.o
>>  obj-$(CONFIG_BACKLIGHT_SAHARA)		+= kb3886_bl.o
>>  obj-$(CONFIG_BACKLIGHT_SKY81452)	+= sky81452-backlight.o
>>  obj-$(CONFIG_BACKLIGHT_TOSA)		+= tosa_bl.o
>> diff --git a/drivers/video/backlight/pm8941-wled.c 
>> b/drivers/video/backlight/qcom-wled.c
>> similarity index 100%
>> rename from drivers/video/backlight/pm8941-wled.c
>> rename to drivers/video/backlight/qcom-wled.c
>> --
>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora 
>> Forum,
>>  a Linux Foundation Collaborative Project
>>