From: Konrad Dybcio <konrad.dybcio@somainline.org>
To: Robert Foss <robert.foss@linaro.org>,
agross@kernel.org, bjorn.andersson@linaro.org, amitk@kernel.org,
rui.zhang@intel.com, daniel.lezcano@linaro.org,
robh+dt@kernel.org, linux-arm-msm@vger.kernel.org,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Vinod Koul <vinod.koul@linaro.org>
Subject: Re: [PATCH v2 2/2] arm64: dts: qcom: sm8350: Add thermal zones and throttling support
Date: Mon, 22 Mar 2021 18:27:13 +0100 [thread overview]
Message-ID: <b3f17dd3-d4b3-930c-db02-9f67748e4427@somainline.org> (raw)
In-Reply-To: <20210322100420.125616-2-robert.foss@linaro.org>
Hi!
> + tsens0: thermal-sensor@c222000 {
> + compatible = "qcom,sm8350-tsens", "qcom,tsens-v2";
> + reg = <0 0x0C263000 0 0x1ff>, /* TM */
> + <0 0x0C222000 0 0x8>; /* SROT */
Please use lowercase hex
> + tsens1: thermal-sensor@c223000 {
> + compatible = "qcom,sm8350-tsens", "qcom,tsens-v2";
> + reg = <0 0x0C265000 0 0x1ff>, /* TM */
> + <0 0x0c223000 0 0x8>; /* SROT */
Ditto
> + trips {
> + cpu0_alert0: trip-point0 {
> + temperature = <90000>;
> + hysteresis = <2000>;
> + type = "passive";
> + };
> +
> + cpu0_alert1: trip-point1 {
> + temperature = <95000>;
> + hysteresis = <2000>;
> + type = "passive";
Shouldn't this be "hot"? Possibly ditto for all cpu*alert1-labeled nodes.
> + };
> +
> + cpu0_crit: cpu_crit {
> + temperature = <110000>;
> + hysteresis = <1000>;
> + type = "critical";
> + };
> + };
These values seem, err.. scorching hot.. Are they alright?
> + // TODO: What is the NSP subsystem?
Please use C-style comments (/* foo */)
Konrad
next prev parent reply other threads:[~2021-03-22 17:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-22 10:04 [PATCH v2 1/2] dt-bindings: thermal: qcom-tsens: Add compatible for sm8350 Robert Foss
2021-03-22 10:04 ` [PATCH v2 2/2] arm64: dts: qcom: sm8350: Add thermal zones and throttling support Robert Foss
2021-03-22 12:17 ` Vinod Koul
2021-03-22 17:27 ` Konrad Dybcio [this message]
2021-03-23 8:36 ` Robert Foss
2021-03-22 12:17 ` [PATCH v2 1/2] dt-bindings: thermal: qcom-tsens: Add compatible for sm8350 Vinod Koul
2021-03-23 16:20 Robert Foss
2021-03-23 16:20 ` [PATCH v2 2/2] arm64: dts: qcom: sm8350: Add thermal zones and throttling support Robert Foss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3f17dd3-d4b3-930c-db02-9f67748e4427@somainline.org \
--to=konrad.dybcio@somainline.org \
--cc=agross@kernel.org \
--cc=amitk@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robert.foss@linaro.org \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=vinod.koul@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).