From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A195C64E7A for ; Tue, 1 Dec 2020 22:12:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DD3F420870 for ; Tue, 1 Dec 2020 22:12:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YXFYJkFe" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726715AbgLAWMZ (ORCPT ); Tue, 1 Dec 2020 17:12:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725902AbgLAWMY (ORCPT ); Tue, 1 Dec 2020 17:12:24 -0500 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C65DC0613CF; Tue, 1 Dec 2020 14:11:44 -0800 (PST) Received: by mail-wm1-x341.google.com with SMTP id g185so10665720wmf.3; Tue, 01 Dec 2020 14:11:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=vvLKivZTLe69yfxBowgpcvtJyakog4e3s87+lmyS3oE=; b=YXFYJkFe0R2S+2QuSkm4uEiX9GDrpMaUQNkTJk1Q6Mzjl7+/n3Ew06bToFqd3nTWYG LGlvtSXdwWEkL9vkz17ZaQvRKicaDsdnaoHjcE1WlGz79mcX9S77pFQzVIeVbUVDqxyL +nsMAmcQPTUZWmV29+XRyj7PnXLsoxSZ8PxdH36dxcAC0litYnrU5/NOyUDQ6dzI/LN0 SnURs2cKL4KMFpW1GEbKV+0C6d8FaDfA+hXOHu3xE5rJkx1Qt9DvSl1j0qEgaFlNBndK MQDwcCoblzro/koKmYrHi/R2qHzgcdMff00C0vd5saAGhd3QdvZHq6sFE3IN3koNKzmZ 9sFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=vvLKivZTLe69yfxBowgpcvtJyakog4e3s87+lmyS3oE=; b=IS1NHIiE0cxV4tfGeod3h8pxRYVnPLvKkGunYBHUwTSBxLBcAZtP3E0+NthgO7o1H1 /33OHW9gguYRP7CWREBlSAofFj+3X1zEqTAGyZsH2AtmV/dpe4udR900H3pUjYZuI2Zg 5kweZyE/oZsoU5qr/xkNQZPN9WuJ/1xiqGg74xWhOa3WYplaqNvPNaJKRKesr0fWfko9 23yPZSLOz+dIvKrMq77D9EMxpM39jt6qDnI46AtBoT1ougeezG1YLjzwxKv5+1C6/ics Rfhdijc5dseGwLFf4pQpIryF/NDa+JNgTIJM7uC3ogekWd2Uv5rG35CWAma/QqIlcyJQ wBTA== X-Gm-Message-State: AOAM531FzqynueZ1VnXbTmZRHCM5LYUtPndZlWWRJzjwZKFws1opqPo0 nDDOL6G0UWUaXkAIGW2H+nc= X-Google-Smtp-Source: ABdhPJz4FVPeIVmkqb70ApddW6Q/2CdhTY2VEJRk485BvgTKPlG8PC6HJx0bJJqPmdsa7OUimUHXJw== X-Received: by 2002:a1c:4954:: with SMTP id w81mr4828931wma.60.1606860703107; Tue, 01 Dec 2020 14:11:43 -0800 (PST) Received: from [192.168.1.211] ([2.31.224.80]) by smtp.gmail.com with ESMTPSA id y2sm1629948wma.6.2020.12.01.14.11.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Dec 2020 14:11:42 -0800 (PST) Subject: Re: [PATCH 13/18] ipu3-cio2: Add functionality allowing software_node connections to sensors on platforms designed for Windows From: Dan Scally To: Laurent Pinchart Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org, linux-media@vger.kernel.org, devel@acpica.org, rjw@rjwysocki.net, lenb@kernel.org, gregkh@linuxfoundation.org, mika.westerberg@linux.intel.com, andriy.shevchenko@linux.intel.com, linus.walleij@linaro.org, bgolaszewski@baylibre.com, wsa@kernel.org, yong.zhi@intel.com, sakari.ailus@linux.intel.com, bingbu.cao@intel.com, tian.shu.qiu@intel.com, mchehab@kernel.org, robert.moore@intel.com, erik.kaneda@intel.com, pmladek@suse.com, rostedt@goodmis.org, sergey.senozhatsky@gmail.com, linux@rasmusvillemoes.dk, kieran.bingham+renesas@ideasonboard.com, jacopo+renesas@jmondi.org, laurent.pinchart+renesas@ideasonboard.com, jorhand@linux.microsoft.com, kitakar@gmail.com, heikki.krogerus@linux.intel.com References: <20201130133129.1024662-1-djrscally@gmail.com> <20201130133129.1024662-14-djrscally@gmail.com> <20201130170955.GN14465@pendragon.ideasonboard.com> Message-ID: Date: Tue, 1 Dec 2020 22:11:41 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/12/2020 22:08, Dan Scally wrote: >>> + >>> + for_each_acpi_dev_match(adev, this_device, NULL, -1) { >>> + if (!adev || !(adev->status.present && adev->status.enabled)) >> if (!adev || !adev->status.present || !adev->status.enabled)) >> >> may be a bit more readable. Does for_each_acpi_dev_match() return NULL >> devices though ? If no, you could drop the !adev check. You may also be >> able to drop the !present check, as I don't think ACPI allows !present >> && enabled. > You're right, the spec mandates enabled be 0 if present is 0. The > iterator will return NULL when the previous return value was the last > matching device, so that part needs to stay, but it can become: > > if (!adev || !adev->status.enabled) > Wait, that's silly, the loop won't start if the check is null so you're right of course.