From: Marc Zyngier <marc.zyngier@arm.com>
To: dann frazier <dann.frazier@canonical.com>
Cc: linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Will Deacon <will.deacon@arm.com>, Scott Wood <oss@buserror.net>,
Hanjun Guo <hanjun.guo@linaro.org>,
Ding Tianhong <dingtianhong@huawei.com>,
Seth Forshee <seth.forshee@canonical.com>
Subject: Re: [PATCH v2 06/18] arm64: arch_timer: Add infrastructure for multiple erratum detection methods
Date: Fri, 24 Mar 2017 18:00:35 +0000 [thread overview]
Message-ID: <b40e0cc7-5580-a834-babe-0dfa8427629e@arm.com> (raw)
In-Reply-To: <CALdTtnvyT1qjKp5C5AfvSSW7GqN3m2Y_CkTMEX+5OxyvH=+G2Q@mail.gmail.com>
Hi Dann,
On 24/03/17 17:48, dann frazier wrote:
> On Mon, Mar 20, 2017 at 11:48 AM, Marc Zyngier <marc.zyngier@arm.com> wrote:
>> We're currently stuck with DT when it comes to handling errata, which
>> is pretty restrictive. In order to make things more flexible, let's
>> introduce an infrastructure that could support alternative discovery
>> methods. No change in functionality.
>>
>> Reviewed-by: Hanjun Guo <hanjun.guo@linaro.org>
>> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
>> ---
>> arch/arm64/include/asm/arch_timer.h | 7 +++-
>> drivers/clocksource/arm_arch_timer.c | 80 +++++++++++++++++++++++++++++++-----
>> 2 files changed, 75 insertions(+), 12 deletions(-)
>>
>> diff --git a/arch/arm64/include/asm/arch_timer.h b/arch/arm64/include/asm/arch_timer.h
>> index b4b34004a21e..5cd964e90d11 100644
>> --- a/arch/arm64/include/asm/arch_timer.h
>> +++ b/arch/arm64/include/asm/arch_timer.h
>> @@ -37,9 +37,14 @@ extern struct static_key_false arch_timer_read_ool_enabled;
>> #define needs_unstable_timer_counter_workaround() false
>> #endif
>>
>> +enum arch_timer_erratum_match_type {
>> + ate_match_dt,
>> +};
>>
>> struct arch_timer_erratum_workaround {
>> - const char *id; /* Indicate the Erratum ID */
>> + enum arch_timer_erratum_match_type match_type;
>> + const void *id;
>> + const char *desc;
>> u32 (*read_cntp_tval_el0)(void);
>> u32 (*read_cntv_tval_el0)(void);
>> u64 (*read_cntvct_el0)(void);
>> diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c
>> index 7a8a4117f123..6a0f0e161a0f 100644
>> --- a/drivers/clocksource/arm_arch_timer.c
>> +++ b/drivers/clocksource/arm_arch_timer.c
>> @@ -182,7 +182,9 @@ EXPORT_SYMBOL_GPL(arch_timer_read_ool_enabled);
>> static const struct arch_timer_erratum_workaround ool_workarounds[] = {
>> #ifdef CONFIG_FSL_ERRATUM_A008585
>> {
>> + .match_type = ate_match_dt,
>> .id = "fsl,erratum-a008585",
>> + .desc = "Freescale erratum a005858",
>> .read_cntp_tval_el0 = fsl_a008585_read_cntp_tval_el0,
>> .read_cntv_tval_el0 = fsl_a008585_read_cntv_tval_el0,
>> .read_cntvct_el0 = fsl_a008585_read_cntvct_el0,
>> @@ -190,13 +192,78 @@ static const struct arch_timer_erratum_workaround ool_workarounds[] = {
>> #endif
>> #ifdef CONFIG_HISILICON_ERRATUM_161010101
>> {
>> + .match_type = ate_match_dt,
>> .id = "hisilicon,erratum-161010101",
>> + .desc = "HiSilicon erratum 161010101",
>> .read_cntp_tval_el0 = hisi_161010101_read_cntp_tval_el0,
>> .read_cntv_tval_el0 = hisi_161010101_read_cntv_tval_el0,
>> .read_cntvct_el0 = hisi_161010101_read_cntvct_el0,
>> },
>> #endif
>> };
>> +
>> +typedef bool (*ate_match_fn_t)(const struct arch_timer_erratum_workaround *,
>> + const void *);
>> +
>> +static
>> +bool arch_timer_check_dt_erratum(const struct arch_timer_erratum_workaround *wa,
>> + const void *arg)
>> +{
>> + const struct device_node *np = arg;
>> +
>> + return of_property_read_bool(np, wa->id);
>> +}
>> +
>> +static const struct arch_timer_erratum_workaround *
>> +arch_timer_iterate_errata(enum arch_timer_erratum_match_type type,
>> + ate_match_fn_t match_fn,
>> + void *arg)
>> +{
>> + int i;
>> +
>> + for (i = 0; i < ARRAY_SIZE(ool_workarounds); i++) {
>> + if (ool_workarounds[i].match_type != type)
>> + continue;
>> +
>> + if (match_fn(&ool_workarounds[i], arg))
>> + return &ool_workarounds[i];
>> + }
>> +
>> + return NULL;
>> +}
>> +
>> +static
>> +void arch_timer_enable_workaround(const struct arch_timer_erratum_workaround *wa)
>> +{
>> + timer_unstable_counter_workaround = wa;
>> + static_branch_enable(&arch_timer_read_ool_enabled);
>> +}
>> +
>> +static void arch_timer_check_ool_workaround(enum arch_timer_erratum_match_type type,
>> + void *arg)
>> +{
>> + const struct arch_timer_erratum_workaround *wa;
>> + ate_match_fn_t match_fn = NULL;
>> +
>> + if (static_branch_unlikely(&arch_timer_read_ool_enabled))
>> + return;
>> +
>> + switch (type) {
>> + case ate_match_dt:
>> + match_fn = arch_timer_check_dt_erratum;
>> + break;
>
> hey Marc,
> Would it make sense to have a default case here that warns &
> returns? That wouldn't get hit by this series as-is, but might avoid a
> NULL callback in the future.
Sure, I can add that in the next version of this series. I would have
hoped that GCC would warn you if you don't handle all the values of an
enum, but it doesn't hurt to be cautious.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2017-03-24 18:11 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-20 17:48 [PATCH v2 00/18] clocksource/arch_timer: Errata workaround infrastructure rework Marc Zyngier
2017-03-20 17:48 ` [PATCH v2 01/18] arm64: Allow checking of a CPU-local erratum Marc Zyngier
2017-03-22 9:22 ` Daniel Lezcano
2017-03-20 17:48 ` [PATCH v2 02/18] arm64: Add CNTVCT_EL0 trap handler Marc Zyngier
2017-03-20 17:48 ` [PATCH v2 03/18] arm64: Define Cortex-A73 MIDR Marc Zyngier
2017-03-20 17:48 ` [PATCH v2 04/18] arm64: cpu_errata: Allow an erratum to be match for all revisions of a core Marc Zyngier
2017-03-22 14:57 ` Daniel Lezcano
2017-03-20 17:48 ` [PATCH v2 05/18] arm64: cpu_errata: Add capability to advertise Cortex-A73 erratum 858921 Marc Zyngier
2017-03-22 15:01 ` Daniel Lezcano
2017-03-20 17:48 ` [PATCH v2 06/18] arm64: arch_timer: Add infrastructure for multiple erratum detection methods Marc Zyngier
2017-03-22 15:41 ` Daniel Lezcano
2017-03-22 15:53 ` Marc Zyngier
2017-03-22 15:59 ` Marc Zyngier
2017-03-22 16:52 ` Daniel Lezcano
2017-03-23 17:30 ` Daniel Lezcano
2017-03-24 13:51 ` Marc Zyngier
2017-03-27 7:56 ` Daniel Lezcano
2017-03-28 13:07 ` Marc Zyngier
2017-03-28 13:34 ` Daniel Lezcano
2017-03-28 14:07 ` Marc Zyngier
2017-03-28 14:36 ` Daniel Lezcano
2017-03-28 14:48 ` Marc Zyngier
2017-03-28 14:55 ` Daniel Lezcano
2017-03-28 15:38 ` Marc Zyngier
2017-03-29 14:27 ` Daniel Lezcano
2017-03-29 14:56 ` Marc Zyngier
2017-03-29 15:12 ` Daniel Lezcano
2017-03-24 17:48 ` dann frazier
2017-03-24 18:00 ` Marc Zyngier [this message]
2017-03-30 9:28 ` Daniel Lezcano
2017-03-20 17:48 ` [PATCH v2 07/18] arm64: arch_timer: Add erratum handler for globally defined capability Marc Zyngier
2017-03-20 17:48 ` [PATCH v2 08/18] arm64: arch_timer: Add erratum handler for CPU-specific capability Marc Zyngier
2017-03-20 17:48 ` [PATCH v2 09/18] arm64: arch_timer: Move arch_timer_reg_read/write around Marc Zyngier
2017-03-22 15:47 ` Daniel Lezcano
2017-03-20 17:48 ` [PATCH v2 10/18] arm64: arch_timer: Get rid of erratum_workaround_set_sne Marc Zyngier
2017-03-20 17:48 ` [PATCH v2 11/18] arm64: arch_timer: Rework the set_next_event workarounds Marc Zyngier
2017-03-20 17:48 ` [PATCH v2 12/18] arm64: arch_timer: Make workaround methods optional Marc Zyngier
2017-03-20 17:48 ` [PATCH v2 13/18] arm64: arch_timer: Allows a CPU-specific erratum to only affect a subset of CPUs Marc Zyngier
2017-03-20 17:48 ` [PATCH v2 14/18] arm64: arch_timer: Move clocksource_counter and co around Marc Zyngier
2017-03-20 17:48 ` [PATCH v2 15/18] arm64: arch_timer: Enable CNTVCT_EL0 trap if workaround is enabled Marc Zyngier
2017-03-20 17:48 ` [PATCH v2 16/18] arm64: arch_timer: Workaround for Cortex-A73 erratum 858921 Marc Zyngier
2017-03-20 17:48 ` [PATCH v2 17/18] arm64: arch_timer: Allow erratum matching with ACPI OEM information Marc Zyngier
2017-03-20 17:48 ` [PATCH v2 18/18] arm64: arch_timer: Add HISILICON_ERRATUM_161010101 ACPI matching data Marc Zyngier
2017-03-22 13:56 ` [PATCH v2 00/18] clocksource/arch_timer: Errata workaround infrastructure rework Ding Tianhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b40e0cc7-5580-a834-babe-0dfa8427629e@arm.com \
--to=marc.zyngier@arm.com \
--cc=catalin.marinas@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=dann.frazier@canonical.com \
--cc=dingtianhong@huawei.com \
--cc=hanjun.guo@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=oss@buserror.net \
--cc=seth.forshee@canonical.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).