From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Yassine Oudjana <y.oudjana@protonmail.com>,
Andy Gross <agross@kernel.org>
Cc: Alec Su <ae40515@yahoo.com.tw>,
bjorn.andersson@linaro.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, sboyd@codeaurora.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] arm64: dts: qcom: msm8996-xiaomi-natrium: Add support for Xiaomi Mi 5s Plus
Date: Thu, 19 May 2022 12:06:53 +0200 [thread overview]
Message-ID: <b459bbd2-26c6-1af1-b1ee-d4cf5f49cdaa@linaro.org> (raw)
In-Reply-To: <3bb95350-01cc-b15b-3589-16019e3e9105@linaro.org>
On 19/05/2022 12:01, Krzysztof Kozlowski wrote:
> On 19/05/2022 11:57, Yassine Oudjana wrote:
>>>
>>> There is no such property documented. Either add bindings, or drop.
>>>
>>>> + qcom,board-id = <47 0>;
>>>
>>>
>>> The same.
>>
>> These properties are already used in many device trees; they are
>> needed to let the bootloader pick a DTB, but yes they aren't
>> documented currently. devicetree/bindings/arm/qcom.yaml would
>> probably be a good place to put them.
>
> Which means each person is using them and not caring about
> documenting... they need to be documented. I am not even sure if they
> should be accepted.
>
> The DTS describes hardware, not bootloader specific details. The
> hardware - board - is defined by compatible and bootloader should use
> it. Adding new properties because someone decided "I don't like
> compatibles" is not appropriate.
There is prior art:
https://lkml.org/lkml/2015/10/26/651
https://lore.kernel.org/all/CAL_JsqJAOEvs08Jydn9wWtM7-Oxd=MmmDER48VRF7z3Gkzt0CQ@mail.gmail.com/
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-05-19 10:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220519074112.25600-1-ae40515.ref@yahoo.com.tw>
2022-05-19 7:41 ` [PATCH 0/2] Add support for Xiaomi Mi 5s Plus Alec Su
2022-05-19 7:41 ` [PATCH 1/2] arm64: dts: qcom: msm8996-xiaomi-natrium: " Alec Su
2022-05-19 9:42 ` Krzysztof Kozlowski
2022-05-19 9:57 ` Yassine Oudjana
2022-05-19 10:01 ` Krzysztof Kozlowski
2022-05-19 10:06 ` Krzysztof Kozlowski [this message]
2022-05-19 10:36 ` Krzysztof Kozlowski
2022-05-20 1:34 ` kernel test robot
2022-05-25 2:32 ` Alec Su
2022-05-19 7:41 ` [PATCH 2/2] dt-bindings: arm: qcom: Document xiaomi,natrium board Alec Su
2022-05-19 9:36 ` Krzysztof Kozlowski
2022-05-19 13:05 ` Rob Herring
2022-05-20 1:23 ` Alec Su
2022-05-20 11:54 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b459bbd2-26c6-1af1-b1ee-d4cf5f49cdaa@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=ae40515@yahoo.com.tw \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=y.oudjana@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).