From: Jia-Ju Bai <baijiaju1990@163.com>
To: aviad.krawczyk@huawei.com
Cc: netdev <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [BUG] net: huawei: hinic: a possible sleep-in-atomic-context bug in hinic_get_stats64
Date: Fri, 11 Jan 2019 10:11:56 +0800 [thread overview]
Message-ID: <b45e662b-b50f-a23b-a123-e1454daf20ed@163.com> (raw)
In-Reply-To: <e69f8fe7-6bb9-56b4-7053-9766b3a0f3da@gmail.com>
The driver may sleep while holding a RCU lock.
The function call path (from bottom to top) in Linux-4.17 is:
[FUNC] down
drivers/net/.../hinic/hinic_main.c, 775: down in hinic_get_stats64
net/core/dev.c, 8278: [FUNC_PTR]hinic_get_stats64 in dev_get_stats
net/core/net-sysfs.c, 568: dev_get_stats in netstat_show
net/core/net-sysfs.c, 565: _raw_read_lock in netstat_show
Note that [FUNC_PTR] means a function pointer call.
This bug is found by my static analysis tool (DSAC-2) and checked by my
manual code review.
I do not know how to correctly fix this bug, so I just report it.
A possible way may be to replace up() and down()
with spin_lock() and spin_unlock().
Best wishes,
Jia-Ju Bai
next parent reply other threads:[~2019-01-11 2:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <e69f8fe7-6bb9-56b4-7053-9766b3a0f3da@gmail.com>
2019-01-11 2:11 ` Jia-Ju Bai [this message]
2019-01-11 2:18 ` [BUG] net: huawei: hinic: a possible sleep-in-atomic-context bug in hinic_get_stats64 Jia-Ju Bai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b45e662b-b50f-a23b-a123-e1454daf20ed@163.com \
--to=baijiaju1990@163.com \
--cc=aviad.krawczyk@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).