From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751424AbcGPBJl (ORCPT ); Fri, 15 Jul 2016 21:09:41 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:40994 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751054AbcGPBJi (ORCPT ); Fri, 15 Jul 2016 21:09:38 -0400 Subject: Re: [PATCH V9 6/9] vfio: platform: call _RST method when using ACPI To: Alex Williamson References: <1468461995-32676-1-git-send-email-okaya@codeaurora.org> <1468461995-32676-7-git-send-email-okaya@codeaurora.org> <20160714160439.5bafca73@t450s.home> Cc: kvm@vger.kernel.org, timur@codeaurora.org, cov@codeaurora.org, jcm@redhat.com, eric.auger@redhat.com, linux-acpi@vger.kernel.org, agross@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Baptiste Reynal , linux-kernel@vger.kernel.org From: Sinan Kaya Message-ID: Date: Fri, 15 Jul 2016 21:09:33 -0400 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <20160714160439.5bafca73@t450s.home> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/14/2016 6:04 PM, Alex Williamson wrote: >> +static inline >> > +bool vfio_platform_acpi_has_reset(struct vfio_platform_device *vdev) >> > +{ >> > +#ifdef CONFIG_ACPI >> > + struct device *dev = vdev->device; >> > + acpi_handle handle = ACPI_HANDLE(dev); >> > + >> > + return acpi_has_method(handle, "_RST"); >> > +#else >> > + return false; >> > +#endif >> > +} > What exactly is the rationale for making these inline? Clearly reset > is not a performance relevant path. Thanks, > > Alex > It is remaining from the previous stub functions which were inline. I'll get rid of the inlines. -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.