From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Jiri Slaby <jslaby@suse.cz>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-serial <linux-serial@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/4] tty: serial: extend lqasc_tx_ready() to lqasc_console_putchar()
Date: Tue, 27 Sep 2022 14:47:37 +0300 (EEST) [thread overview]
Message-ID: <b46d3edd-adb8-c91a-c1-a2cfe39205f@linux.intel.com> (raw)
In-Reply-To: <20220927111819.18516-1-jslaby@suse.cz>
[-- Attachment #1: Type: text/plain, Size: 1119 bytes --]
On Tue, 27 Sep 2022, Jiri Slaby wrote:
> There is one more place where lqasc_tx_ready() can be used now:
> lqasc_console_putchar(). So replace the open-coded variant by the
> helper.
>
> Suggested-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---
> drivers/tty/serial/lantiq.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/tty/serial/lantiq.c b/drivers/tty/serial/lantiq.c
> index 6da1b7496c6c..ba9739af30ed 100644
> --- a/drivers/tty/serial/lantiq.c
> +++ b/drivers/tty/serial/lantiq.c
> @@ -606,15 +606,12 @@ static const struct uart_ops lqasc_pops = {
> static void
> lqasc_console_putchar(struct uart_port *port, unsigned char ch)
> {
> - int fifofree;
> -
> if (!port->membase)
> return;
>
> - do {
> - fifofree = (__raw_readl(port->membase + LTQ_ASC_FSTAT)
> - & ASCFSTAT_TXFREEMASK) >> ASCFSTAT_TXFREEOFF;
> - } while (fifofree == 0);
> + while (!lqasc_tx_ready(port))
> + ;
> +
> writeb(ch, port->membase + LTQ_ASC_TBUF);
> }
>
>
prev parent reply other threads:[~2022-09-27 11:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 11:18 [PATCH 1/4] tty: serial: extend lqasc_tx_ready() to lqasc_console_putchar() Jiri Slaby
2022-09-27 11:18 ` [PATCH 2/4] tty: serial: use FIELD_GET() in lqasc_tx_ready() Jiri Slaby
2022-09-27 11:48 ` Ilpo Järvinen
2022-09-27 11:18 ` [PATCH 3/4] tty: serial: unify TX space reads under altera_jtaguart_tx_space() Jiri Slaby
2022-09-27 15:04 ` Tobias Klauser
2022-09-28 10:26 ` Ilpo Järvinen
2022-09-27 11:18 ` [PATCH 4/4] tty: serial: do unlock on a common path in altera_jtaguart_console_putc() Jiri Slaby
2022-09-27 14:59 ` Tobias Klauser
2022-09-28 10:27 ` Ilpo Järvinen
2022-09-27 11:47 ` Ilpo Järvinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b46d3edd-adb8-c91a-c1-a2cfe39205f@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).