From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFB3DC47423 for ; Thu, 1 Oct 2020 17:31:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 87CC220897 for ; Thu, 1 Oct 2020 17:31:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732957AbgJARbY (ORCPT ); Thu, 1 Oct 2020 13:31:24 -0400 Received: from mx2.suse.de ([195.135.220.15]:55638 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732407AbgJARbY (ORCPT ); Thu, 1 Oct 2020 13:31:24 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 548E3B224; Thu, 1 Oct 2020 17:31:22 +0000 (UTC) Message-ID: Subject: Re: [PATCH 1/4] of/fdt: Update zone_dma_bits when running in bcm2711 From: Nicolas Saenz Julienne To: Catalin Marinas , Rob Herring Cc: devicetree@vger.kernel.org, will@kernel.org, Frank Rowand , linux-kernel@vger.kernel.org, linux-mm@kvack.org, iommu@lists.linux-foundation.org, robh+dt@kernel.org, linux-rpi-kernel@lists.infradead.org, robin.murphy@arm.com, hch@lst.de, linux-arm-kernel@lists.infradead.org Date: Thu, 01 Oct 2020 19:31:19 +0200 In-Reply-To: <20201001172320.GQ21544@gaia> References: <20201001161740.29064-1-nsaenzjulienne@suse.de> <20201001161740.29064-2-nsaenzjulienne@suse.de> <20201001171500.GN21544@gaia> <20201001172320.GQ21544@gaia> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-seD6uijt62oXdXYvdJ0h" User-Agent: Evolution 3.36.5 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-seD6uijt62oXdXYvdJ0h Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2020-10-01 at 18:23 +0100, Catalin Marinas wrote: > On Thu, Oct 01, 2020 at 06:15:01PM +0100, Catalin Marinas wrote: > > Hi Nicolas, > >=20 > > Thanks for putting this together. > >=20 > > On Thu, Oct 01, 2020 at 06:17:37PM +0200, Nicolas Saenz Julienne wrote: > > > diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c > > > index 4602e467ca8b..cd0d115ef329 100644 > > > --- a/drivers/of/fdt.c > > > +++ b/drivers/of/fdt.c > > > @@ -25,6 +25,7 @@ > > > #include > > > #include > > > #include > > > +#include /* for zone_dma_bits */ > > > =20 > > > #include /* for COMMAND_LINE_SIZE */ > > > #include > > > @@ -1198,6 +1199,14 @@ void __init early_init_dt_scan_nodes(void) > > > of_scan_flat_dt(early_init_dt_scan_memory, NULL); > > > } > > > =20 > > > +void __init early_init_dt_update_zone_dma_bits(void) > > > +{ > > > + unsigned long dt_root =3D of_get_flat_dt_root(); > > > + > > > + if (of_flat_dt_is_compatible(dt_root, "brcm,bcm2711")) > > > + zone_dma_bits =3D 30; > > > +} > >=20 > > I think we could keep this entirely in the arm64 setup_machine_fdt() an= d > > not pollute the core code with RPi4-specific code. >=20 > Actually, even better, could we not move the check to > arm64_memblock_init() when we initialise zone_dma_bits? I did it this way as I vaguely remembered Rob saying he wanted to centralis= e all early boot fdt code in one place. But I'll be happy to move it there. Regards, Nicolas --=-seD6uijt62oXdXYvdJ0h Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEErOkkGDHCg2EbPcGjlfZmHno8x/4FAl92EmcACgkQlfZmHno8 x/650wf7BuG9OAXrpcJx+slOiIpUn27A9VP5PUiZhylbJPYElYlFJCs1q9tLFNHw 2xXUtjY3QDdSH9GtDY1utSkQ2VeyqLRsDeVMkiwV721Gtn3y9veD2tNiJb4WXtet C9us1mhEFgpu691D6JilmlxSxjfCOHZYGmZXGpTOPOSu12/YQlHCYc33cRKkDbfn G5H0tNc4gXkWwJh5OSZixd08Ek7+d4HzG8hpZB5ifDWYLY7ZTDWC27mF1xYWGwAE d7WUXSQ11UaAQBl5maIqrL3X19tg/GsdidU3yrsjIBtBEFaulKmVtggI33JTfgoo v517kqitPiAV14ZYWJoifJK6ZppdiQ== =E6vz -----END PGP SIGNATURE----- --=-seD6uijt62oXdXYvdJ0h--