From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Jordy Zomer <jordy@pwning.systems>
Cc: kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v3] nfc: st21nfca: Fix potential buffer overflows in EVT_TRANSACTION
Date: Wed, 12 Jan 2022 11:07:34 +0100 [thread overview]
Message-ID: <b47eba60-9d02-2901-2759-b2230087193c@canonical.com> (raw)
In-Reply-To: <20220111164451.3232987-1-jordy@pwning.systems>
On 11/01/2022 17:44, Jordy Zomer wrote:
> It appears that there are some buffer overflows in EVT_TRANSACTION.
> This happens because the length parameters that are passed to memcpy
> come directly from skb->data and are not guarded in any way.
>
> Signed-off-by: Jordy Zomer <jordy@pwning.systems>
> ---
> drivers/nfc/st21nfca/se.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
Looks ok.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-01-12 10:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-17 17:17 [PATCH] nfc: st21nfca: Fix potential buffer overflows in EVT_TRANSACTION Jordy Zomer
2021-11-18 7:04 ` [PATCH v2] " Jordy Zomer
2021-11-18 7:40 ` Krzysztof Kozlowski
2022-01-11 16:44 ` [PATCH v3] " Jordy Zomer
2022-01-12 10:07 ` Krzysztof Kozlowski [this message]
2022-01-12 17:25 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b47eba60-9d02-2901-2759-b2230087193c@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=jordy@pwning.systems \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).