From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D00F8C10DCE for ; Fri, 6 Mar 2020 14:50:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A4B8E2073B for ; Fri, 6 Mar 2020 14:50:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=arista.com header.i=@arista.com header.b="Wc1YnfGD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726897AbgCFOuz (ORCPT ); Fri, 6 Mar 2020 09:50:55 -0500 Received: from mail-wr1-f68.google.com ([209.85.221.68]:40952 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726054AbgCFOuz (ORCPT ); Fri, 6 Mar 2020 09:50:55 -0500 Received: by mail-wr1-f68.google.com with SMTP id p2so1880187wrw.7 for ; Fri, 06 Mar 2020 06:50:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arista.com; s=googlenew; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=rkdm0GhCO++/nQ4VT9YppiVp8lDUJySwc361AwdjYfU=; b=Wc1YnfGDuJ9VpbVek3V1X++yakDjHxIzXn6x9UaX8t9KQN5bruqPFDsJFxxRpmGdto PlpnXAJSyWQTTc9vbjG7mdbpNC4peXoX0SuzM/koRM06/LABtjG+woAvfHvExApjKrkc bsarCq+sFlB/Ho+Oeug6JM21WEjDEiiMpHawME+FcWdjDi0KrnG3CxTQPV92tirKsDW5 aEH588YAOFRYaQ0HgCRdTlN5QcMJ5OAQsVM6PSOZdSOQKbXcAPCrH93Pn5Z7vfZCd9mT 0ccvu3XDH9Cc/HFXqiVrFxBSJv//J1DUA99WtPPom0kIHqkZSyffYCrbwZ1cyt51IqMA a/4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=rkdm0GhCO++/nQ4VT9YppiVp8lDUJySwc361AwdjYfU=; b=okej4jy5Zo6XEG5BqtINsvf4ejYhBj9or91vnTgppnqiBjlIKcSqsz4bdRudiPeKCB M9SiPMN5i6NqMTvTzK30Ydv/4eJoU6FxWa/vtSgiIoPzwbJqwH9PytuBn66gBTfNO8a9 01+e5J4///szodmAq+swe09/qRPKzKLGkb7lblGgrHfaWCGIstlSvZZ+w3YlpXi0g7Gw zxN+TkfedxtaXz2gsOXkFhosFG0Sg9JW+Jd8XhYvXLfdpk0GPrU0hOO8dsRFhM7Yc47p Aa5jfwtc+BcgFBbmVywOuLpPFXf2tbEPffXPi4vCpVSGoAZHXCJzN03WiZ1Tcu++9FY2 bf5A== X-Gm-Message-State: ANhLgQ3qE69VpUZK8QPtRK4dVYP0qUgO4Iyl8a+Tuzl6H/139mSyjsjp YELUFH9J/2uFG5BuClDKdbMFVA== X-Google-Smtp-Source: ADFU+vsa1D0obuQITxRQ/CMVVhL4xz90VRuA7ecM53JXflQonfIFp6f1Tdy6OrQkndLmgc9FUWNBdQ== X-Received: by 2002:a5d:6284:: with SMTP id k4mr4553618wru.398.1583506253020; Fri, 06 Mar 2020 06:50:53 -0800 (PST) Received: from [10.83.36.153] ([217.173.96.166]) by smtp.gmail.com with ESMTPSA id f127sm14302305wma.4.2020.03.06.06.50.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Mar 2020 06:50:52 -0800 (PST) Subject: Re: [PATCHv3 2/2] serial/sysrq: Add MAGIC_SYSRQ_SERIAL_SEQUENCE To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, Dmitry Safonov <0x7f454c46@gmail.com>, Iurii Zaikin , Jiri Slaby , Joe Perches , Randy Dunlap , Vasiliy Khoruzhick , linux-serial@vger.kernel.org References: <20200302175135.269397-1-dima@arista.com> <20200302175135.269397-3-dima@arista.com> <20200306125531.GA3754466@kroah.com> From: Dmitry Safonov Message-ID: Date: Fri, 6 Mar 2020 14:50:51 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.2 MIME-Version: 1.0 In-Reply-To: <20200306125531.GA3754466@kroah.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/6/20 12:55 PM, Greg Kroah-Hartman wrote: > On Mon, Mar 02, 2020 at 05:51:35PM +0000, Dmitry Safonov wrote: >> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug >> index 69def4a9df00..38a8f3c99579 100644 >> --- a/lib/Kconfig.debug >> +++ b/lib/Kconfig.debug >> @@ -431,6 +431,14 @@ config MAGIC_SYSRQ_SERIAL >> This option allows you to decide whether you want to enable the >> magic SysRq key. >> >> +config MAGIC_SYSRQ_SERIAL_SEQUENCE >> + string "Char sequence that enables magic SysRq over serial" >> + depends on MAGIC_SYSRQ_SERIAL >> + default "" >> + help >> + Specifies a sequence of characters that can follow BREAK to enable >> + SysRq on a serial console. > > > Can you send a follow-on patch that adds some more text here. Something > like : > If you do not know what to do, just select an empty string and > the option will not be enabled. > > or something like that to make it more obvious what almost everyone will > want to do here. Oh yes, makes sense, will send a patch. Thanks, Dmitry