From: Matthias Brugger <matthias.bgg@gmail.com>
To: Balsam CHIHI <bchihi@baylibre.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: daniel.lezcano@linaro.org,
angelogioacchino.delregno@collabora.com, rafael@kernel.org,
amitk@kernel.org, rui.zhang@intel.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, rdunlap@infradead.org,
ye.xingchen@zte.com.cn, p.zabel@pengutronix.de,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org,
khilman@baylibre.com, james.lo@mediatek.com,
rex-bc.chen@mediatek.com
Subject: Re: [PATCH v12 2/6] dt-bindings: thermal: mediatek: Add LVTS thermal controllers dt-binding definition
Date: Mon, 30 Jan 2023 12:18:51 +0100 [thread overview]
Message-ID: <b4bec164-5986-718e-b9cc-290dfc995edb@gmail.com> (raw)
In-Reply-To: <CAGuA+opQboxH8qoNv4GG+raX=ZZAyRVLC9VLjVCzbT_cUQWWTA@mail.gmail.com>
On 30/01/2023 11:40, Balsam CHIHI wrote:
> Hi Krzysztof,
>
> Thank you for the feedback.
>
> On Sat, Jan 28, 2023 at 11:48 AM Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> On 26/01/2023 17:10, bchihi@baylibre.com wrote:
>>> From: Balsam CHIHI <bchihi@baylibre.com>
>>>
>>> Add LVTS thermal controllers dt-binding definition for mt8195.
>>
>> Subject: drop second/last, redundant "dt-binding definition". The
>> "dt-bindings" prefix is already stating that these are bindings.
>
> fixed.
> The patch title has been fixed as you suggested :
> "dt-bindings: thermal: mediatek: Add LVTS thermal controllers"
>
>>
>> Plus two comments at the end.
>>
>>>
>>> Signed-off-by: Balsam CHIHI <bchihi@baylibre.com>
>>> ---
>>> Changelog:
>>> v12:
>>> - Fixed subject prefix
>>> - Fixed licences GPL-2.0+ to GPL-2.0
>>> - Added dual licenses
>>
>>
>>> + };
>>> diff --git a/include/dt-bindings/thermal/mediatek-lvts.h b/include/dt-bindings/thermal/mediatek-lvts.h
>>> new file mode 100644
>>> index 000000000000..902d5b1e4f43
>>> --- /dev/null
>>> +++ b/include/dt-bindings/thermal/mediatek-lvts.h
>>
>> Same filename as bindings.
>
> fixed.
> rename :
> include/dt-bindings/thermal/mediatek-lvts.h =>
> include/dt-bindings/thermal/mediatek-lvts-thermal.h
>
I think it should be
include/dt-bindings/thermal/mediatek,lvts-thermal.yaml
Regards,
Matthias
>>
>>> @@ -0,0 +1,19 @@
>>> +/* SPDX-License-Identifier: (GPL-2.0 or MIT) */
>>
>> Although this is correct, any reason why not using exactly the same
>> license as bindings?
>
> fixed.
> both files are now using the same license :
> "SPDX-License-Identifier: (GPL-2.0 or MIT)"
>
>>
>>> +/*
>>> + * Copyright (c) 2023 MediaTek Inc.
>>> + * Author: Balsam CHIHI <bchihi@baylibre.com>
>>> + */
>>
>> Best regards,
>> Krzysztof
>>
>
> I'll send the changes soon.
>
> Best regards,
> Balsam
next prev parent reply other threads:[~2023-01-30 11:19 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-24 13:17 [PATCH v11 0/6] Add LVTS thermal architecture bchihi
2023-01-24 13:17 ` [PATCH v11 1/6] thermal/drivers/mediatek: Relocate driver to mediatek folder bchihi
2023-01-24 15:37 ` AngeloGioacchino Del Regno
2023-01-25 15:02 ` Balsam CHIHI
2023-01-24 13:17 ` [PATCH v11 2/6] dt-bindings/thermal/mediatek: Add LVTS thermal controllers dt-binding definition bchihi
2023-01-25 11:14 ` Daniel Lezcano
2023-01-25 20:35 ` Rob Herring
2023-01-25 21:13 ` Daniel Lezcano
2023-01-25 20:34 ` Rob Herring
2023-01-26 10:33 ` Balsam CHIHI
2023-01-26 16:10 ` [PATCH v12 2/6] dt-bindings: thermal: mediatek: " bchihi
2023-01-27 22:10 ` Daniel Lezcano
2023-01-28 10:50 ` Krzysztof Kozlowski
2023-01-30 10:49 ` Balsam CHIHI
2023-01-28 10:48 ` Krzysztof Kozlowski
2023-01-30 10:40 ` Balsam CHIHI
2023-01-30 11:18 ` Matthias Brugger [this message]
2023-01-30 12:19 ` Balsam CHIHI
2023-01-30 16:07 ` Matthias Brugger
2023-01-31 16:53 ` Krzysztof Kozlowski
2023-01-31 17:01 ` Daniel Lezcano
2023-01-31 14:04 ` [PATCH v3] dt-bindings: thermal: mediatek: Add LVTS thermal controllers bchihi
2023-02-01 7:46 ` Krzysztof Kozlowski
2023-02-01 13:34 ` Balsam CHIHI
2023-02-01 13:37 ` Krzysztof Kozlowski
2023-02-01 13:56 ` Balsam CHIHI
2023-03-07 13:42 ` [PATCH] thermal/drivers/mediatek/lvts_thermal: fix memcpy's number of bytes in lvts_calibration_init() bchihi
2023-03-08 9:10 ` AngeloGioacchino Del Regno
2023-03-09 12:37 ` Dan Carpenter
2023-01-24 13:17 ` [PATCH v11 3/6] arm64/dts/mt8195: Add efuse node to mt8195 bchihi
2023-01-25 14:25 ` Matthias Brugger
2023-01-25 15:04 ` Balsam CHIHI
2023-01-24 13:17 ` [PATCH v11 4/6] thermal/drivers/mediatek: Add the Low Voltage Thermal Sensor driver bchihi
2023-01-24 15:31 ` AngeloGioacchino Del Regno
2023-01-25 15:06 ` Balsam CHIHI
2023-01-31 15:38 ` [PATCH v12] thermal: drivers: mediatek: " bchihi
2023-02-01 3:09 ` kernel test robot
2023-02-01 7:47 ` Krzysztof Kozlowski
2023-02-01 15:14 ` Balsam CHIHI
2023-02-01 7:55 ` Krzysztof Kozlowski
2023-02-01 16:46 ` Balsam CHIHI
2023-02-01 16:59 ` Matthias Brugger
2023-02-03 10:35 ` Balsam CHIHI
2023-02-01 17:12 ` Krzysztof Kozlowski
2023-02-03 11:06 ` Balsam CHIHI
2023-02-06 14:07 ` Daniel Lezcano
2023-02-06 14:30 ` Krzysztof Kozlowski
2023-02-06 14:38 ` Daniel Lezcano
2023-02-06 14:32 ` Balsam CHIHI
2023-01-24 13:17 ` [PATCH v11 5/6] arm64/dts/mt8195: Add thermal zones and thermal nodes bchihi
2023-01-24 15:36 ` AngeloGioacchino Del Regno
2023-01-25 15:10 ` Balsam CHIHI
2023-01-25 19:09 ` Matthias Brugger
2023-01-26 9:43 ` Balsam CHIHI
2023-01-31 15:37 ` [PATCH v12] arm64: dts: mediatek: mt8195: " bchihi
2023-01-24 13:17 ` [PATCH v11 6/6] arm64/dts/mt8195: Add temperature mitigation threshold bchihi
2023-01-24 15:36 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4bec164-5986-718e-b9cc-290dfc995edb@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=amitk@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bchihi@baylibre.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=james.lo@mediatek.com \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=rafael@kernel.org \
--cc=rdunlap@infradead.org \
--cc=rex-bc.chen@mediatek.com \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=ye.xingchen@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).