From: "Jürgen Groß" <jgross@suse.com>
To: Ard Biesheuvel <ardb@kernel.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: xen-devel@lists.xenproject.org, linux-fbdev@vger.kernel.org,
dri-devel@lists.freedesktop.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Peter Jones <pjones@redhat.com>,
linux-efi <linux-efi@vger.kernel.org>
Subject: Re: [PATCH] efi: avoid error message when booting under Xen
Date: Fri, 10 Jul 2020 15:38:49 +0200 [thread overview]
Message-ID: <b4e60a2f-e761-d9ad-88ad-fe041109c063@suse.com> (raw)
In-Reply-To: <CAMj1kXGE52Y6QQhGLU6r_9x6TVftZqfS7zyLCiDusZhV4tbhjg@mail.gmail.com>
On 10.07.20 15:27, Ard Biesheuvel wrote:
> On Fri, 10 Jul 2020 at 13:17, Bartlomiej Zolnierkiewicz
> <b.zolnierkie@samsung.com> wrote:
>>
>>
>> [ added EFI Maintainer & ML to Cc: ]
>>
>> Hi,
>>
>> On 7/9/20 11:17 AM, Jürgen Groß wrote:
>>> On 28.06.20 10:50, Jürgen Groß wrote:
>>>> Ping?
>>>>
>>>> On 10.06.20 16:10, Juergen Gross wrote:
>>>>> efifb_probe() will issue an error message in case the kernel is booted
>>>>> as Xen dom0 from UEFI as EFI_MEMMAP won't be set in this case. Avoid
>>>>> that message by calling efi_mem_desc_lookup() only if EFI_PARAVIRT
>>>>> isn't set.
>>>>>
>
> Why not test for EFI_MEMMAP instead of EFI_BOOT?
Honestly I'm not sure EFI_BOOT is always set in that case. If you tell
me it is fine to just replace the test to check for EFI_MEMMAP I'm fine
to modify my patch.
Juergen
next prev parent reply other threads:[~2020-07-10 13:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-10 14:10 [PATCH] efi: avoid error message when booting under Xen Juergen Gross
2020-06-28 8:50 ` Jürgen Groß
2020-07-09 9:17 ` Jürgen Groß
2020-07-10 10:16 ` Bartlomiej Zolnierkiewicz
2020-07-10 13:27 ` Ard Biesheuvel
2020-07-10 13:38 ` Jürgen Groß [this message]
2020-07-10 13:41 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4e60a2f-e761-d9ad-88ad-fe041109c063@suse.com \
--to=jgross@suse.com \
--cc=ardb@kernel.org \
--cc=b.zolnierkie@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pjones@redhat.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).