From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 959F2C48BC2 for ; Wed, 23 Jun 2021 20:30:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6CE69611AD for ; Wed, 23 Jun 2021 20:30:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229881AbhFWUcU (ORCPT ); Wed, 23 Jun 2021 16:32:20 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:39337 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229688AbhFWUcS (ORCPT ); Wed, 23 Jun 2021 16:32:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624480200; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VaT9/cb+GLJShXE53czRupxUnvB/ruHdggf72qjOwGc=; b=eB6RUjvapw17OaFb6VDHVCD3qR4tIM91LFnEbLp8dJgknuQwfwvPWqXMJLC5+SSronZNbc GgufaSjKWnkOEcOQuzOBNncWZ/FEZZwgL+Z4yhewARuGzl/xexaKAj6C+8zyizh4OQB9x1 B0DL2I6Yq7Mf9e1ohyN4kcXdJEmQh5E= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-254-oNy0ln49P5muVkjOmBF8hQ-1; Wed, 23 Jun 2021 16:29:59 -0400 X-MC-Unique: oNy0ln49P5muVkjOmBF8hQ-1 Received: by mail-ej1-f71.google.com with SMTP id jw19-20020a17090776b3b0290481592f1fc4so1402999ejc.2 for ; Wed, 23 Jun 2021 13:29:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=VaT9/cb+GLJShXE53czRupxUnvB/ruHdggf72qjOwGc=; b=I0ewlNPL0VQdf4muhVVTgfX+vXFO0mPEGfBDVQnUMeeJgt465K03c+zguTkzsqQRJC BUQk82161gNB+C4cU/Zf96lrX/lCDLgT9kbFGchMf3AJvMD89Y4dgwMpzTude1RQrETy 2oM0F1pXQSZQ+kikGQ11cIDjIO0Vdi1Rw57EBa5lqOQ3zQzGQy3aj2YzNlXVpRohM9pP xVMVbJpldXgDgJAfACAIvUaVdyeFRQJ1fW7xWxueJ7g6SApgPK9xdGN+pAU1qf/St45z m1ksUCNF6+RY7CUbf1+MkxSiQYh/XR++so/qbWcVVdBvtaOnJ+V2wmHfKJmpykGgvLPJ UPUw== X-Gm-Message-State: AOAM532V6F18jpMdbe53GEkbQ7LcjYXKR2OCtEgBKpduGZ5395fKybd+ 8Q+MJrUrhyJXs4rbcsscgVguP2UC3zL9+AmjWxBtU+JG/r8NKmWfzGPBxIYwU73p6cnsnRTob7v Ya+NPgfgznTvEj4QeJa3lq03g X-Received: by 2002:a17:906:dbec:: with SMTP id yd12mr1844501ejb.102.1624480197621; Wed, 23 Jun 2021 13:29:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxbVkZAo20CvntkRy1oPrkGLwNKkE7NFRMzmN1lfBgKChqUpS9dwOA5oGXy4HDg3ys1SiWrJg== X-Received: by 2002:a17:906:dbec:: with SMTP id yd12mr1844483ejb.102.1624480197324; Wed, 23 Jun 2021 13:29:57 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id p19sm576655edr.73.2021.06.23.13.29.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Jun 2021 13:29:56 -0700 (PDT) Subject: Re: [PATCH 00/54] KVM: x86/mmu: Bug fixes and summer cleaning To: Sean Christopherson Cc: Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Yu Zhang , Maxim Levitsky References: <20210622175739.3610207-1-seanjc@google.com> From: Paolo Bonzini Message-ID: Date: Wed, 23 Jun 2021 22:29:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210622175739.3610207-1-seanjc@google.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/06/21 19:56, Sean Christopherson wrote: > Patch 01 is the only patch that is remotely 5.13 worthy, and even then > only because it's about as safe as a patch can be. Everything else is far > from urgent as these bugs have existed for quite some time. Maybe patch 54 (not sarcastic), but I agree it's not at all necessary. This is good stuff, I made a few comments but almost all of them (all except the last comment on patch 9, "Unconditionally zap unsync SPs") are cosmetic and I can resolve them myself. I'd like your input on renaming is_{cr0,cr4,efer}_* to is_mmu_* (and possibly reduce the four underscores to two...). If I get remarks by tomorrow, I'll get this into 5.14, otherwise consider everything but the first eight patches queued only for 5.15. > I labeled the "sections" of this mess in the shortlog below. > > P.S. Does anyone know how PKRU interacts with NPT? I assume/hope NPT > accesses, which are always "user", ignore PKRU, but the APM doesn't > say a thing. If PKRU is ignored, KVM has some fixing to do. If PKRU > isn't ignored, AMD has some fixing to do:-) > > P.S.S. This series pulled in one patch from my vCPU RESET/INIT series, > "Properly reset MMU context at vCPU RESET/INIT", as that was needed > to fix a root_level bug on VMX. My goal is to get the RESET/INIT > series refreshed later this week and thoroughly bombard everyone. Note that it won't get into 5.14 anyway, since I plan to send my first pull request to Linus as soon as Friday. Paolo