From: Hannes Reinecke <hare@suse.de>
To: Jens Axboe <axboe@kernel.dk>, Mike Snitzer <snitzer@redhat.com>,
Sergei Shtepa <sergei.shtepa@veeam.com>,
hch@lst.de
Cc: "johannes.thumshirn@wdc.com" <johannes.thumshirn@wdc.com>,
"koct9i@gmail.com" <koct9i@gmail.com>,
"ming.lei@redhat.com" <ming.lei@redhat.com>,
"josef@toxicpanda.com" <josef@toxicpanda.com>,
"steve@sk2.org" <steve@sk2.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Pavel Tide <Pavel.TIde@veeam.com>,
dm-devel@redhat.com
Subject: Re: [PATCH 0/3] block: blk_interposer - Block Layer Interposer
Date: Fri, 11 Dec 2020 19:03:36 +0100 [thread overview]
Message-ID: <b4f3ee74-58fd-52c8-ae60-f352758fb42a@suse.de> (raw)
In-Reply-To: <06b4a10d-5ea5-27e1-af0d-83d5c714996f@kernel.dk>
On 12/11/20 6:04 PM, Jens Axboe wrote:
> On 12/11/20 9:56 AM, Hannes Reinecke wrote:
>> On 12/11/20 5:33 PM, Jens Axboe wrote:
>>> On 12/11/20 9:30 AM, Mike Snitzer wrote:
>>>> While I still think there needs to be a proper _upstream_ consumer of
>>>> blk_interposer as a condition of it going in.. I'll let others make the
>>>> call.
>>>
>>> That's an unequivocal rule.
>>>
>>>> As such, I'll defer to Jens, Christoph and others on whether your
>>>> minimalist blk_interposer hook is acceptable in the near-term.
>>>
>>> I don't think so, we don't do short term bandaids just to plan on
>>> ripping that out when the real functionality is there. IMHO, the dm
>>> approach is the way to go - it provides exactly the functionality that
>>> is needed in an appropriate way, instead of hacking some "interposer"
>>> into the core block layer.
>>>
>> Which is my plan, too.
>>
>> I'll be working with the Veeam folks to present a joint patchset
>> (including the DM bits) for the next round.
>
> Just to be clear, core block additions for something that dm will
> consume is obviously fine. Adding this as block layer functionality than
> then exposes an application API for setting it up, tearing down, etc -
> that is definitely NOT
>
That was never my intention.
Any consumers of this thing would need to be in-kernel.
If that was your concern.
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
next prev parent reply other threads:[~2020-12-11 19:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 13:01 [PATCH 0/3] block: blk_interposer - Block Layer Interposer Sergei Shtepa
2020-12-09 13:01 ` [PATCH 1/3] " Sergei Shtepa
2020-12-09 13:01 ` [PATCH 2/3] block: blk_interposer - sample Sergei Shtepa
2020-12-09 14:36 ` Mike Snitzer
2020-12-10 15:54 ` Sergei Shtepa
2020-12-10 15:58 ` Mike Snitzer
2020-12-09 13:01 ` [PATCH 3/3] block: blk_interposer - sample config Sergei Shtepa
2020-12-09 13:51 ` [PATCH 0/3] block: blk_interposer - Block Layer Interposer Mike Snitzer
2020-12-10 14:58 ` Sergei Shtepa
2020-12-10 16:32 ` Mike Snitzer
2020-12-11 16:30 ` Mike Snitzer
2020-12-11 16:33 ` Jens Axboe
2020-12-11 16:56 ` Hannes Reinecke
2020-12-11 17:04 ` Jens Axboe
2020-12-11 18:03 ` Hannes Reinecke [this message]
2020-12-12 18:14 ` Jens Axboe
2020-12-15 6:51 ` Bob Liu
2020-12-15 7:41 ` Hannes Reinecke
2020-12-15 15:57 ` Sergei Shtepa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4f3ee74-58fd-52c8-ae60-f352758fb42a@suse.de \
--to=hare@suse.de \
--cc=Pavel.TIde@veeam.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=hch@lst.de \
--cc=johannes.thumshirn@wdc.com \
--cc=josef@toxicpanda.com \
--cc=koct9i@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=sergei.shtepa@veeam.com \
--cc=snitzer@redhat.com \
--cc=steve@sk2.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).