From: Florian Fainelli <f.fainelli@gmail.com>
To: Sudeep Holla <sudeep.holla@arm.com>,
Jim Quinlan <james.quinlan@broadcom.com>
Cc: bcm-kernel-feedback-list@broadcom.com,
Jassi Brar <jassisinghbrar@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
open list <linux-kernel@vger.kernel.org>,
"moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 2/2] mailbox: Add Broadcom STB mailbox driver
Date: Fri, 9 Oct 2020 10:03:27 -0700 [thread overview]
Message-ID: <b4f88367-ff8b-08cb-16b3-7432aa6b3117@gmail.com> (raw)
In-Reply-To: <20201009163848.5tbl5bmvuoj2de2v@bogus>
On 10/9/2020 9:38 AM, Sudeep Holla wrote:
> On Sat, Sep 19, 2020 at 03:22:30PM -0400, Jim Quinlan wrote:
>> only implements the agent-to-platform channel;
>
> In that case any reason why you can't reuse the existing smc transport
> for SCMI. It was added recently in case you haven't checked the latest
> kernel version(v5.8 or above). Check out for drivers/firmware/arm_scmi/smc.c
> IIUC rather vaguely Florian was cc-ed on those patches.
Our firmware completes all commands by posting an interrupt and we
already have platforms in the field with this mailbox driver. I was
hoping we could make use of the SMC transport, but the current firmware
implementation completes commands by raising an interrupt. The reason
why we did that was that we could support synchronous and asynchronous
calls the same way.
>
>> we may implement the platform-to-agent channel in the future.
>
> This is not yet support with that transport, it is hard to generalise
> as different vendors have their own solutions there.
>
>> An unusual aspect of this driver is how the completion of an SCMI message
>> is indicated. An SCMI message is initiated with an ARM SMC call, but the
>> return of this call does not indicate the execution or completion of the
>> message. Rather, the message's completion is signaled by an interrupt.
>>
>
> So are these not fast SMC/HVC calls then ? If so we may need some changes
> to that driver. I just rejected multiple message support as we had assumed
> fast smc/hvc.
>
--
Florian
next prev parent reply other threads:[~2020-10-09 17:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-19 19:22 [PATCH v3 0/2] mailbox: Add Broadcom STB mailbox driver Jim Quinlan
2020-09-19 19:22 ` [PATCH v3 1/2] dt-bindings: Add bindings for BrcmSTB SCMI " Jim Quinlan
2020-09-19 19:22 ` [PATCH v3 2/2] mailbox: Add Broadcom STB " Jim Quinlan
2020-09-19 19:31 ` Randy Dunlap
2020-09-19 21:04 ` Jim Quinlan
2020-10-09 16:38 ` Sudeep Holla
2020-10-09 17:03 ` Florian Fainelli [this message]
2020-10-21 21:38 ` Jim Quinlan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4f88367-ff8b-08cb-16b3-7432aa6b3117@gmail.com \
--to=f.fainelli@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=james.quinlan@broadcom.com \
--cc=jassisinghbrar@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).