From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932187AbcKLWGG (ORCPT <rfc822;w@1wt.eu>);
        Sat, 12 Nov 2016 17:06:06 -0500
Received: from aibo.runbox.com ([91.220.196.211]:49418 "EHLO aibo.runbox.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750825AbcKLWGF (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 12 Nov 2016 17:06:05 -0500
From: "M. Vefa Bicakci" <m.v.b@runbox.com>
Subject: Re: [PATCH] x86/cpuid: Deal with broken firmware once more
To: "Charles (Chas) Williams" <ciwillia@brocade.com>
References: <20161102122557.qs4rl6mb7n7l7j7p@linutronix.de>
 <24e69019-60d0-29e7-e31f-c6f00f9ed98a@brocade.com>
 <alpine.DEB.2.20.1611071717000.3709@nanos>
 <58e229e2-91f4-a97f-1b9f-089f48ef994a@brocade.com>
 <alpine.DEB.2.20.1611072117040.3501@nanos>
 <e3a6f9cb-ee46-6e5c-7b2e-9a6ed2fc949e@brocade.com>
 <alpine.DEB.2.20.1611081525160.3501@nanos>
 <86609338-2b45-ed7e-fb07-99421e43a2f1@brocade.com>
 <alpine.DEB.2.20.1611081721330.3501@nanos>
 <alpine.DEB.2.20.1611091613540.3501@nanos>
 <49fe8cc5-0f0f-6cac-7a5c-803e81f5667d@runbox.com>
 <a5f579c2-3a2d-3cce-cf3e-d68b91bb2d73@brocade.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        "x86@kernel.org" <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
        Peter Zijlstra <peterz@infradead.org>, Borislav Petkov <bp@alien8.de>
Message-ID: <b52a7e1a-0357-758e-e68a-e4d2ed186bea@runbox.com>
Date: Sun, 13 Nov 2016 01:05:11 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <a5f579c2-3a2d-3cce-cf3e-d68b91bb2d73@brocade.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/10/2016 01:50 PM, Charles (Chas) Williams wrote:
> 
> 
> On 11/09/2016 10:57 PM, M. Vefa Bicakci wrote:
>> [    0.002000] mvb: CPU: Physical Processor ID: 0
>> [    0.002000] mvb: CPU: Processor Core ID: 0
>> [    0.002000] mvb: identify_cpu:1112: c: ffff880013b0a040,
>> c->logical_proc_id: 65535
>> [    0.002000] mvb: __default_cpu_present_to_apicid:612: Returning
>> 65535! mps_cpu: 1, nr_cpu_ids: 2, cpu_present(mps_cpu): 1
>> [    0.002000] smpboot: mvb: topology_update_package_map:270: cpu: 1,
>> pkg: 4095
>> [    0.002000] smpboot: APIC(ffff) Converting physical 4095 to logical
>> package 0
>> [    0.002000] smpboot: mvb: topology_update_package_map:305: cpu: 1,
>> cpu_data(cpu).logical_proc_id: 0
> 
> This seems strange.  0xffff is BAD_APICID.  Why didn't this fail here:
> 
>         for_each_present_cpu(cpu) {
>                 unsigned int apicid = apic->cpu_present_to_apicid(cpu);
> 
>                 if (apicid == BAD_APICID ||
> !apic->apic_id_valid(apicid))  <<<<<<<<<<
>                         continue;
>                 if (!topology_update_package_map(apicid, cpu))
>                         continue;
> 
> topology_update_package_map() should never have been called?

(Sorry for the delay!)

It appears that this is a different call path than the one in
smp_init_package_map function. I *think* the following call path is the
one shown in the dmesg, but I am not sure:

cpu_bringup_and_idle
  cpu_bringup (arch/x86/xen/smp.c)
    smp_store_cpu_info (this call path branch is included for context)
      identify_secondary_cpu
        identify_cpu
          detect_ht
    topology_update_package_map

Sorry about the potentially misleading dmesg excerpt I posted.

Vefa