From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80A2AC43387 for ; Thu, 3 Jan 2019 14:50:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4920C217D9 for ; Thu, 3 Jan 2019 14:50:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727601AbfACOux (ORCPT ); Thu, 3 Jan 2019 09:50:53 -0500 Received: from mga11.intel.com ([192.55.52.93]:53790 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726044AbfACOux (ORCPT ); Thu, 3 Jan 2019 09:50:53 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Jan 2019 06:50:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,435,1539673200"; d="scan'208";a="307183751" Received: from ahunter-desktop.fi.intel.com (HELO [10.237.72.56]) ([10.237.72.56]) by fmsmga006.fm.intel.com with ESMTP; 03 Jan 2019 06:50:48 -0800 Subject: Re: [PATCH v5 09/11] mmc: sdhci-acpi: Make PCI dependency explicit To: Sinan Kaya , linux-next@vger.kernel.org Cc: linux-acpi@vger.kernel.org, Ulf Hansson , Shawn Lin , Faiz Abbas , Masahiro Yamada , Geert Uytterhoeven , Chunyan Zhang , Jisheng Zhang , Ludovic Barre , Arnd Bergmann , Alex Smith , Chris Brandt , "open list:MULTIMEDIA CARD (MMC), SECURE DIGITAL (SD) AND..." , open list References: <20190102181038.4418-1-okaya@kernel.org> <20190102181038.4418-10-okaya@kernel.org> From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: Date: Thu, 3 Jan 2019 16:49:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190102181038.4418-10-okaya@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/01/19 8:10 PM, Sinan Kaya wrote: > After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without > CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were > satisfied implicitly through dependencies on CONFIG_ACPI have to be > specified directly. This driver relies on IOSF_MBI and IOSF_MBI depends > on PCI. For this reason, add a direct dependency to CONFIG_PCI here. This driver does not rely on IOSF_MBI You wrote on the other email QCOM doesn't use PCI but here you are making them depend on it. Please explain. > > Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set") > Signed-off-by: Sinan Kaya > --- > drivers/mmc/host/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig > index e26b8145efb3..1b9401fe94c0 100644 > --- a/drivers/mmc/host/Kconfig > +++ b/drivers/mmc/host/Kconfig > @@ -116,7 +116,7 @@ config MMC_RICOH_MMC > > config MMC_SDHCI_ACPI > tristate "SDHCI support for ACPI enumerated SDHCI controllers" > - depends on MMC_SDHCI && ACPI > + depends on MMC_SDHCI && ACPI && PCI > select IOSF_MBI if X86 > help > This selects support for ACPI enumerated SDHCI controllers, >