From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754213AbcLNSRD (ORCPT ); Wed, 14 Dec 2016 13:17:03 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57436 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753706AbcLNSRC (ORCPT ); Wed, 14 Dec 2016 13:17:02 -0500 Subject: Re: [PATCH v2] infiniband: remove WARN that is not kernel bug To: Leon Romanovsky , Jason Gunthorpe References: <1479723531-17940-1-git-send-email-dvyukov@google.com> <20161121114417.GA4158@leon.nu> <20161121121408.GC4158@leon.nu> <20161121165253.GA22237@obsidianresearch.com> <20161121173820.GC23083@leon.nu> Cc: Dmitry Vyukov , syzkaller , Valdis.Kletnieks@vt.edu, sean.hefty@intel.com, Hal Rosenstock , linux-rdma@vger.kernel.org, LKML From: Doug Ledford Message-ID: Date: Wed, 14 Dec 2016 13:16:45 -0500 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.0 MIME-Version: 1.0 In-Reply-To: <20161121173820.GC23083@leon.nu> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jvdmKT0T6FPMJf8CFa2N1EqdheSrb63Ri" X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Wed, 14 Dec 2016 18:17:01 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --jvdmKT0T6FPMJf8CFa2N1EqdheSrb63Ri Content-Type: multipart/mixed; boundary="KamagMOvhjVNpr8lfQ9RjrVtDh1UiVm1f"; protected-headers="v1" From: Doug Ledford To: Leon Romanovsky , Jason Gunthorpe Cc: Dmitry Vyukov , syzkaller , Valdis.Kletnieks@vt.edu, sean.hefty@intel.com, Hal Rosenstock , linux-rdma@vger.kernel.org, LKML Message-ID: Subject: Re: [PATCH v2] infiniband: remove WARN that is not kernel bug References: <1479723531-17940-1-git-send-email-dvyukov@google.com> <20161121114417.GA4158@leon.nu> <20161121121408.GC4158@leon.nu> <20161121165253.GA22237@obsidianresearch.com> <20161121173820.GC23083@leon.nu> In-Reply-To: <20161121173820.GC23083@leon.nu> --KamagMOvhjVNpr8lfQ9RjrVtDh1UiVm1f Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 11/21/2016 12:38 PM, Leon Romanovsky wrote: > On Mon, Nov 21, 2016 at 09:52:53AM -0700, Jason Gunthorpe wrote: >> On Mon, Nov 21, 2016 at 02:14:08PM +0200, Leon Romanovsky wrote: >>>> >>>> In ib_ucm_write function there is a wrong prefix: >>>> >>>> + pr_err_once("ucm_write: process %d (%s) tried to do something hink= y\n", >>> >>> I did it intentionally to have the same errors for all flows. >> >> Lets actually use a good message too please? >> >> pr_err_once("ucm_write: process %d (%s) changed security contexts aft= er opening FD, this is not allowed.\n", >> >> Jason I applied Leon's reworked version of this patch, thanks. --=20 Doug Ledford GPG Key ID: 0E572FDD --KamagMOvhjVNpr8lfQ9RjrVtDh1UiVm1f-- --jvdmKT0T6FPMJf8CFa2N1EqdheSrb63Ri Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBCAAGBQJYUYyNAAoJELgmozMOVy/dxhcP+gNQQHIqtAmzKwn/afKfFfRG U5MJ3hj/BG/FlYpvVPxk9UiBQRAXUCPk0pen7ozoGTSI3g17OP8ZV6xIJblzVaWZ /A2cC+vP81V2Nd/L5BF1VTa98721r1W9wDRW9JmpfkXzFdAC1HbImeaHvBAKD39U nnPDxlDW/rI8szC4oKBvvRhDV2tmsI+Cd0DU3m4FlsqdcHFjtaLXwXW58vwGRYQ3 tL5zl0cjlZ8Xp0Oo0tkV2a3QwUZfvG7YvI4t9JLi/isVh8FQB9Xmo/iX8+NTdgxP Wgab1q74WD8zFhCwcBD/uRNAfVC9ebTxHqIYyJNAaTjFGjCDym3yv7qFnDHyKKeC 1ykOpBiTfOkF8y3wVQZ8XkB47Xm7ZcugYAwP38e4gb1Sj0JDvt8Szb79SbzKYMzl TF/2/WmAhOi6gC8xXZJb6SH06DM5Oq9J83FIsRjj57+62vt9qw/exuTQ9LrK+hRR 5vxyuFfPdDrpFTpp+1ulShGzg74Pj36w6ls5KCYO1PMofCHte1hvnYAObibXswXU pC9bDuvPztdziYTO9nHaqWF10y/HyI+c0KsjZZRQqELAtwMD9esimZCrJNJ4277P JS073rr980LPkYKgTK2LhGW4+bjCbMRlcrpY4QSh0dQ+NnqQ6ZqpKzq0djvzhCOM Z/W9zr0LPhQRPLiYPsOl =OyjT -----END PGP SIGNATURE----- --jvdmKT0T6FPMJf8CFa2N1EqdheSrb63Ri--