* [PATCH] leds: netxbig: fix module autoload for OF registration
@ 2016-10-21 15:52 Javier Martinez Canillas
2016-11-29 15:00 ` Javier Martinez Canillas
0 siblings, 1 reply; 4+ messages in thread
From: Javier Martinez Canillas @ 2016-10-21 15:52 UTC (permalink / raw)
To: linux-kernel
Cc: Javier Martinez Canillas, Jacek Anaszewski, Richard Purdie, linux-leds
If the driver is built as a module, autoload won't work because the module
alias information is not filled. So user-space can't match the registered
device with the corresponding module.
Export the module alias information using the MODULE_DEVICE_TABLE() macro.
Before this patch:
$ modinfo drivers/leds//leds-netxbig.ko | grep alias
alias: platform:leds-netxbig
After this patch:
$ modinfo drivers/leds//leds-netxbig.ko | grep alias
alias: platform:leds-netxbig
alias: of:N*T*Clacie,netxbig-ledsC*
alias: of:N*T*Clacie,netxbig-leds
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
drivers/leds/leds-netxbig.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/leds/leds-netxbig.c b/drivers/leds/leds-netxbig.c
index 4b88b93244be..f48b1aed9b4e 100644
--- a/drivers/leds/leds-netxbig.c
+++ b/drivers/leds/leds-netxbig.c
@@ -534,6 +534,7 @@ static const struct of_device_id of_netxbig_leds_match[] = {
{ .compatible = "lacie,netxbig-leds", },
{},
};
+MODULE_DEVICE_TABLE(of, of_netxbig_leds_match);
#else
static inline int
netxbig_leds_get_of_pdata(struct device *dev,
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] leds: netxbig: fix module autoload for OF registration
2016-10-21 15:52 [PATCH] leds: netxbig: fix module autoload for OF registration Javier Martinez Canillas
@ 2016-11-29 15:00 ` Javier Martinez Canillas
2016-11-29 15:34 ` Jacek Anaszewski
0 siblings, 1 reply; 4+ messages in thread
From: Javier Martinez Canillas @ 2016-11-29 15:00 UTC (permalink / raw)
To: Jacek Anaszewski; +Cc: linux-kernel, Richard Purdie, linux-leds
Hello Jacek,
On 10/21/2016 12:52 PM, Javier Martinez Canillas wrote:
> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
>
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
>
> Before this patch:
>
> $ modinfo drivers/leds//leds-netxbig.ko | grep alias
> alias: platform:leds-netxbig
>
> After this patch:
>
> $ modinfo drivers/leds//leds-netxbig.ko | grep alias
> alias: platform:leds-netxbig
> alias: of:N*T*Clacie,netxbig-ledsC*
> alias: of:N*T*Clacie,netxbig-leds
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---
>
Any comments about this patch?
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] leds: netxbig: fix module autoload for OF registration
2016-11-29 15:00 ` Javier Martinez Canillas
@ 2016-11-29 15:34 ` Jacek Anaszewski
2016-11-29 15:38 ` Javier Martinez Canillas
0 siblings, 1 reply; 4+ messages in thread
From: Jacek Anaszewski @ 2016-11-29 15:34 UTC (permalink / raw)
To: Javier Martinez Canillas; +Cc: linux-kernel, Richard Purdie, linux-leds
Hi Javier,
On 11/29/2016 04:00 PM, Javier Martinez Canillas wrote:
> Hello Jacek,
>
> On 10/21/2016 12:52 PM, Javier Martinez Canillas wrote:
>> If the driver is built as a module, autoload won't work because the module
>> alias information is not filled. So user-space can't match the registered
>> device with the corresponding module.
>>
>> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
>>
>> Before this patch:
>>
>> $ modinfo drivers/leds//leds-netxbig.ko | grep alias
>> alias: platform:leds-netxbig
>>
>> After this patch:
>>
>> $ modinfo drivers/leds//leds-netxbig.ko | grep alias
>> alias: platform:leds-netxbig
>> alias: of:N*T*Clacie,netxbig-ledsC*
>> alias: of:N*T*Clacie,netxbig-leds
>>
>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>> ---
>>
>
> Any comments about this patch?
I mistakenly marked it as merged. Sorry about that.
Applied to the for-next branch of linux-leds.git.
--
Best regards,
Jacek Anaszewski
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] leds: netxbig: fix module autoload for OF registration
2016-11-29 15:34 ` Jacek Anaszewski
@ 2016-11-29 15:38 ` Javier Martinez Canillas
0 siblings, 0 replies; 4+ messages in thread
From: Javier Martinez Canillas @ 2016-11-29 15:38 UTC (permalink / raw)
To: Jacek Anaszewski; +Cc: linux-kernel, Richard Purdie, linux-leds
Hello Jacek,
On 11/29/2016 12:34 PM, Jacek Anaszewski wrote:
> Hi Javier,
>
> On 11/29/2016 04:00 PM, Javier Martinez Canillas wrote:
>> Hello Jacek,
>>
>> On 10/21/2016 12:52 PM, Javier Martinez Canillas wrote:
>>> If the driver is built as a module, autoload won't work because the module
>>> alias information is not filled. So user-space can't match the registered
>>> device with the corresponding module.
>>>
>>> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
>>>
>>> Before this patch:
>>>
>>> $ modinfo drivers/leds//leds-netxbig.ko | grep alias
>>> alias: platform:leds-netxbig
>>>
>>> After this patch:
>>>
>>> $ modinfo drivers/leds//leds-netxbig.ko | grep alias
>>> alias: platform:leds-netxbig
>>> alias: of:N*T*Clacie,netxbig-ledsC*
>>> alias: of:N*T*Clacie,netxbig-leds
>>>
>>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>>> ---
>>>
>>
>> Any comments about this patch?
>
> I mistakenly marked it as merged. Sorry about that.
> Applied to the for-next branch of linux-leds.git.
>
Great, thanks for the information.
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-11-29 15:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-21 15:52 [PATCH] leds: netxbig: fix module autoload for OF registration Javier Martinez Canillas
2016-11-29 15:00 ` Javier Martinez Canillas
2016-11-29 15:34 ` Jacek Anaszewski
2016-11-29 15:38 ` Javier Martinez Canillas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).