From: Sibi Sankar <quic_sibis@quicinc.com>
To: Yogesh Lal <quic_ylal@quicinc.com>, <bjorn.andersson@linaro.org>
Cc: <linux-arm-msm@vger.kernel.org>,
<linux-remoteproc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Siddharth Gupta <sidgup@codeaurora.org>
Subject: Re: [PATCH 2/2 V2] remoteproc: qcom: Add full coredump fallback mechanism
Date: Tue, 24 May 2022 15:33:30 +0530 [thread overview]
Message-ID: <b581789c-2c0c-b06e-924b-002b32f1a52a@quicinc.com> (raw)
In-Reply-To: <271132da-4a6a-afd9-4509-47035dd18a8e@quicinc.com>
On 5/21/22 11:44 AM, Sibi Sankar wrote:
> Hey Yogesh,
> Looks like you missed adding the patch that uses the exported
> rproc_cleanup api.
>
>
> On 5/10/22 4:55 PM, Yogesh Lal wrote:
>> From: Siddharth Gupta <sidgup@codeaurora.org>
>>
>> If a remoteproc's firmware does not support minidump but the driver
>> adds an ID, the minidump driver does not collect any coredumps when
>> the remoteproc crashes. This hinders the purpose of coredump
>> collection. This change adds a fallback mechanism in the event of a
>> crash.
>>
>
> Reviewed-by: Sibi Sankar <quic_sibis@quicinc.com>
>
>> Signed-off-by: Siddharth Gupta <sidgup@codeaurora.org>
>> Signed-off-by: Yogesh Lal <quic_ylal@quicinc.com>
>> ---
>> drivers/remoteproc/qcom_common.c | 7 +++++--
>> drivers/remoteproc/qcom_q6v5_pas.c | 1 +
>> 2 files changed, 6 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/remoteproc/qcom_common.c
>> b/drivers/remoteproc/qcom_common.c
>> index 4b91e3c..b3fdc66 100644
>> --- a/drivers/remoteproc/qcom_common.c
>> +++ b/drivers/remoteproc/qcom_common.c
>> @@ -163,8 +163,11 @@ void qcom_minidump(struct rproc *rproc, unsigned
>> int minidump_id)
>> */
>> if (subsystem->regions_baseptr == 0 ||
>> le32_to_cpu(subsystem->status) != 1 ||
>> - le32_to_cpu(subsystem->enabled) != MD_SS_ENABLED ||
>> - le32_to_cpu(subsystem->encryption_status) != MD_SS_ENCR_DONE) {
>> + le32_to_cpu(subsystem->enabled) != MD_SS_ENABLED) {
>> + return rproc_coredump(rproc);
>> + }
>> +
>> + if (le32_to_cpu(subsystem->encryption_status) != MD_SS_ENCR_DONE) {
>> dev_err(&rproc->dev, "Minidump not ready, skipping\n");
>> return;
>> }
Yogesh,
/**
* Clear out the dump segments populated by parse_fw before
* re-populating them with minidump segments.
*/
rproc_coredump_cleanup(rproc);
You'll still need to cleanup segments populated by parse_fw
before you move onto to minidumps.
>> diff --git a/drivers/remoteproc/qcom_q6v5_pas.c
>> b/drivers/remoteproc/qcom_q6v5_pas.c
>> index 401b1ec..6e5cbca 100644
>> --- a/drivers/remoteproc/qcom_q6v5_pas.c
>> +++ b/drivers/remoteproc/qcom_q6v5_pas.c
>> @@ -274,6 +274,7 @@ static const struct rproc_ops adsp_minidump_ops = {
>> .start = adsp_start,
>> .stop = adsp_stop,
>> .da_to_va = adsp_da_to_va,
>> + .parse_fw = qcom_register_dump_segments,
>> .load = adsp_load,
>> .panic = adsp_panic,
>> .coredump = adsp_minidump,
>>
next prev parent reply other threads:[~2022-05-24 10:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-10 11:25 [PATCH 1/2 V2] remoteproc: core: Export the rproc coredump APIs Yogesh Lal
2022-05-10 11:25 ` [PATCH 2/2 V2] remoteproc: qcom: Add full coredump fallback mechanism Yogesh Lal
2022-05-21 6:14 ` Sibi Sankar
2022-05-24 10:03 ` Sibi Sankar [this message]
2022-05-21 6:11 ` [PATCH 1/2 V2] remoteproc: core: Export the rproc coredump APIs Sibi Sankar
-- strict thread matches above, loose matches on Subject: below --
2022-05-05 17:41 [PATCH 1/2] " Yogesh Lal
2022-05-05 17:41 ` [PATCH 2/2 V2] remoteproc: qcom: Add full coredump fallback mechanism Yogesh Lal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b581789c-2c0c-b06e-924b-002b32f1a52a@quicinc.com \
--to=quic_sibis@quicinc.com \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=quic_ylal@quicinc.com \
--cc=sidgup@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).